Skip to content

Commit b5f2d57

Browse files
authored
fix: Make the 'welcome new contributors' workflow run again (#9448)
## The basics - [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change) ## The details ### Resolves Fixes #9447 ### Proposed Changes Pin the `actions/first-interactions` action to v1.3.0 and update the input parameters. Configure Dependabot to no longer try to upgrade this version. ### Reason for Changes There are three sets of failures being addressed here: 1. `v3.0.0` introduces a breaking changes by renaming the input names. 2. `v3.1.0` introduces a breaking change that somehow enforces `issue_message` being required which isn't being defined for Blockly (we only welcome on PRs). This hasn't been addressed by the action author so this PR pins to v3.0.0 to go back to a working version.\* 3. `v2` introduced a breaking behavioral change that caused all runs of the workflow to outright fail by not being compatible with `pull_request_target`. \* Technically it was broken when upgraded in #9323 due to a warning (rather than error) enforcing the now-required parameters. That was hiding a failure introduced when upgraded in #9274 that outright broke the workflow due to it running with `pull_request_target`. ### Test Coverage The team doesn't utilize automated tests for the workflow configurations themselves thus verifying them through running CI is sufficient. BenHenning#16 (review) demonstrates this passing and working correctly with a merged in version of this branch (since the workflow uses `pull_request_target` it cannot be verified in this PR's CI workflow) for a 'new' contributor (thanks for the help @rpbourret and @maribethb). ### Documentation No documentation changes are needed for this workflow configuration change. ### Additional Information Nothing to add that's not above or in the filed bug.
1 parent 592ee0a commit b5f2d57

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

.github/dependabot.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ updates:
2020
target-branch: 'develop'
2121
schedule:
2222
interval: 'weekly'
23+
ignore:
24+
# See notes in welcome_new_contributors.yml for details on this.
25+
- dependency-name: 'actions/first-interaction'
26+
versions: ['*']
2327
commit-message:
2428
prefix: 'chore(deps)'
2529
labels:

.github/workflows/welcome_new_contributors.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ jobs:
99
permissions:
1010
pull-requests: write
1111
steps:
12-
- uses: actions/first-interaction@v3
12+
# NOTE TO DEVELOPER: Per #9447 this is pinned to v1.3.0 and all updates
13+
# have been disabled for it. There are some largely incompatibilities on
14+
# v2 and v3 of the action that, without resolution, will break the first
15+
# interaction experience for new contributors. This dependency should not
16+
# be upgraded until those issues are resolved.
17+
- uses: actions/first-interaction@v1.3.0
1318
with:
1419
repo-token: ${{ secrets.GITHUB_TOKEN }}
1520
pr-message: >

0 commit comments

Comments
 (0)