[HUST CSE] Fix: possible absence of va_end after va_start

PeterKeyboard · PeterKeyboard · commit a528d5dc24e0 · 2023-04-23T22:48:09.000+08:00
diff --git a/apps/webclient/packages/webclient-v2.1.2/src/webclient.c b/apps/webclient/packages/webclient-v2.1.2/src/webclient.c
@@ -525,6 +525,7 @@ int webclient_header_fields_add(struct webclient_session *session, const char *f
     if (length < 0)
     {
         LOG_E("add fields header data failed, return length(%d) error.", length);
+        va_end(args);
         return -WEBCLIENT_ERROR;
     }
     va_end(args);
@@ -1560,6 +1561,7 @@ int webclient_request_header_add(char **request_header, const char *fmt, ...)
     if (length < 0)
     {
         LOG_E("add request header data failed, return length(%d) error.", length);
+        va_end(args);
         return -WEBCLIENT_ERROR;
     }
     va_end(args);

Original file line number	Diff line number	Diff line change
`@@ -525,6 +525,7 @@ int webclient_header_fields_add(struct webclient_session session, const char f`
`525`	`525`	`if (length < 0)`
`526`	`526`	`{`
`527`	`527`	`LOG_E("add fields header data failed, return length(%d) error.", length);`
	`528`	`+ va_end(args);`
`528`	`529`	`return -WEBCLIENT_ERROR;`
`529`	`530`	`}`
`530`	`531`	`va_end(args);`
`@@ -1560,6 +1561,7 @@ int webclient_request_header_add(char *request_header, const char fmt, ...)`
`1560`	`1561`	`if (length < 0)`
`1561`	`1562`	`{`
`1562`	`1563`	`LOG_E("add request header data failed, return length(%d) error.", length);`
	`1564`	`+ va_end(args);`
`1563`	`1565`	`return -WEBCLIENT_ERROR;`
`1564`	`1566`	`}`
`1565`	`1567`	`va_end(args);`