Skip to content

Commit 44b764a

Browse files
authored
Get rid of non-existent type (#30)
* Get rid of non-existent type * Test fix
1 parent 35fd8ee commit 44b764a

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "StridedViews"
22
uuid = "4db3bf67-4bd7-4b4e-b153-31dc3fb37143"
33
authors = ["Lukas Devos <lukas.devos@ugent.be>", "Jutho Haegeman <jutho.haegeman@ugent.be>"]
4-
version = "0.4.4"
4+
version = "0.4.5"
55

66
[deps]
77
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

ext/StridedViewsAMDGPUExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module StridedViewsAMDGPUExt
22

33
using StridedViews
44
using AMDGPU
5-
using AMDGPU: Adapt, ROCPtr
5+
using AMDGPU: Adapt
66

77
const ROCStridedView{T, N, A <: ROCArray{T}} = StridedView{T, N, A}
88

test/runtests.jl

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,23 +304,27 @@ using CUDA, AMDGPU
304304
if CUDA.functional()
305305
@testset "CuArrays with StridedView" begin
306306
@testset for T in (Float64, ComplexF64)
307-
A = CUDA.randn!(T, 10, 10, 10, 10)
307+
A = CUDA.randn(T, 10, 10, 10, 10)
308308
@test isstrided(A)
309309
B = StridedView(A)
310310
@test B isa StridedView
311-
@test B == A
311+
CUDA.@allowscalar begin
312+
@test B == A
313+
end
312314
end
313315
end
314316
end
315317

316318
if AMDGPU.functional()
317319
@testset "ROCArrays with StridedView" begin
318320
@testset for T in (Float64, ComplexF64)
319-
A = AMDGPU.randn!(T, 10, 10, 10, 10)
321+
A = ROCArray(randn(T, 10, 10, 10, 10))
320322
@test isstrided(A)
321323
B = StridedView(A)
322324
@test B isa StridedView
323-
@test B == A
325+
AMDGPU.@allowscalar begin
326+
@test B == A
327+
end
324328
end
325329
end
326330
end

0 commit comments

Comments
 (0)