Skip to content

Commit d3e0a35

Browse files
DennisOSRMCopilot
andauthored
fix: restore NPM_TOKEN auth and add --access public for scoped package publish (#7475)
* fix: explicitly dispatch CI after tag push to build release binaries GITHUB_TOKEN pushes do not trigger new workflow runs (GitHub prevents recursive loop triggers). This means the tag push from the release workflow never triggered osrm-backend.yml, so no binaries were built or uploaded to the release assets. Changes: - Add workflow_dispatch trigger to osrm-backend.yml - Add 'actions: write' permission to release workflow - After pushing the tag, explicitly dispatch osrm-backend.yml on the tag ref; CI runs with GITHUB_REF=refs/tags/v* so PUBLISH=On and prebuilt binaries are built and uploaded - Restore NODE_AUTH_TOKEN and add --access public for scoped npm package Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove redundant NPM_TOKEN and --access public from publish step publishConfig.access=public is already set in package.json, so --access public is redundant. OIDC via setup-node handles authentication when id-token: write is set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 1da889d commit d3e0a35

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

.github/workflows/osrm-backend.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
pull_request:
99
branches:
1010
- master
11+
workflow_dispatch:
1112

1213
env:
1314
CCACHE_TEMPDIR: /tmp/.ccache-temp

.github/workflows/release-monthly.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
permissions:
2727
contents: write
2828
id-token: write
29+
actions: write
2930
steps:
3031
- uses: actions/checkout@v6
3132
with:
@@ -133,6 +134,15 @@ jobs:
133134
git push origin "$BRANCH"
134135
git push origin "${{ steps.version.outputs.tag }}"
135136
137+
- name: Trigger CI for tag
138+
env:
139+
GH_TOKEN: ${{ github.token }}
140+
run: |
141+
# GITHUB_TOKEN pushes don't trigger workflow runs (prevents loops).
142+
# Explicitly dispatch CI on the tag so binaries get built and uploaded.
143+
gh workflow run osrm-backend.yml --ref "${{ steps.version.outputs.tag }}"
144+
echo "Dispatched osrm-backend.yml on ${{ steps.version.outputs.tag }}"
145+
136146
- name: Generate changelog
137147
id: changelog
138148
run: |

0 commit comments

Comments
 (0)