Skip to content

Commit 100db27

Browse files
authored
Signalfillempty set track_meta to True (#7089)
Related to #7011. I was using the `Signalfillemptyd` (based on `Signalfillempty`) transform in monailabel and found out, it currently allows no inversion. When digging deeper I realized that SignalFillEmpty just throws away the meta information. With the simple addition of `track_meta=True` it works as expected. I hope it has no other impact, but I honestly don't know. @wyli would be cool if we can add this to MONAI 1.3.0, thanks! I can also rework `Signalfillempty` to just accept any datatype, if that would the more appropriate approach. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>
1 parent 4cb7bb2 commit 100db27

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

monai/transforms/signal/array.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def __call__(self, signal: NdarrayOrTensor) -> NdarrayOrTensor:
380380
Args:
381381
signal: signal to be filled
382382
"""
383-
signal = torch.nan_to_num(convert_to_tensor(signal), nan=self.replacement)
383+
signal = torch.nan_to_num(convert_to_tensor(signal, track_meta=True), nan=self.replacement)
384384
return signal
385385

386386

0 commit comments

Comments
 (0)