Add PHPSTAN for 1.6 too

Author: apacios

.github/workflows/php.yml

@@ -26,22 +26,33 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        presta-versions: ['1.7.0.3', 'latest']
+        presta-versions: ['latest', '1.7.0.3', '1.6.1.21','1.6.1.0']
     steps:
       - name: Checkout
         uses: actions/checkout@v2.0.0
+
       - name: Cache vendor folder
         uses: actions/cache@v1
         with:
           path: vendor
           key: php-${{ hashFiles('composer.lock') }}
+
       - name: Cache composer folder
         uses: actions/cache@v1
         with:
           path: ~/.composer/cache
           key: php-composer-cache
+
       - run: composer install
+
       - name: Pull PrestaShop files (Tag ${{ matrix.presta-versions }})
         run: docker run -tid --rm -v ps-volume:/var/www/html --name temp-ps prestashop/prestashop:${{ matrix.presta-versions }}
+
+      - name: Select .neon file to run with PHPStan
+        id: neon
+        run: |
+          PS_VERSION=$(docker exec temp-ps bash -c 'echo "$PS_VERSION"')
+          [[ "${PS_VERSION:0:3}" != '1.7' ]] && echo ::set-output name=filename::phpstan-PS-1.6.neon || echo ::set-output name=filename::phpstan-PS-1.7.neon
+
       - name : Run PHPStan
-        run: docker run --rm --volumes-from temp-ps -v $PWD:/web/module -e _PS_ROOT_DIR_=/var/www/html --workdir=/web/module phpstan/phpstan:0.12 analyse --configuration=/web/module/tests/phpstan/phpstan.neon
+        run: docker run --rm --volumes-from temp-ps -v $PWD:/web/module -e _PS_ROOT_DIR_=/var/www/html --workdir=/web/module phpstan/phpstan:0.12 analyse --configuration=/web/module/tests/phpstan/${{steps.neon.outputs.filename}}

tests/phpstan/phpstan-PS-1.6.neon

@@ -0,0 +1,14 @@
+includes:
+	- %currentWorkingDirectory%/vendor/prestashop/php-dev-tools/phpstan/ps-module-extension.neon
+
+parameters:
+	paths:
+		- ../../classes
+		- ../../controllers
+		- ../../ps_googleanalytics.php
+	reportUnmatchedIgnoredErrors: false
+	ignoreErrors:
+		- '#Strict comparison using === between false and Module will always evaluate to false.#'
+		- '#PrestaShop.Module.Ps_Googleanalytics.Handler.ModuleHandler::uninstallModule\(\) calls parent::uninstall\(\) but PrestaShop.Module.Ps_Googleanalytics.Handler.ModuleHandler does not extend any class.#'
+
+	level: 5