Skip to content

Commit b5cabae

Browse files
committed
bump min compat to PHP713 n PS177
1 parent 20cdcca commit b5cabae

4 files changed

Lines changed: 13 additions & 18 deletions

File tree

.github/workflows/php.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ on: [push, pull_request]
33
jobs:
44
# Check there is no syntax errors in the project
55
php-linter:
6-
name: PHP Syntax check 5.6 => 8.1
6+
name: PHP Syntax check 7.1 => 8.1
77
runs-on: ubuntu-latest
88
steps:
99
- name: Checkout
10-
uses: actions/checkout@v2.0.0
10+
uses: actions/checkout@v3.1.0
1111

12-
- name: PHP syntax checker 5.6
13-
uses: prestashop/github-action-php-lint/5.6@master
12+
- name: PHP syntax checker 7.1
13+
uses: prestashop/github-action-php-lint/7.1@master
1414

1515
- name: PHP syntax checker 7.2
1616
uses: prestashop/github-action-php-lint/7.2@master
@@ -38,10 +38,10 @@ jobs:
3838
php-version: '7.4'
3939

4040
- name: Checkout
41-
uses: actions/checkout@v2.0.0
41+
uses: actions/checkout@v3.1.0
4242

4343
- name: Cache dependencies
44-
uses: actions/cache@v2
44+
uses: actions/cache@v3
4545
with:
4646
path: vendor
4747
key: php-${{ hashFiles('composer.lock') }}
@@ -58,26 +58,26 @@ jobs:
5858
runs-on: ubuntu-latest
5959
strategy:
6060
matrix:
61-
presta-versions: ['1.7.6', '1.7.7', '1.7.8', 'latest']
61+
presta-versions: ['1.7.7', '1.7.8', '8.0', 'latest']
6262
steps:
6363
- name: Setup PHP
6464
uses: shivammathur/setup-php@v2
6565
with:
6666
php-version: '7.4'
6767

6868
- name: Checkout
69-
uses: actions/checkout@v2.0.0
69+
uses: actions/checkout@v3.1.0
7070

7171
# Add vendor folder in cache to make next builds faster
7272
- name: Cache vendor folder
73-
uses: actions/cache@v1
73+
uses: actions/cache@v3
7474
with:
7575
path: vendor
7676
key: php-${{ hashFiles('composer.lock') }}
7777

7878
# Add composer local folder in cache to make next builds faster
7979
- name: Cache composer folder
80-
uses: actions/cache@v1
80+
uses: actions/cache@v3
8181
with:
8282
path: ~/.composer/cache
8383
key: php-composer-cache

composer.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,15 @@
1010
}
1111
],
1212
"require": {
13-
"php": ">=5.6"
13+
"php": ">=7.1.3"
1414
},
1515
"require-dev": {
1616
"prestashop/php-dev-tools": "3.*"
1717
},
1818
"config": {
1919
"preferred-install": "dist",
2020
"optimize-autoloader": true,
21-
"prepend-autoloader": false,
22-
"platform": {
23-
"php": "5.6"
24-
}
21+
"prepend-autoloader": false
2522
},
2623
"autoload": {
2724
"classmap": [

ps_googleanalytics.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function __construct()
4848
$this->name = 'ps_googleanalytics';
4949
$this->tab = 'analytics_stats';
5050
$this->version = '5.0.0';
51-
$this->ps_versions_compliancy = ['min' => '1.7.6', 'max' => _PS_VERSION_];
51+
$this->ps_versions_compliancy = ['min' => '1.7.7', 'max' => _PS_VERSION_];
5252
$this->author = 'PrestaShop';
5353
$this->module_key = 'fd2aaefea84ac1bb512e6f1878d990b8';
5454
$this->bootstrap = true;
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,5 @@ includes:
44
parameters:
55
ignoreErrors:
66
- '#PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler::uninstallModule\(\) calls parent::uninstall\(\) but PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler does not extend any class.#'
7-
- '#Property TabCore\:\:\$name \(string\) does not accept array.#'
8-
- '#Parameter \#1 \$id of class Currency constructor expects null, int given.#'
97
- '#Access to an undefined property Cookie\:\:\$ga_admin_order.#'
108
- '#Access to an undefined property Cookie\:\:\$ga_admin_refund.#'

0 commit comments

Comments
 (0)