Comply with phpstan for PS 1.6

matks · matks · commit 8c24779bf103 · 2020-08-27T16:34:27.000+02:00
diff --git a/classes/Hook/HookDisplayBackOfficeHeader.php b/classes/Hook/HookDisplayBackOfficeHeader.php
@@ -49,7 +49,7 @@ public function __construct(Ps_Googleanalytics $module, Context $context)
     public function run()
     {
         if (Configuration::get('GA_TRACK_BACKOFFICE_DISABLED')) {
-            return;
+            return '';
         }
 
         $js = '';
diff --git a/classes/Hook/HookDisplayHeader.php b/classes/Hook/HookDisplayHeader.php
@@ -47,11 +47,11 @@ public function __construct(Ps_Googleanalytics $module, Context $context)
     public function run()
     {
         if (!Configuration::get('GA_ACCOUNT_ID')) {
-            return;
+            return '';
         }
 
         if (Configuration::get('GA_TRACK_BACKOFFICE_DISABLED') && $this->backOffice) {
-            return;
+            return '';
         }
 
         $this->context->controller->addJs($this->module->getPathUri() . 'views/js/GoogleAnalyticActionLib.js');

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function __construct(Ps_Googleanalytics $module, Context $context)`
`49`	`49`	`public function run()`
`50`	`50`	`{`
`51`	`51`	`if (Configuration::get('GA_TRACK_BACKOFFICE_DISABLED')) {`
`52`		`- return;`
	`52`	`+ return '';`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`$js = '';`
Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ public function __construct(Ps_Googleanalytics $module, Context $context)`
`47`	`47`	`public function run()`
`48`	`48`	`{`
`49`	`49`	`if (!Configuration::get('GA_ACCOUNT_ID')) {`
`50`		`- return;`
	`50`	`+ return '';`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if (Configuration::get('GA_TRACK_BACKOFFICE_DISABLED') && $this->backOffice) {`
`54`		`- return;`
	`54`	`+ return '';`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`$this->context->controller->addJs($this->module->getPathUri() . 'views/js/GoogleAnalyticActionLib.js');`