Improve controllers

Author: apacios

classes/Repository/GanalyticsRepository.php

@@ -81,15 +81,17 @@ public function addNewRow(array $data, $type = \Db::INSERT_IGNORE)
      *
      * @param array $data
      * @param string $where
+     * @param int $limit
      *
      * @return bool
      */
-    public function updateData($data, $where)
+    public function updateData($data, $where, $limit = 0)
     {
         return \Db::getInstance()->update(
             self::TABLE_NAME,
             $data,
-            $where
+            $where,
+            $limit
         );
     }
 }

controllers/admin/AdminGanalyticsAjax.php

@@ -17,20 +17,30 @@
  * @license   https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)
  * International Registered Trademark & Property of PrestaShop SA
  */
+
+use PrestaShop\Module\Ps_Googleanalytics\Repository\GanalyticsRepository;
+
 class AdminGanalyticsAjaxController extends ModuleAdminController
 {
     public $ssl = true;
 
     public function init()
     {
-        $order = new Order((int) Tools::getValue('orderid'));
-        $context = Context::getContext();
-        if (Validate::isLoadedObject($order) && (isset($context->employee->id) && $context->employee->id)) {
-            Db::getInstance()->execute('
-                UPDATE `' . _DB_PREFIX_ . 'ganalytics` SET sent = 1, date_add = NOW() WHERE id_order = ' . (int) Tools::getValue('orderid')
+        $orderId = (int) Tools::getValue('orderid');
+        $order = new Order($orderId);
+
+        if (Validate::isLoadedObject($order) && (isset($this->context->employee->id) && $this->context->employee->id)) {
+            (new GanalyticsRepository())->updateData(
+                [
+                    'sent' => 1,
+                    'date_add' => 'NOW()',
+                ],
+                'id_order = ' . $orderId
             );
-            die('OK');
+
+            $this->ajaxDie('OK');
         }
-        die('KO');
+
+        $this->ajaxDie('KO');
     }
 }

controllers/front/ajax.php

@@ -17,6 +17,9 @@
  * @license   https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)
  * International Registered Trademark & Property of PrestaShop SA
  */
+
+use PrestaShop\Module\Ps_Googleanalytics\Repository\GanalyticsRepository;
+
 class ps_GoogleanalyticsAjaxModuleFrontController extends ModuleFrontController
 {
     public $ssl = true;
@@ -28,13 +31,22 @@ public function initContent()
     {
         parent::initContent();
 
-        $order = new Order((int) Tools::getValue('orderid'));
+        $orderId = (int) Tools::getValue('orderid');
+        $order = new Order($orderId);
+
         if (!Validate::isLoadedObject($order) || $order->id_customer != (int) Tools::getValue('customer')) {
-            die;
+            $this->ajaxDie('KO');
         }
-        Db::getInstance()->execute(
-            'UPDATE `' . _DB_PREFIX_ . 'ganalytics` SET sent = 1, date_add = NOW() WHERE id_order = ' . (int) Tools::getValue('orderid') . ' LIMIT 1'
+
+        (new GanalyticsRepository())->updateData(
+            [
+                'sent' => 1,
+                'date_add' => 'NOW()',
+            ],
+            'id_order = ' . $orderId,
+            1
         );
-        die;
+
+        $this->ajaxDie('OK');
     }
 }