Improve PHPStan error handled

Author: apacios

.gitignore

@@ -1,3 +1,3 @@
 vendor/
 .php_cs.cache
-.prettyci.composer.json
+.prettyci.composer.json

.prettyci.composer.json

@@ -26,6 +26,10 @@
 class HookActionCartSave implements HookInterface
 {
     private $module;
+
+    /**
+     * @var \Context
+     */
     private $context;
 
     public function __construct(\Ps_Googleanalytics $module, \Context $context)
@@ -58,7 +62,7 @@ public function run()
         ];
 
         $cartProducts = $this->context->cart->getProducts();
-        if (isset($cartProducts) && count($cartProducts)) {
+        if (!empty($cartProducts)) {
             foreach ($cartProducts as $cartProduct) {
                 if ($cartProduct['id_product'] == \Tools::getValue('id_product')) {
                     $addProduct = $cartProduct;

classes/Hook/HookActionCartSave.php

@@ -48,8 +48,8 @@ public function run()
             $gaScripts .= 'MBG.add(' . json_encode(
                 [
                     'id' => empty($orderDetail->product_attribute_id) ? $orderDetail->product_id : $orderDetail->product_id . '-' . $orderDetail->product_attribute_id,
-                    'quantity' => $quantity, ]
-                )
+                    'quantity' => $quantity,
+                ])
                 . ');';
         }
 

classes/Hook/HookActionProductCancel.php

@@ -10,9 +10,6 @@ parameters:
 	ignoreErrors:
 		- '#Property Ps_Googleanalytics::\$version \(float\) does not accept string.#'
 		- '#Strict comparison using === between false and Module will always evaluate to false.#'
-		-
-			message: '#Access to an undefined property object::\$shop.#'
-			path: ../../classes/Hook/HookActionCartSave.php
 		- '#PrestaShop.Module.Ps_Googleanalytics.Handler.ModuleHandler::uninstallModule\(\) calls parent::uninstall\(\) but PrestaShop.Module.Ps_Googleanalytics.Handler.ModuleHandler does not extend any class.#'
 
 	level: 5