Update carrier repository by adding the table name as a const

apacios · apacios · commit 1ad38c41095c · 2020-05-11T12:22:36.000+02:00
diff --git a/classes/Repository/CarrierRepository.php b/classes/Repository/CarrierRepository.php
@@ -22,6 +22,8 @@
 
 class CarrierRepository
 {
+    const TABLE_NAME = 'carrier';
+
     /**
      * findByCarrierId
      *
@@ -33,7 +35,7 @@ public function findByCarrierId($carrierId)
     {
         return \Db::getInstance()->getValue(
             'SELECT name
-            FROM `' . _DB_PREFIX_ . 'carrier`
+            FROM `' . _DB_PREFIX_ . self::TABLE_NAME . '`
             WHERE id_carrier = ' . (int) $carrierId
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`
`23`	`23`	`class CarrierRepository`
`24`	`24`	`{`
	`25`	`+ const TABLE_NAME = 'carrier';`
	`26`	`+`
`25`	`27`	`/**`
`26`	`28`	`* findByCarrierId`
`27`	`29`	`*`
`@@ -33,7 +35,7 @@ public function findByCarrierId($carrierId)`
`33`	`35`	`{`
`34`	`36`	`return \Db::getInstance()->getValue(`
`35`	`37`	`'SELECT name`
`36`		- FROM `' . _DB_PREFIX_ . 'carrier`
	`38`	+ FROM `' . _DB_PREFIX_ . self::TABLE_NAME . '`
`37`	`39`	`WHERE id_carrier = ' . (int) $carrierId`
`38`	`40`	`);`
`39`	`41`	`}`