Use IDisposable pattern while creating PowerShell objects

Author: Kapil Borle

Engine/Generic/ModuleDependencyHandler.cs

@@ -205,12 +205,14 @@ private void SaveModule(PSObject module)
             ThrowIfNull(module, "module");
 
             // TODO validate module
-            var ps = System.Management.Automation.PowerShell.Create();
-            ps.Runspace = runspace;
-            ps.AddCommand("Save-Module")
-                .AddParameter("Path", tempModulePath)
-                .AddParameter("InputObject", module);
-            ps.Invoke();
+            using (var ps = System.Management.Automation.PowerShell.Create())
+            {
+                ps.Runspace = runspace;
+                ps.AddCommand("Save-Module")
+                    .AddParameter("Path", tempModulePath)
+                    .AddParameter("InputObject", module);
+                ps.Invoke();
+            }
         }
 
         private void SetupPSModulePath()
@@ -295,13 +297,15 @@ public PSObject FindModule(string moduleName)
             {
                 return modulesFound[moduleName];
             }
-            var ps = System.Management.Automation.PowerShell.Create();
-            Collection<PSObject> modules = null;            
-            ps.Runspace = runspace;
-            ps.AddCommand("Find-Module", true)
-                .AddParameter("Name", moduleName)
-                .AddParameter("Repository", moduleRepository);
-            modules = ps.Invoke<PSObject>();            
+            Collection<PSObject> modules = null;
+            using (var ps = System.Management.Automation.PowerShell.Create())
+            {
+                ps.Runspace = runspace;
+                ps.AddCommand("Find-Module", true)
+                    .AddParameter("Name", moduleName)
+                    .AddParameter("Repository", moduleRepository);
+                modules = ps.Invoke<PSObject>();
+            }
             if (modules == null)
             {
                 return null;
@@ -345,13 +349,15 @@ public void SaveModule(string moduleName)
             {                
                 return;
             }
-            var ps = System.Management.Automation.PowerShell.Create();
-            ps.Runspace = runspace;
-            ps.AddCommand("Save-Module")
-                .AddParameter("Path", tempModulePath)
-                .AddParameter("Name", moduleName)
-                .AddParameter("Force");
-            ps.Invoke();
+            using (var ps = System.Management.Automation.PowerShell.Create())
+            {
+                ps.Runspace = runspace;
+                ps.AddCommand("Save-Module")
+                    .AddParameter("Path", tempModulePath)
+                    .AddParameter("Name", moduleName)
+                    .AddParameter("Force");
+                ps.Invoke();
+            }
         }
 
         /// <summary>