Fix settings hashtable input

Hashtable keys were compared in case-sensitive manner to lower case valid
keys while adding values to the lists of severity, rule inclusion and rule
exclusion.

This commit also remove the relevant code duplication in ParseProfileHashtable
and ParseProfileString while adding the values to the respective lists.

Author: Kapil Borle

Engine/ScriptAnalyzer.cs

@@ -216,6 +216,30 @@ internal bool ParseProfile(object profileObject, PathIntrinsics path, IOutputWri
             return true;
         }
 
+        private bool TryAddingProfileItem(
+            string key,
+            List<string> values,
+            List<string> severityList,
+            List<string> includeRuleList,
+            List<string> excludeRuleList)
+        {
+            switch (key.ToLower())
+            {
+                case "severity":
+                    severityList.AddRange(values);
+                    break;
+                case "includerules":
+                    includeRuleList.AddRange(values);
+                    break;
+                case "excluderules":
+                    excludeRuleList.AddRange(values);
+                    break;
+                default:
+                    return false;
+            }
+            return true;
+        }
+
         private bool ParseProfileHashtable(Hashtable profile, PathIntrinsics path, IOutputWriter writer,
             List<string> severityList, List<string> includeRuleList, List<string> excludeRuleList)
         {
@@ -238,7 +262,7 @@ private bool ParseProfileHashtable(Hashtable profile, PathIntrinsics path, IOutp
                     hasError = true;
                     continue;
                 }
-
+                
                 // checks whether it falls into list of valid keys
                 if (!validKeys.Contains(key))
                 {
@@ -293,21 +317,8 @@ private bool ParseProfileHashtable(Hashtable profile, PathIntrinsics path, IOutp
                     }
                 }
 
-                // now add to the list
-                switch (key)
-                {
-                    case "severity":
-                        severityList.AddRange(values);
-                        break;
-                    case "includerules":
-                        includeRuleList.AddRange(values);
-                        break;
-                    case "excluderules":
-                        excludeRuleList.AddRange(values);
-                        break;
-                    default:
-                        break;
-                }
+                TryAddingProfileItem(key, values, severityList, includeRuleList, excludeRuleList);
+            
             }
 
             return hasError;
@@ -426,23 +437,12 @@ private bool ParseProfileString(string profile, PathIntrinsics path, IOutputWrit
 
                         string key = (kvp.Item1 as StringConstantExpressionAst).Value.ToLower();
 
-                        switch (key)
+                        if(!TryAddingProfileItem(key, rhsList, severityList, includeRuleList, excludeRuleList))
                         {
-                            case "severity":
-                                severityList.AddRange(rhsList);
-                                break;
-                            case "includerules":
-                                includeRuleList.AddRange(rhsList);
-                                break;
-                            case "excluderules":
-                                excludeRuleList.AddRange(rhsList);
-                                break;
-                            default:
-                                writer.WriteError(new ErrorRecord(
+                            writer.WriteError(new ErrorRecord(
                                     new InvalidDataException(string.Format(CultureInfo.CurrentCulture, Strings.WrongKey, key, kvp.Item1.Extent.StartLineNumber, kvp.Item1.Extent.StartColumnNumber, profile)),
                                     Strings.WrongConfigurationKey, ErrorCategory.InvalidData, profile));
-                                hasError = true;
-                                break;
+                            hasError = true;
                         }
                     }
                 }