Improve module name comparison in module handler

Author: Kapil Borle

Engine/Generic/ModuleDependencyHandler.cs

@@ -86,10 +86,20 @@ private void SetModulesInTempPath()
             // we assume the modules have not been tampered with
             foreach (var dir in Directory.EnumerateDirectories(tempDirPath))
             {
-                modulesSavedInTempPath.Add(Path.GetFileName(dir));
+                AddModuleName(modulesSavedInTempPath, Path.GetFileName(dir));
             }
         }
 
+        private void AddModuleName(HashSet<string> hashSet, string moduleName)
+        {
+            hashSet.Add(moduleName.ToLower());
+        }
+
+        private bool IsModuleNamePresent(HashSet<string> hashSet, string moduleName)
+        {
+            return hashSet.Contains(moduleName.ToLower());
+        }
+
         private void SetupTempDir()
         {
             CreateTempDir();
@@ -138,7 +148,7 @@ private void CleanUp()
             // remove the modules from local psmodule path            
             foreach (var dir in Directory.EnumerateDirectories(localPSModulePath))
             {
-                if (modulesSavedInModulePath.Contains(Path.GetFileName(dir)))
+                if (IsModuleNamePresent(modulesSavedInModulePath, Path.GetFileName(dir)))                    
                 {
                     Directory.Delete(dir, true);
                 }
@@ -220,6 +230,7 @@ public void SetupDefaultRunspace(Runspace runspace)
         public PSObject FindModule(string moduleName)
         {
             ThrowIfNull(moduleName, "moduleName");
+            moduleName = moduleName.ToLower();
             if (modulesFound.ContainsKey(moduleName))
             {
                 return modulesFound[moduleName];
@@ -256,11 +267,11 @@ public bool ModuleExists(string moduleName)
         public void SaveModule(string moduleName)
         {
             ThrowIfNull(moduleName, "moduleName");
-            if (modulesSavedInModulePath.Contains(moduleName))
+            if (IsModuleNamePresent(modulesSavedInModulePath, moduleName))
             {
                 return;
             }
-            if (modulesSavedInTempPath.Contains(moduleName))
+            if (IsModuleNamePresent(modulesSavedInTempPath, moduleName))
             {
                 // copy to local ps module path
                 CopyToPSModulePath(moduleName);
@@ -277,7 +288,7 @@ public void SaveModule(string moduleName)
                         moduleRepository));
             }            
             SaveModule(module);
-            modulesSavedInTempPath.Add(moduleName);            
+            AddModuleName(modulesSavedInTempPath, moduleName);             
             CopyToPSModulePath(moduleName);
         }        
 
@@ -294,7 +305,7 @@ private void CopyToPSModulePath(string moduleName, bool checkModulePresence = fa
                 }
             }
             CopyDir(Path.Combine(tempDirPath, moduleName), localPSModulePath);
-            modulesSavedInModulePath.Add(moduleName);
+            AddModuleName(modulesSavedInModulePath, moduleName);            
         }
 
         public static string GetModuleNameFromErrorExtent(ParseError error, ScriptBlockAst ast)