Move GetShippedSettingsDirectory to helper

Author: Kapil Borle

Engine/Helper.cs

@@ -21,6 +21,7 @@
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 using System.Management.Automation.Runspaces;
 using System.Collections;
+using System.Reflection;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
@@ -172,6 +173,35 @@ public void Initialize()
             }
         }
 
+        /// <summary>
+        /// Retrieves the Settings directory from the Module directory structure
+        /// </summary>
+        public static string GetShippedSettingsDirectory()
+        {
+            // Find the compatibility files in Settings folder
+            var path = typeof(Helper).GetTypeInfo().Assembly.Location;
+            if (String.IsNullOrWhiteSpace(path))
+            {
+                return null;
+            }
+
+            var settingsPath = Path.Combine(Path.GetDirectoryName(path), "Settings");
+            if (!Directory.Exists(settingsPath))
+            {
+                // try one level down as the PSScriptAnalyzer module structure is not consistent
+                // CORECLR binaries are in PSScriptAnalyzer/coreclr/, PowerShell v3 binaries are in PSScriptAnalyzer/PSv3/
+                // and PowerShell v5 binaries are in PSScriptAnalyzer/
+                settingsPath = Path.Combine(Path.GetDirectoryName(Path.GetDirectoryName(path)), "Settings");
+                if (!Directory.Exists(settingsPath))
+                {
+                    return null;
+                }
+            }
+
+            return settingsPath;
+        }
+
+
         /// <summary>
         /// Returns all the rule arguments
         /// </summary>

Rules/UseCompatibleCmdlets.cs

@@ -306,8 +306,7 @@ private void SetupCmdletsDictionary()
                 return;
             }
 
-            string settingsPath;
-            settingsPath = GetShippedSettingsDirectory();
+            string settingsPath = Helper.GetShippedSettingsDirectory();
 #if DEBUG
             object modeObject;
             if (ruleArgs.TryGetValue("mode", out modeObject))
@@ -381,34 +380,6 @@ private void ResetCurCmdletCompatibilityMap()
             }
         }
 
-        /// <summary>
-        /// Retrieves the Settings directory from the Module directory structure
-        /// </summary>
-        private string GetShippedSettingsDirectory()
-        {
-            // Find the compatibility files in Settings folder
-            var path = this.GetType().GetTypeInfo().Assembly.Location;
-            if (String.IsNullOrWhiteSpace(path))
-            {
-                return null;
-            }
-
-            var settingsPath = Path.Combine(Path.GetDirectoryName(path), "Settings");
-            if (!Directory.Exists(settingsPath))
-            {
-                // try one level down as the PSScriptAnalyzer module structure is not consistent
-                // CORECLR binaries are in PSScriptAnalyzer/coreclr/, PowerShell v3 binaries are in PSScriptAnalyzer/PSv3/
-                // and PowerShell v5 binaries are in PSScriptAnalyzer/
-                settingsPath = Path.Combine(Path.GetDirectoryName(Path.GetDirectoryName(path)), "Settings");
-                if (!Directory.Exists(settingsPath))
-                {
-                    return null;
-                }
-            }
-
-            return settingsPath;
-        }
-
         private bool IsValidPlatformString(string fileNameWithoutExt)
         {
             string psedition, psversion, os;