Move test helper to test root directory

Author: Kapil Borle

Engine/PSScriptAnalyzer.psm1

@@ -2,11 +2,6 @@
 # Script module for module 'PSScriptAnalyzer'
 #
 
-function Test-PSEditionCoreCLR
-{
-    ($PSVersionTable.Keys -contains "PSEdition") -and ($PSVersionTable.PSEdition -ne 'Desktop')
-}
-
 # Clear PSDefaultParameterValues in the module scope and enable strict mode
 $PSDefaultParameterValues.Clear()
 Set-StrictMode -Version Latest
@@ -19,7 +14,7 @@ $PSModuleRoot = $PSModule.ModuleBase
 $binaryModuleRoot = $PSModuleRoot
 
 
-if ((Test-PSEditionCoreCLR)) {
+if (($PSVersionTable.Keys -contains "PSEdition") -and ($PSVersionTable.PSEdition -ne 'Desktop')) {
     $binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath 'coreclr'
 }
 else

Tests/Engine/GetScriptAnalyzerRule.tests.ps1

@@ -1,6 +1,9 @@
-Import-Module -Verbose PSScriptAnalyzer
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+Import-Module -Verbose PSScriptAnalyzer
+$testRootDirectory = Split-Path -Parent $directory
+Import-Module (Join-Path $testRootDirectory 'PSScriptAnalyzerTestHelper.psm1')
 $sa = Get-Command Get-ScriptAnalyzerRule
-$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+
 $singularNouns = "PSUseSingularNouns" # this rule does not exist for coreclr version
 $approvedVerbs = "PSUseApprovedVerbs"
 $cmdletAliases = "PSAvoidUsingCmdletAliases"

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -4,6 +4,9 @@
 if (!(Get-Module PSScriptAnalyzer) -and !$testingLibraryUsage)
 {
 	Import-Module PSScriptAnalyzer
+    $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+    $testRootDirectory = Split-Path -Parent $directory
+    Import-Module (Join-Path $testRootDirectory 'PSScriptAnalyzerTestHelper.psm1')
 }
 
 $sa = Get-Command Invoke-ScriptAnalyzer

Tests/Engine/LibraryUsage.tests.ps1

@@ -1,3 +1,6 @@
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+$testRootDirectory = Split-Path -Parent $directory
+Import-Module (Join-Path $testRootDirectory 'PSScriptAnalyzerTestHelper.psm1')
 Import-Module PSScriptAnalyzer
 
 # test is meant to verify functionality if chsarp apis are used. Hence not if psedition is CoreCLR