Rename and make static a method in Helper

Kapil Borle · Kapil Borle · commit c4065e7d3aa8 · 2016-04-22T21:52:32.000-07:00
diff --git a/Engine/Helper.cs b/Engine/Helper.cs
@@ -274,7 +274,7 @@ public PSModuleInfo GetModuleManifest(string filePath, out IEnumerable<ErrorReco
         /// </summary>
         /// <param name="errorRecord"></param>
         /// <returns>Returns a boolean value indicating the presence of MissingMemberException</returns>
-        public bool IsMissingMemberException(ErrorRecord errorRecord)
+        public static bool IsMissingManifestMemberException(ErrorRecord errorRecord)
         {
             return errorRecord.CategoryInfo != null
                 && errorRecord.CategoryInfo.Category == ErrorCategory.ResourceUnavailable
diff --git a/Rules/MissingModuleManifestField.cs b/Rules/MissingModuleManifestField.cs
@@ -44,7 +44,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 {
                     foreach (var errorRecord in errorRecords)
                     {
-                        if (Helper.Instance.IsMissingMemberException(errorRecord))
+                        if (Helper.IsMissingManifestMemberException(errorRecord))
                         {
                             System.Diagnostics.Debug.Assert(errorRecord.Exception != null && !String.IsNullOrWhiteSpace(errorRecord.Exception.Message), Strings.NullErrorMessage);
                             yield return

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ public PSModuleInfo GetModuleManifest(string filePath, out IEnumerable<ErrorReco`
`274`	`274`	`/// </summary>`
`275`	`275`	`/// <param name="errorRecord"></param>`
`276`	`276`	`/// <returns>Returns a boolean value indicating the presence of MissingMemberException</returns>`
`277`		`- public bool IsMissingMemberException(ErrorRecord errorRecord)`
	`277`	`+ public static bool IsMissingManifestMemberException(ErrorRecord errorRecord)`
`278`	`278`	`{`
`279`	`279`	`return errorRecord.CategoryInfo != null`
`280`	`280`	`&& errorRecord.CategoryInfo.Category == ErrorCategory.ResourceUnavailable`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`44`	`44`	`{`
`45`	`45`	`foreach (var errorRecord in errorRecords)`
`46`	`46`	`{`
`47`		`- if (Helper.Instance.IsMissingMemberException(errorRecord))`
	`47`	`+ if (Helper.IsMissingManifestMemberException(errorRecord))`
`48`	`48`	`{`
`49`	`49`	`System.Diagnostics.Debug.Assert(errorRecord.Exception != null && !String.IsNullOrWhiteSpace(errorRecord.Exception.Message), Strings.NullErrorMessage);`
`50`	`50`	`yield return`