Add tests for UseLiteralInitializerForHashtable rule

Author: Kapil Borle

Tests/Engine/GetScriptAnalyzerRule.tests.ps1

@@ -16,7 +16,7 @@ Describe "Test available parameters" {
         It "has a RuleName parameter" {
             $params.ContainsKey("Name") | Should Be $true
         }
-        
+
         It "accepts string" {
             $params["Name"].ParameterType.FullName | Should Be "System.String[]"
         }
@@ -61,10 +61,10 @@ Describe "Test Name parameters" {
 
         It "get Rules with no parameters supplied" {
 			$defaultRules = Get-ScriptAnalyzerRule
-            $expectedNumRules = 41
+            $expectedNumRules = 42
             if ((Test-PSEditionCoreClr))
             {
-                $expectedNumRules = 40
+                $expectedNumRules = 41
             }
 			$defaultRules.Count | Should be $expectedNumRules
 		}
@@ -117,7 +117,7 @@ Describe "Test RuleExtension" {
 
         It "with Name of a built-in rules" {
             $ruleExtension = Get-ScriptAnalyzerRule -CustomizedRulePath $directory\CommunityAnalyzerRules\CommunityAnalyzerRules.psm1 -Name $singularNouns
-            $ruleExtension.Count | Should Be 0            
+            $ruleExtension.Count | Should Be 0
         }
 
         It "with Names of built-in, DSC and non-built-in rules" {
@@ -137,7 +137,7 @@ Describe "Test RuleExtension" {
             }
             catch
             {
-                $Error[0].FullyQualifiedErrorId | should match "PathNotFound,Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands.GetScriptAnalyzerRuleCommand"            
+                $Error[0].FullyQualifiedErrorId | should match "PathNotFound,Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands.GetScriptAnalyzerRuleCommand"
             }
         }
 

Tests/Rules/UseLiteralInitializerForHashtable.tests.ps1

@@ -0,0 +1,65 @@
+Import-Module PSScriptAnalyzer
+$ruleName = "PSUseLiteralInitializerForHashtable"
+
+Describe "UseLiteralInitlializerForHashtable" {
+    Context "When new-object hashtable is used to create a hashtable" {
+        It "has violation" {
+            $violationScriptDef = @'
+            $htable1 = new-object hashtable
+            $htable2 = new-object system.collection.hashtable
+            $htable3 = new-object -Typename hashtable -ArgumentList 10
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations.Count | Should Be 3
+        }
+
+        It "does not detect violation if arguments given to new-object contain ignore case string comparer" {
+            $violationScriptDef = @'
+            $htable1 = new-object hashtable [system.stringcomparer]::ordinalignorecase
+            $htable2 = new-object -Typename hashtable -ArgumentList [system.stringcomparer]::ordinalignorecase
+            $htable3 = new-object hashtable -ArgumentList [system.stringcomparer]::ordinalignorecase
+            $htable4 = new-object -Typename hashtable [system.stringcomparer]::ordinalignorecase
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations.Count | Should Be 0
+        }
+
+        It "suggests correction" {
+            $violationScriptDef = @'
+            $htable1 = new-object hashtable
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations[0].SuggestedCorrections[0].Text | Should Be '@{}'
+        }
+    }
+
+    Context "When [hashtable]::new is used to create a hashtable" {
+        It "has violation" {
+            $violationScriptDef = @'
+            $htable1 = [hashtable]::new()
+            $htable2 = [system.collection.hashtable]::new()
+            $htable3 = [hashtable]::new(10)
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations.Count | Should Be 3
+        }
+
+        It "does not detect violation if arguments given to [hashtable]::new contain ignore case string comparer" {
+            $violationScriptDef = @'
+            $htable1 = [hashtable]::new(10, [system.stringcomparer]::ordinalignorecase)
+            $htable2 = [hashtable]::new(10, [system.stringcomparer]::ordinalignorecase)
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations.Count | Should Be 0
+        }
+
+        It "suggests correction" {
+            $violationScriptDef = @'
+            $htable1 = [hashtable]::new()
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $violationScriptDef -IncludeRule $ruleName
+            $violations[0].SuggestedCorrections[0].Text | Should Be '@{}'
+        }
+
+    }
+}