Merge pull request #159 from GoodOlClint/PSAvoidDefaultTrueValueSwitchParameter

Correct PSAvoidDefaultTrueValueSwitchParameter rule to work with both [switch] and [System.Management.Automation.SwitchParameter] attributes

Author: yutingc

Rules/AvoidDefaultTrueValueSwitchParameter.cs

@@ -39,7 +39,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             // Iterrates all ParamAsts and check if any are switch.
             foreach (ParameterAst paramAst in paramAsts)
             {
-                if (paramAst.Attributes.Any(attr => String.Equals(attr.TypeName.FullName, "switch", StringComparison.OrdinalIgnoreCase))
+                if (paramAst.Attributes.Any(attr => string.Equals(attr.TypeName.GetReflectionType().FullName, "system.management.automation.switchparameter", StringComparison.OrdinalIgnoreCase))
                     && paramAst.DefaultValue != null && String.Equals(paramAst.DefaultValue.Extent.Text, "$true", StringComparison.OrdinalIgnoreCase))
                 {
                     yield return new DiagnosticRecord(

Tests/Rules/AvoidDefaultTrueValueSwitchParameter.ps1

@@ -13,7 +13,11 @@
 
         # Param2 help description
         [switch]
-        $switch=$true
+        $switch=$true,
+        
+        # Param3 help description
+        [System.Management.Automation.SwitchParameter]
+        $switch2 = $true
     )
 
     Begin

Tests/Rules/AvoidDefaultTrueValueSwitchParameter.tests.ps1

@@ -7,8 +7,8 @@ $noViolations = Invoke-ScriptAnalyzer $directory\AvoidDefaultTrueValueSwitchPara
 
 Describe "AvoidDefaultTrueValueSwitchParameter" {
     Context "When there are violations" {
-        It "has 1 avoid using switch parameter default to true violation" {
-            $violations.Count | Should Be 1
+        It "has 2 avoid using switch parameter default to true violation" {
+            $violations.Count | Should Be 2
         }
 
         It "has the correct description message" {