Fix failing tests

Sets the path of the test helper module correctly.

Author: Kapil Borle

Tests/Rules/AvoidUsingAlias.tests.ps1

@@ -5,6 +5,7 @@ $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violationFilepath = Join-Path $directory 'AvoidUsingAlias.ps1'
 $violations = Invoke-ScriptAnalyzer $violationFilepath | Where-Object {$_.RuleName -eq $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\AvoidUsingAliasNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
+Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1")
 
 Describe "AvoidUsingAlias" {
     Context "When there are violations" {
@@ -17,7 +18,6 @@ Describe "AvoidUsingAlias" {
         }
 
 	It "suggests correction" {
-	   Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	   Test-CorrectionExtent $violationFilepath $violations[0] 1 'iex' 'Invoke-Expression'
 	   $violations[0].SuggestedCorrections[0].Description | Should Be 'Replace iex with Invoke-Expression'
 

Tests/Rules/AvoidUsingPlainTextForPassword.tests.ps1

@@ -1,11 +1,11 @@
 Import-Module PSScriptAnalyzer
-
 $violationMessage = [regex]::Escape("Parameter '`$password' should use SecureString, otherwise this will expose sensitive information. See ConvertTo-SecureString for more information.")
 $violationName = "PSAvoidUsingPlainTextForPassword"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violationFilepath = Join-Path $directory 'AvoidUsingPlainTextForPassword.ps1'
 $violations = Invoke-ScriptAnalyzer $violationFilepath | Where-Object {$_.RuleName -eq $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\AvoidUsingPlainTextForPasswordNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
+Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1")
 
 Describe "AvoidUsingPlainTextForPassword" {
     Context "When there are violations" {
@@ -14,7 +14,6 @@ Describe "AvoidUsingPlainTextForPassword" {
         }
 
 	It "suggests corrections" {
-            Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	    Test-CorrectionExtent $violationFilepath $violations[0] 1 '$passphrases' '[SecureString] $passphrases'
 	    $violations[0].SuggestedCorrections[0].Description | Should Be 'Set $passphrases type to SecureString'
 

Tests/Rules/MisleadingBacktick.tests.ps1

@@ -4,6 +4,7 @@ $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violationFilepath = Join-Path $directory 'MisleadingBacktick.ps1'
 $violations = Invoke-ScriptAnalyzer $violationFilepath | Where-Object {$_.RuleName -eq $writeHostName}
 $noViolations = Invoke-ScriptAnalyzer $directory\NoMisleadingBacktick.ps1 | Where-Object {$_.RuleName -eq $clearHostName}
+Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1")
 
 Describe "Avoid Misleading Backticks" {
     Context "When there are violations" {
@@ -12,7 +13,6 @@ Describe "Avoid Misleading Backticks" {
         }
 
 	It "suggests correction" {
-	   Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	   Test-CorrectionExtent $violationFilepath $violations[0] 1 ' ' ''
 	   Test-CorrectionExtent $violationFilepath $violations[1] 1 ' ' ''
 	   Test-CorrectionExtent $violationFilepath $violations[2] 1 ' ' ''

Tests/Rules/UseToExportFieldsInManifest.tests.ps1

@@ -10,6 +10,7 @@ $testManifestBadVariablesWildcardPath = "ManifestBadVariablesWildcard.psd1"
 $testManifestBadAllPath = "ManifestBadAll.psd1"
 $testManifestGoodPath = "ManifestGood.psd1"
 $testManifestInvalidPath = "ManifestInvalid.psd1"
+Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1")
 
 Function Run-PSScriptAnalyzerRule 
 {
@@ -40,7 +41,6 @@ Describe "UseManifestExportFields" {
         }
 
 	It "suggests corrections for FunctionsToExport with wildcard" {
-	    Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	    $violations = Run-PSScriptAnalyzerRule $testManifestBadFunctionsWildcardPath
 	    $violationFilepath = Join-path $testManifestPath $testManifestBadFunctionsWildcardPath
 	    Test-CorrectionExtent $violationFilepath $violations[0] 1 "'*'" "@('Get-Foo', 'Get-Bar')"
@@ -54,7 +54,6 @@ Describe "UseManifestExportFields" {
         }
 
 	It "suggests corrections for FunctionsToExport with null" {
-	    Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	    $violations = Run-PSScriptAnalyzerRule $testManifestBadFunctionsNullPath
 	    $violationFilepath = Join-path $testManifestPath $testManifestBadFunctionsNullPath
 	    Test-CorrectionExtent $violationFilepath $violations[0] 1  '$null' "@('Get-Foo', 'Get-Bar')"
@@ -84,7 +83,6 @@ Describe "UseManifestExportFields" {
         }
 
 	It "suggests corrections for AliasesToExport with wildcard" {
-	    Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	    $violations = Run-PSScriptAnalyzerRule $testManifestBadAliasesWildcardPath
 	    $violationFilepath = Join-path $testManifestPath $testManifestBadAliasesWildcardPath
 	    Test-CorrectionExtent $violationFilepath $violations[0] 1  "'*'" "@('gfoo', 'gbar')"