Interpret target in suppression as regular expression

According to README, target supports regular expression. By escaping the target argument, it is no longer a regular expression. This commit removes the escaping.

Ideally, we should not replace '*' with '.*' as we explicity mention that target takes regular expression. But, since globbing is more widely used in such scenario and if we do not interpret '*' as a glob, there is a chance it will invalidate suppression in many cases where people have used this feature. Hence, to maintain compatibility we keep '*' interpretation as a glob.

Author: Kapil Borle

Engine/Generic/RuleSuppression.cs

@@ -20,7 +20,7 @@
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic
 {
     /// <summary>
-    /// 
+    ///
     /// </summary>
     public class RuleSuppression
     {
@@ -185,11 +185,11 @@ public RuleSuppression(AttributeAst attrAst, int start, int end)
                             case 2:
                                 RuleSuppressionID = (positionalArguments[1] as StringConstantExpressionAst).Value;
                                 goto case 1;
-                            
+
                             case 1:
                                 RuleName = (positionalArguments[0] as StringConstantExpressionAst).Value;
                                 goto default;
-                            
+
                             default:
                                 break;
                         }
@@ -281,7 +281,7 @@ public RuleSuppression(AttributeAst attrAst, int start, int end)
                     RuleName = String.Empty;
                     Error = Strings.NullRuleNameError;
                 }
-                
+
                 // Must have scope and target together
                 if (String.IsNullOrWhiteSpace(Scope) && !String.IsNullOrWhiteSpace(Target))
                 {
@@ -357,8 +357,10 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at
                         ruleSupp.Target = "*";
                     }
 
+                    // According to documentation 'target' supports regular expression. But to maintain compatibility with
+                    // previous implementation we interpret '*' as a glob and therefore replace '*' with '.*'
                     // regex for wild card *
-                    Regex reg = new Regex(String.Format("^{0}$", Regex.Escape(ruleSupp.Target).Replace(@"\*", ".*")), RegexOptions.IgnoreCase);
+                    Regex reg = new Regex(String.Format("^{0}$", ruleSupp.Target.Replace(@"*", ".*")), RegexOptions.IgnoreCase);
                     IEnumerable<Ast> targetAsts = null;
 
                     switch (ruleSupp.Scope.ToLower())