Update open brace violation finder implementation

Author: Kapil Borle

Rules/UseWhitespace.cs

@@ -91,14 +91,20 @@ private string GetError(ErrorKind kind)
 
         private IEnumerable<DiagnosticRecord> FindOpenBraceViolations(TokenOperations tokenOperations)
         {
-            var tokensAndWhitespaces = tokenOperations.GetOpenBracesWithWhiteSpacesBefore();
-            foreach (var item in tokensAndWhitespaces)
+            foreach (var lcurly in tokenOperations.GetTokenNodes(TokenKind.LCurly))
             {
-                if (item.Item2 != whiteSpaceSize)
+                if (lcurly.Previous == null
+                    || !IsPreviousTokenOnSameLine(lcurly)
+                    || lcurly.Previous.Value.Kind == TokenKind.LCurly)
+                {
+                    continue;
+                }
+
+                if (!IsPreviousTokenApartByWhitespace(lcurly))
                 {
                     yield return new DiagnosticRecord(
                         GetError(ErrorKind.Brace),
-                        item.Item1.Extent,
+                        lcurly.Value.Extent,
                         GetName(),
                         GetDiagnosticSeverity(),
                         tokenOperations.Ast.Extent.File,
@@ -123,8 +129,7 @@ private IEnumerable<DiagnosticRecord> FindOpenParenViolations(TokenOperations to
                     continue;
                 }
 
-                if (whiteSpaceSize !=
-                    lparen.Value.Extent.StartColumnNumber - lparen.Previous.Value.Extent.EndColumnNumber)
+                if (!IsPreviousTokenApartByWhitespace(lparen))
                 {
                     yield return new DiagnosticRecord(
                         GetError(ErrorKind.Paren),
@@ -138,6 +143,12 @@ private IEnumerable<DiagnosticRecord> FindOpenParenViolations(TokenOperations to
             }
         }
 
+        private bool IsPreviousTokenApartByWhitespace(LinkedListNode<Token> tokenNode)
+        {
+            return whiteSpaceSize ==
+                (tokenNode.Value.Extent.StartColumnNumber - tokenNode.Previous.Value.Extent.EndColumnNumber);
+        }
+
         private bool IsPreviousTokenOnSameLine(LinkedListNode<Token> lparen)
         {
             return lparen.Previous.Value.Extent.StartLineNumber == lparen.Value.Extent.EndLineNumber;