Use one corrections method for all violation kinds

Author: Kapil Borle

Rules/UseWhitespace.cs

@@ -132,7 +132,7 @@ private IEnumerable<DiagnosticRecord> FindOpenBraceViolations(TokenOperations to
                         GetDiagnosticSeverity(),
                         tokenOperations.Ast.Extent.File,
                         null,
-                        GetOpenBracketCorrections(lcurly.Value).ToList());
+                        GetCorrections(lcurly.Previous.Value, lcurly.Value, lcurly.Next.Value, false, true).ToList());
                 }
             }
         }
@@ -183,7 +183,12 @@ private IEnumerable<DiagnosticRecord> FindSeparatorViolations(TokenOperations to
                 yield return getDiagnosticRecord(
                     tokenNode.Value,
                     errorKind,
-                    GetOperatorCorrections(tokenNode.Previous.Value, tokenNode.Value, tokenNode.Next.Value, true, false).ToList());
+                    GetCorrections(
+                        tokenNode.Previous.Value,
+                        tokenNode.Value,
+                        tokenNode.Next.Value,
+                        true,
+                        false));
             }
         }
 
@@ -257,17 +262,17 @@ private IEnumerable<DiagnosticRecord> FindOperatorViolations(TokenOperations tok
                         GetDiagnosticSeverity(),
                         tokenOperations.Ast.Extent.File,
                         null,
-                        GetOperatorCorrections(
+                        GetCorrections(
                             tokenNode.Previous.Value,
                             tokenNode.Value,
                             tokenNode.Next.Value,
                             hasWhitespaceBefore,
-                            hasWhitespaceAfter).ToList());
+                            hasWhitespaceAfter));
                 }
             }
         }
 
-        private IEnumerable<CorrectionExtent> GetOperatorCorrections(
+        private List<CorrectionExtent> GetCorrections(
             Token prevToken,
             Token token,
             Token nextToken,
@@ -293,11 +298,14 @@ private IEnumerable<CorrectionExtent> GetOperatorCorrections(
                 new ScriptPosition(e1.File, e1.EndLineNumber, e1.EndColumnNumber, null),
                 new ScriptPosition(e2.File, e2.StartLineNumber, e2.StartColumnNumber, null));
 
-            yield return new CorrectionExtent(
+            return new List<CorrectionExtent>()
+            {
+                new CorrectionExtent(
                 extent,
                 sb.ToString(),
                 token.Extent.File,
-                GetError(ErrorKind.Operator));
+                GetError(ErrorKind.Operator))
+            };
         }
 
         private bool IsOperator(Token token)