Set default compatibility value to true

Kapil Borle · Kapil Borle · commit 1b3e7cf43136 · 2016-09-22T13:51:09.000-07:00
diff --git a/Rules/UseCompatibleCmdlets.cs b/Rules/UseCompatibleCmdlets.cs
@@ -31,7 +31,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     #if !CORECLR
     [Export(typeof(IScriptRule))]
 #endif
-    class UseCompatibleCmdlets : AstVisitor, IScriptRule
+    public class UseCompatibleCmdlets : AstVisitor, IScriptRule
     {
         private List<DiagnosticRecord> diagnosticRecords;
         private Dictionary<string, HashSet<string>> psCmdletMap;
@@ -104,7 +104,7 @@ private void SetupCmdletsDictionary()
                 if (GetVersionInfoFromPlatformString(compat, out psedition, out psversion, out os))
                 {
                     platformSpecMap.Add(compat, new { PSEdition = psedition, PSVersion = psversion, OS = os });
-                    curCmdletCompatibilityMap.Add(compat, false);
+                    curCmdletCompatibilityMap.Add(compat, true);
                 }
             }
 
@@ -339,6 +339,7 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)
             }
 
             curCmdletAst = commandAst;
+            ResetCurCmdletCompatibilityMap();
             CheckCompatibility();
             GenerateDiagnosticRecords();
             return AstVisitAction.Continue;

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`31`	`31`	`#if !CORECLR`
`32`	`32`	`[Export(typeof(IScriptRule))]`
`33`	`33`	`#endif`
`34`		`- class UseCompatibleCmdlets : AstVisitor, IScriptRule`
	`34`	`+ public class UseCompatibleCmdlets : AstVisitor, IScriptRule`
`35`	`35`	`{`
`36`	`36`	`private List<DiagnosticRecord> diagnosticRecords;`
`37`	`37`	`private Dictionary<string, HashSet<string>> psCmdletMap;`
`@@ -104,7 +104,7 @@ private void SetupCmdletsDictionary()`
`104`	`104`	`if (GetVersionInfoFromPlatformString(compat, out psedition, out psversion, out os))`
`105`	`105`	`{`
`106`	`106`	`platformSpecMap.Add(compat, new { PSEdition = psedition, PSVersion = psversion, OS = os });`
`107`		`- curCmdletCompatibilityMap.Add(compat, false);`
	`107`	`+ curCmdletCompatibilityMap.Add(compat, true);`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
`@@ -339,6 +339,7 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`curCmdletAst = commandAst;`
	`342`	`+ ResetCurCmdletCompatibilityMap();`
`342`	`343`	`CheckCompatibility();`
`343`	`344`	`GenerateDiagnosticRecords();`
`344`	`345`	`return AstVisitAction.Continue;`