Merge pull request #28 from PowerShell/FixTestFailures

Fix test failures

Author: quoctruong

Tests/Disabled Rules/AvoidOneChar.tests.ps1

@@ -0,0 +1,24 @@
+Import-Module PSScriptAnalyzer
+$oneCharMessage = "The cmdlet name O only has one character."
+$oneCharName = "PSOneChar"
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+$invoke = Invoke-ScriptAnalyzer $directory\AvoidUsingReservedCharOneCharNames.ps1 | Where-Object {$_.RuleName -eq $oneCharName}
+$noViolations = Invoke-ScriptAnalyzer $directory\GoodCmdlet.ps1 | Where-Object {$_.RuleName -eq $oneCharName}
+
+Describe "Avoid Using One Char" {
+    Context "When there are violations" {
+        It "has 1 One Char Violation" {
+            $oneCharViolations.Count | Should Be 1
+        }
+
+        It "has the correct description message" {
+            $oneCharViolations[0].Message | Should Match $oneCharMessage
+        }
+    }
+
+    Context "When there are no violations" {
+        It "has no violations" {
+            $noReservedCharViolations.Count | Should Be 0
+        }
+    }
+}

Tests/Disabled Rules/AvoidUnloadableModule.tests.ps1

@@ -0,0 +1,24 @@
+Import-Module PSScriptAnalyzer 
+$unloadableMessage = [regex]::Escape("Cannot load the module TestBadModule that the file TestBadModule.psd1 is in.")
+$unloadableName = "PSAvoidUnloadableModule"
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+$violations = Invoke-ScriptAnalyzer $directory\TestBadModule\TestBadModule.psd1 | Where-Object {$_.RuleName -eq $unloadableName}
+$noViolations = Invoke-ScriptAnalyzer $directory\TestGoodModule\TestGoodModule.psd1 | Where-Object {$_.RuleName -eq $unloadableName}
+
+Describe "AvoidUnloadableModule" {
+    Context "When there are violations" {
+        It "has 1 unloadable module violation" {
+            $violations.Count | Should Be 1
+        }
+
+        It "has the correct description message" {
+            $violations.Message | Should Match $unloadableMessage
+        }
+    }
+
+    Context "When there are no violations" {
+        It "returns no violations" {
+            $noViolations.Count | Should Be 0
+        }
+    }
+}

…s/Rules/AvoidUsingClearHostWriteHost.ps1 …s/Disabled Rules/AvoidUsingClearHost.ps1Tests/Rules/AvoidUsingClearHostWriteHost.ps1 renamed to Tests/Disabled Rules/AvoidUsingClearHost.ps1 Tests/Rules/AvoidUsingClearHostWriteHost.ps1 renamed to Tests/Disabled Rules/AvoidUsingClearHost.ps1

@@ -0,0 +1,25 @@
+Import-Module PSScriptAnalyzer
+Set-Alias ctss ConvertTo-SecureString
+$clearHostMessage = "File 'AvoidUsingClearHostWriteHost.ps1' uses Clear-Host. This is not recommended because it may not work in some hosts or there may even be no hosts at all."
+$clearHostName = "PSAvoidUsingClearHost"
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+$violations = Invoke-ScriptAnalyzer $directory\AvoidUsingClearHost.ps1 | Where-Object {$_.RuleName -eq $clearHostName}
+$noViolations = Invoke-ScriptAnalyzer $directory\AvoidUsingClearHostNoViolations.ps1 | Where-Object {$_.RuleName -eq $writeHostName}
+
+Describe "AvoidUsingClearHost" {
+    Context "When there are violations" {
+        It "has 3 Clear-Host violations" {
+            $violations.Count | Should Be 3
+        }
+
+        It "has the correct description message for Clear-Host" {
+            $violations[0].Message | Should Match $clearHostMessage
+        }
+    }
+
+    Context "When there are no violations" {
+        It "returns no violations" {
+            $noViolations.Count | Should Be 0
+        }
+    }
+}

Tests/Disabled Rules/AvoidUsingClearHost.tests.ps1

@@ -1,4 +1,4 @@
-Import-Module ScriptAnalyzer
+Import-Module PSScriptAnalyzer
 $violationMessage = @'
 The file path "D:\\Code" of AvoidUsingFilePath.ps1 is rooted. This should be avoided if AvoidUsingFilePath.ps1 is published online
 '@