Merge pull request #700 from PowerShell/kapilmb/fix-indentation-rule

Handle DollarParen token kind in indentation rule

Author: Kapil Borle

Rules/UseConsistentIndentation.cs

@@ -80,6 +80,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
                     case TokenKind.AtParen:
                     case TokenKind.LParen:
                     case TokenKind.LCurly:
+                    case TokenKind.DollarParen:
                         AddViolation(token, indentationLevel++, diagnosticRecords, ref onNewLine);
                         break;
 

Tests/Rules/UseConsistentIndentation.tests.ps1

@@ -97,4 +97,20 @@ $param3
             $violations.Count | Should Be 4
         }
     }
+
+    Context "When a sub-expression is provided" {
+        BeforeAll {
+            $def = @'
+function foo {
+    $x = $("abc")
+    $x
+}
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings
+        }
+
+        It "Should not find a violations" {
+            $violations.Count | Should Be 0
+        }
+    }
 }