Fix failing tests

Author: Kapil Borle

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -190,7 +190,7 @@ public object Settings
         private bool stopProcessing;
 
         /// <summary>
-        /// Resolve DSC resoure dependency
+        /// Resolve DSC resource dependency
         /// </summary>
         [Parameter(Mandatory = false)]
         public SwitchParameter ResolveDscResourceDependency
@@ -257,6 +257,21 @@ protected override void ProcessRecord()
             }
         }
 
+        protected override void EndProcessing()
+        {
+            ScriptAnalyzer.Instance.CleanUp();
+            base.EndProcessing();
+        }
+
+        protected override void StopProcessing()
+        {
+            ScriptAnalyzer.Instance.CleanUp();
+            base.StopProcessing();
+        }
+
+        #endregion
+
+        #region Methods
         private void ProcessInput()
         {
             IEnumerable<DiagnosticRecord> diagnosticsList = Enumerable.Empty<DiagnosticRecord>();
@@ -269,61 +284,26 @@ private void ProcessInput()
                     diagnosticsList = ScriptAnalyzer.Instance.AnalyzePath(
                         this.SessionState.Path.GetUnresolvedProviderPathFromPSPath(p.Path),
                         this.recurse);
+                    WriteToOutput(diagnosticsList);
                 }
             }
             else if (String.Equals(this.ParameterSetName, "ScriptDefinition", StringComparison.OrdinalIgnoreCase))
             {
                 diagnosticsList = ScriptAnalyzer.Instance.AnalyzeScriptDefinition(scriptDefinition);
+                WriteToOutput(diagnosticsList);
             }
+        }
 
+        private void WriteToOutput(IEnumerable<DiagnosticRecord> diagnosticRecords)
+        {
             foreach (ILogger logger in ScriptAnalyzer.Instance.Loggers)
             {
-                foreach (DiagnosticRecord diagnostic in diagnosticsList)
+                foreach (DiagnosticRecord diagnostic in diagnosticRecords)
                 {
                     logger.LogObject(diagnostic, this);
                 }
             }
         }
-
-        protected override void EndProcessing()
-        {
-            ScriptAnalyzer.Instance.CleanUp();
-            base.EndProcessing();
-        }
-
-        protected override void StopProcessing()
-        {
-            ScriptAnalyzer.Instance.CleanUp();
-            base.StopProcessing();
-        }
-
-        #endregion
-
-        #region Methods
-
-        //private void ProcessPathOrScriptDefinition(string pathOrScriptDefinition)
-        //{
-        //    IEnumerable<DiagnosticRecord> diagnosticsList = Enumerable.Empty<DiagnosticRecord>();
-
-        //    if (String.Equals(this.ParameterSetName, "File", StringComparison.OrdinalIgnoreCase))
-        //    {
-        //        diagnosticsList = ScriptAnalyzer.Instance.AnalyzePath(pathOrScriptDefinition, this.recurse);
-        //    }
-        //    else if (String.Equals(this.ParameterSetName, "ScriptDefinition", StringComparison.OrdinalIgnoreCase))
-        //    {
-        //        diagnosticsList = ScriptAnalyzer.Instance.AnalyzeScriptDefinition(pathOrScriptDefinition);
-        //    }
-
-        //    //Output through loggers
-        //    foreach (ILogger logger in ScriptAnalyzer.Instance.Loggers)
-        //    {
-        //        foreach (DiagnosticRecord diagnostic in diagnosticsList)
-        //        {
-        //            logger.LogObject(diagnostic, this);
-        //        }
-        //    }
-        //}
-
         #endregion
     }
 }

Engine/ScriptAnalyzer.cs

@@ -1170,7 +1170,7 @@ public IEnumerable<DiagnosticRecord> AnalyzePath(string path, bool searchRecursi
                         this));
             }
 
-            // Precreate the list of script file paths to analyze.  This
+            // Create in advance the list of script file paths to analyze.  This
             // is an optimization over doing the whole operation at once
             // and calling .Concat on IEnumerables to join results.
             this.BuildScriptPathList(path, searchRecursively, scriptFilePaths);
@@ -1185,23 +1185,6 @@ public IEnumerable<DiagnosticRecord> AnalyzePath(string path, bool searchRecursi
             }
         }
 
-        //private List<DiagnosticRecord> AnalyzePaths(
-        //    IEnumerable<string> scriptFilePaths,
-        //    ModuleDependencyHandler moduleHandler)
-        //{
-        //    var diagnosticRecords = new List<DiagnosticRecord>();
-        //    foreach (string scriptFilePath in scriptFilePaths)
-        //    {
-        //        // Yield each record in the result so that the
-        //        // caller can pull them one at a time
-        //        foreach (var diagnosticRecord in this.AnalyzeFile(scriptFilePath, moduleHandler))
-        //        {
-        //            diagnosticRecords.Add(diagnosticRecord);
-        //        }
-        //    }
-        //    return diagnosticRecords;
-        //}
-
         /// <summary>
         /// Analyzes a script definition in the form of a string input
         /// </summary>