test source correct, but heap overflow on others

Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>

Author: TonyXiang8787

tests/cpp_unit_tests/test_source.cpp

@@ -198,10 +198,36 @@ TEST_CASE("Test source") {
         changed = source.update(SourceUpdate{.id = 1, .status = 0, .u_ref = nan, .u_ref_angle = nan});
         CHECK(!changed.topo);
         CHECK(!changed.param);
+
+        // test updating sk, rx_ratio, z01_ratio (status remains 0)
+        changed = source.update(SourceUpdate{
+            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = 20e6, .rx_ratio = nan, .z01_ratio = nan});
+        CHECK(!changed.topo);
+        CHECK(changed.param);
+
+        // verify the new impedance affects math_param
+        DoubleComplex const y_ref_sym_updated = source.math_param<symmetric_t>().template y_ref<symmetric_t>();
+        CHECK(cabs(y_ref_sym_updated - y_ref_sym) > numerical_tolerance); // should be different
+
+        changed = source.update(SourceUpdate{
+            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = 0.2, .z01_ratio = nan});
+        CHECK(!changed.topo);
+        CHECK(changed.param);
+
+        changed = source.update(SourceUpdate{
+            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = nan, .z01_ratio = 4.0});
+        CHECK(!changed.topo);
+        CHECK(changed.param);
+
+        changed = source.update(SourceUpdate{
+            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = nan, .z01_ratio = nan});
+        CHECK(!changed.topo);
+        CHECK(!changed.param);
     }
 
     SUBCASE("Update inverse") {
-        SourceUpdate source_update{.id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan};
+        SourceUpdate source_update{
+            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = nan, .z01_ratio = nan};
         auto expected = source_update;
 
         SUBCASE("Identical") {
@@ -225,13 +251,37 @@ TEST_CASE("Test source") {
             expected.u_ref_angle = nan;
         }
 
+        SUBCASE("sk") {
+            SUBCASE("same") { source_update.sk = sk; }
+            SUBCASE("different") { source_update.sk = 20e6; }
+            expected.sk = sk;
+        }
+
+        SUBCASE("rx_ratio") {
+            SUBCASE("same") { source_update.rx_ratio = rx_ratio; }
+            SUBCASE("different") { source_update.rx_ratio = 0.2; }
+            expected.rx_ratio = rx_ratio;
+        }
+
+        SUBCASE("z01_ratio") {
+            SUBCASE("same") { source_update.z01_ratio = z01_ratio; }
+            SUBCASE("different") { source_update.z01_ratio = 4.0; }
+            expected.z01_ratio = z01_ratio;
+        }
+
         SUBCASE("multiple") {
             source_update.status = IntS{0};
             source_update.u_ref = 0.0;
             source_update.u_ref_angle = 0.1;
+            source_update.sk = 20e6;
+            source_update.rx_ratio = 0.2;
+            source_update.z01_ratio = 4.0;
             expected.status = status_to_int(source.status());
             expected.u_ref = u_input;
             expected.u_ref_angle = nan;
+            expected.sk = sk;
+            expected.rx_ratio = rx_ratio;
+            expected.z01_ratio = z01_ratio;
         }
 
         auto const inv = source.inverse(source_update);
@@ -240,6 +290,9 @@ TEST_CASE("Test source") {
         CHECK(inv.status == expected.status);
         check_nan_preserving_equality(inv.u_ref, expected.u_ref);
         check_nan_preserving_equality(inv.u_ref_angle, expected.u_ref_angle);
+        check_nan_preserving_equality(inv.sk, expected.sk);
+        check_nan_preserving_equality(inv.rx_ratio, expected.rx_ratio);
+        check_nan_preserving_equality(inv.z01_ratio, expected.z01_ratio);
     }
 }