fix test

Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>

Author: TonyXiang8787

power_grid_model_c/power_grid_model/include/power_grid_model/component/source.hpp

@@ -87,13 +87,13 @@ class Source : public Appliance {
     UpdateChange update(SourceUpdate const& update_data) {
         assert(update_data.id == this->id() || is_nan(update_data.id));
         bool const topo_changed = set_status(update_data.status);
-        bool const u_ref_changed = set_u_ref(update_data.u_ref, update_data.u_ref_angle);
+        set_u_ref(update_data.u_ref, update_data.u_ref_angle);
         bool const param_changed_impedance =
             set_sk_rx_ratio_z01_ratio(update_data.sk, update_data.rx_ratio, update_data.z01_ratio);
         // change source connection will change both topo and param
-        // change u ref will change param
+        // change u ref will NOT change param
         // change sk/rx_ratio/z01_ratio will change param
-        return {.topo = topo_changed, .param = u_ref_changed || param_changed_impedance || topo_changed};
+        return {.topo = topo_changed, .param = param_changed_impedance || topo_changed};
     }
 
     SourceUpdate inverse(SourceUpdate update_data) const {

tests/cpp_unit_tests/test_source.cpp

@@ -191,7 +191,7 @@ TEST_CASE("Test source") {
     SUBCASE("test update") {
         auto changed = source.update(SourceUpdate{.id = 1, .status = 1, .u_ref = 1.05, .u_ref_angle = nan});
         CHECK(!changed.topo);
-        CHECK(changed.param);
+        CHECK(!changed.param);
         changed = source.update(SourceUpdate{.id = 1, .status = 0, .u_ref = 1.05, .u_ref_angle = nan});
         CHECK(changed.topo);
         CHECK(changed.param);
@@ -200,27 +200,47 @@ TEST_CASE("Test source") {
         CHECK(!changed.param);
 
         // test updating sk, rx_ratio, z01_ratio (status remains 0)
-        changed = source.update(SourceUpdate{
-            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = 20e6, .rx_ratio = nan, .z01_ratio = nan});
+        changed = source.update(SourceUpdate{.id = 1,
+                                             .status = na_IntS,
+                                             .u_ref = nan,
+                                             .u_ref_angle = nan,
+                                             .sk = 20e6,
+                                             .rx_ratio = nan,
+                                             .z01_ratio = nan});
         CHECK(!changed.topo);
         CHECK(changed.param);
 
         // verify the new impedance affects math_param
         DoubleComplex const y_ref_sym_updated = source.math_param<symmetric_t>().template y_ref<symmetric_t>();
         CHECK(cabs(y_ref_sym_updated - y_ref_sym) > numerical_tolerance); // should be different
 
-        changed = source.update(SourceUpdate{
-            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = 0.2, .z01_ratio = nan});
+        changed = source.update(SourceUpdate{.id = 1,
+                                             .status = na_IntS,
+                                             .u_ref = nan,
+                                             .u_ref_angle = nan,
+                                             .sk = nan,
+                                             .rx_ratio = 0.2,
+                                             .z01_ratio = nan});
         CHECK(!changed.topo);
         CHECK(changed.param);
 
-        changed = source.update(SourceUpdate{
-            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = nan, .z01_ratio = 4.0});
+        changed = source.update(SourceUpdate{.id = 1,
+                                             .status = na_IntS,
+                                             .u_ref = nan,
+                                             .u_ref_angle = nan,
+                                             .sk = nan,
+                                             .rx_ratio = nan,
+                                             .z01_ratio = 4.0});
         CHECK(!changed.topo);
         CHECK(changed.param);
 
-        changed = source.update(SourceUpdate{
-            .id = 1, .status = na_IntS, .u_ref = nan, .u_ref_angle = nan, .sk = nan, .rx_ratio = nan, .z01_ratio = nan});
+        changed = source.update(SourceUpdate{.id = 1,
+                                             .status = na_IntS,
+                                             .u_ref = nan,
+                                             .u_ref_angle = nan,
+                                             .sk = nan,
+                                             .rx_ratio = nan,
+                                             .z01_ratio = nan});
         CHECK(!changed.topo);
         CHECK(!changed.param);
     }