Merge pull request #1257 from PowerGridModel/feature/sonar-reliability

Sonar issues: fix reliability issues

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp

@@ -353,8 +353,9 @@ class Topology {
             return math_idx.pos;
         };
         // k as branch number for 2-way branch
-        for (auto const& [idx, branch_node_idx, branch_connected] :
-             std::views::zip(std::views::iota(0), comp_topo_.branch_node_idx, comp_conn_.branch_connected)) {
+        for (auto&& [idx, branch_node_idx, branch_connected] :
+             std::views::zip(std::views::iota(0), std::as_const(comp_topo_.branch_node_idx),
+                             std::as_const(comp_conn_.branch_connected))) {
             assert(std::ssize(branch_connected) == 2); // NOSONAR(R354)
 
             auto const [i, j] = branch_node_idx;
@@ -387,9 +388,10 @@ class Topology {
             comp_coup_.branch[idx] = Idx2D{.group = math_group, .pos = branch_pos};
         }
         // k as branch number for 3-way branch
-        for (auto const& [idx, i, i_status, j_math] :
-             std::views::zip(std::views::iota(0), comp_topo_.branch3_node_idx, comp_conn_.branch3_connected,
-                             std::views::drop(comp_coup_.node, comp_topo_.n_node))) {
+        for (auto&& [idx, i, i_status, j_math] :
+             std::views::zip(std::views::iota(0), std::as_const(comp_topo_.branch3_node_idx),
+                             std::as_const(comp_conn_.branch3_connected),
+                             std::views::drop(std::as_const(comp_coup_.node), std::as_const(comp_topo_.n_node)))) {
             std::array<Idx2D, 3> const i_math{
                 comp_coup_.node[i[0]],
                 comp_coup_.node[i[1]],