Skip to content

Commit 28cb249

Browse files
Reverted back to old implementation for #numericalColumnNames
1 parent 029fa0b commit 28cb249

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/DataFrame-Tests/DataFrameTest.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2833,7 +2833,7 @@ DataFrameTest >> testNumericalColumnNames [
28332833
#( Female 22 Spain 95 ) #( Male 24 Portugal 99 ) ).
28342834
dataFrame columnNames: #( Gender Age Country Score ).
28352835

2836-
expected := #( Age Score ).
2836+
expected := #( Age Score ) asOrderedCollection.
28372837

28382838
self assert: dataFrame numericalColumnNames equals: expected
28392839
]

src/DataFrame/DataFrame.class.st

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1431,7 +1431,8 @@ DataFrame >> numberOfRows [
14311431
DataFrame >> numericalColumnNames [
14321432
"Returns the names of all numerical columns of the dataframe"
14331433

1434-
^ self numericalColumns collect: [ :column | column name ]
1434+
^ self columnNames select: [ :columnName |
1435+
(self dataTypes at: columnName) includesBehavior: Number ]
14351436
]
14361437

14371438
{ #category : #accessing }

0 commit comments

Comments
 (0)