Skip to content

Commit ead8f79

Browse files
authored
Fix incorrect resources (#51)
1 parent 8a65c27 commit ead8f79

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

pokepy/resources_v2.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -421,15 +421,13 @@ class ItemHolderPokemonSubResource(BaseResource):
421421
class Meta(BaseResource.Meta):
422422
name = 'Item_Holder_Pokemon'
423423
identifier = 'pokemon'
424-
attributes = (
425-
'pokemon',
426-
)
427424
subresources = {
425+
'pokemon': NamedAPIResourceSubResource,
428426
'version_details': ItemHolderPokemonVersionDetailSubResource
429427
}
430428

431429
def __repr__(self):
432-
return '<%s - %s>' % (self.Meta.name, self.pokemon.capitalize())
430+
return '<%s>' % self.Meta.name
433431

434432

435433
class ContestComboDetailSubResource(BaseResource):
@@ -1424,7 +1422,7 @@ class Meta(BaseResource.Meta):
14241422
subresources = {
14251423
'fling_effect': NamedAPIResourceSubResource,
14261424
'attributes': NamedAPIResourceSubResource,
1427-
'category': ItemCategoryResource,
1425+
'category': NamedAPIResourceSubResource,
14281426
'effect_entries': VerboseEffectSubResource,
14291427
'flavor_text_entries': VersionGroupFlavorTextSubResource,
14301428
'game_indices': GenerationGameIndexSubResource,

requirements-dev27.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ mkdocs-material==3.2.* # docs
33
coverage==4.5.* # coverage
44
requests-mock==1.5.* # tests
55
tox==3.5.* # tests
6+
PyYAML==5.2 # mkdocs dependency (last version to support Python 3.4)

tests/test_pokepy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ def test_item_holder_pokemon_version_detail_subresource_repr(self):
10361036
base_subresource_repr_test(self, resources_v2.ItemHolderPokemonVersionDetailSubResource)
10371037

10381038
def test_item_holder_pokemon_subresource_repr(self):
1039-
base_subresource_repr_test(self, resources_v2.ItemHolderPokemonSubResource, pokemon='test')
1039+
base_subresource_repr_test(self, resources_v2.ItemHolderPokemonSubResource)
10401040

10411041
def test_contest_combo_detail_subresource_repr(self):
10421042
base_subresource_repr_test(self, resources_v2.ContestComboDetailSubResource)

0 commit comments

Comments
 (0)