it works but not ack

Author: Pixelbo

src/PelcoBus.cpp

@@ -15,7 +15,7 @@
 #include <SoftwareSerial.h>
 
 #include "Arduino.h"
-#include "constants.h"
+
 #include "PelcoBus.h"
 
 /*!
@@ -30,10 +30,6 @@
  *
  */
 
-PelcoBus::PelcoBus() {
-    return;
-}
-
 PelcoBus::PelcoBus(uint8_t txPin, uint8_t rxPin, uint8_t readEnPin) {
     txPin_ = txPin;
     rxPin_ = rxPin;
@@ -161,6 +157,10 @@ bool PelcoBus::command(uint8_t address, bool disableACK , uint8_t command, uint1
 
     (*SerialCamBus).write(messToCamera, sizeof(messToCamera)); // Write to the camera
 
+
+    ///////////////////////////////////
+
+    
     if ((!disableACK) && (!disableACK)) { // Check the response of the camera only if it isn't a request or the camera does not support return
         int timeout = 10000; // 10 millissecond wait
 

src/PelcoBus.h

@@ -56,23 +56,20 @@ class PelcoBus{
         int searchIndex(byte look_array[], byte value, size_t size);
         int searchIndexPROGMEM(const byte look_array[], byte value);
 
-
-    protected:
-        PelcoBus::PelcoBus();
-
         uint16_t txPin_;
         uint16_t rxPin_;
         uint16_t rePin_;
 
-        bool log_messages_;
-        char log_buffer[100];
-
-        bool command(uint8_t address, bool disableACK , uint8_t command, uint16_t data1 = 0x00, uint8_t data2 = 0x00);
-        uint16_t request(uint8_t address, uint8_t request, int timeout = 1000);
+        
+bool log_messages_;
+char log_buffer[100];
 
     public:
+
         PelcoBus(uint8_t txPin, uint8_t rxPin, uint8_t readEnPin = NOT_A_PIN);
-        
+
+        bool command(uint8_t address, bool disableACK , uint8_t command, uint16_t data1 = 0x00, uint8_t data2 = 0x00);
+        uint16_t request(uint8_t address, uint8_t request, int timeout = 1000);
 
         void begin(uint32_t config, bool log_messages = false);
 

src/PelcoCam.cpp

@@ -13,13 +13,15 @@
 #include <SoftwareSerial.h>
 
 #include "Arduino.h"
-#include "constants.h"
 
+#include "constants.h"
 #include "PelcoCam.h"
 
+
 // Only serves as a wrapper for the PelcoBus class
 
-PelcoCam::PelcoCam(uint8_t address, bool disable_ack): PelcoBus(PelcoBus::rxPin_, PelcoBus::txPin_, PelcoBus::rePin_){
+PelcoCam::PelcoCam(PelcoBus *bus,  uint8_t address, bool disable_ack = false){
+    bus_ = bus; //Get the address (pointer) of the PelcoBus class
     address_ = address;
     disable_ack_ = disable_ack;
 }
@@ -34,17 +36,12 @@ bool PelcoCam::available() { // Returns true if there's a ACK
         }
         return false;
     }
-        return PelcoBus::command(address_, disable_ack_, DUMMY);
+        return bus_->command(address_, disable_ack_, DUMMY);
 
 }
 
-bool PelcoCam::send_command(uint8_t command, uint16_t data1 = 0x00, uint8_t data2 = 0x00) {
-    Serial.print("ah");
-    Serial.print(log_buffer);
-    delay(1000);
-    Serial.println("bbbb");
-    bool test = PelcoBus::command(address_, disable_ack_, command, data1, data2);
-    return test;
+bool PelcoCam::send_command(uint8_t command=STOP, uint16_t data1 = 0x00, uint8_t data2 = 0x00) {
+    return bus_->command(address_, disable_ack_, command, data1, data2);
 }
 
 uint16_t PelcoCam::send_request(uint8_t request, uint16_t timeout = 1000) {
@@ -58,5 +55,5 @@ uint16_t PelcoCam::send_request(uint8_t request, uint16_t timeout = 1000) {
         return 0;
     }
 
-    return PelcoBus::request(address_, request, timeout);
+    return bus_->request(address_, request, timeout);
 }

src/PelcoCam.h

@@ -13,17 +13,22 @@
 #include <SoftwareSerial.h>
 
 #include "Arduino.h"
-#include "constants.h"
-
+ 
 #include "PelcoBus.h"
 
-class PelcoCam: public PelcoBus{
+
+class PelcoCam{
     private:
         uint8_t address_;
         bool disable_ack_;
+        PelcoBus *bus_;
+
+        bool log_messages_;
+        char log_buffer[100];
+
 
     public:
-        PelcoCam(uint8_t address, bool disable_ack = false);
+        PelcoCam(PelcoBus *bus,  uint8_t address, bool disable_ack = false);
 
         bool available();
 

src/Pelco_And_Arduino.h

@@ -24,5 +24,4 @@
 
 
 
-
 #endif