Optimize the generation of successors for old characters (#3033)

Author: IhateTrains

.github/workflows/ck3-tiger.conf

@@ -233,6 +233,15 @@ filter = {
                 text = "missing english localization key default value"
                 text = "subject contract flag meritocratic_province_protectorate not defined in common/subject_contracts/contracts/"
                 text = "subject contract flag celestial_province_celestial not defined in common/subject_contracts/contracts/"
+                text = "missing english localization key grand_marshal"
+                text = "missing english localization key hunt_every_attendee_tt"
+                text = "missing english localization key is_kampaku_tt"
+                text = "missing english localization key ceremonial_liege_appointment_support_desc"
+                text = "missing english localization key situation_parameter_era_type_chaotic"
+                text = "missing english localization key situation_parameter_era_type_unstable"
+                text = "missing english localization key situation_parameter_hide_in_phases_list"
+                text = "missing english localization key situation_parameter_era_type_stable"
+                text = "missing english localization key dynastic_cycle_situation_dynastic_cycle_phase_stability_situation_phase"
             }
         }
     }

ImperatorToCK3/CK3/Characters/CharacterCollection.cs

@@ -783,7 +783,7 @@ internal void GenerateSuccessorsForOldCharacters(Title.LandedTitles titles, Cult
 
 		var titleHolderIds = titles.GetHolderIdsForAllTitlesExceptNobleFamilyTitles(ck3BookmarkDate);
 		var oldTitleHolders = new List<Character>();
-		var oldCharactersWithoutTitles = new List<Character>();
+		var randomForCharactersWithoutTitles = new Random((int)randomSeed);
 		foreach (var character in this) {
 			if (character.BirthDate >= ck3BookmarkDate || character.DeathDate is not null || ck3BookmarkDate.DiffInYears(character.BirthDate) <= 60) {
 				continue;
@@ -792,33 +792,28 @@ internal void GenerateSuccessorsForOldCharacters(Title.LandedTitles titles, Cult
 			if (titleHolderIds.Contains(character.Id)) {
 				oldTitleHolders.Add(character);
 			} else {
-				oldCharactersWithoutTitles.Add(character);
+				// For characters that don't hold any titles, just set up a death date.
+				SetUpDeathDateForCharacterWithoutTitles(character, irSaveDate, randomForCharactersWithoutTitles);
 			}
 		}
 
-		// For characters that don't hold any titles, just set up a death date.
-		var randomForCharactersWithoutTitles = new Random((int)randomSeed);
-		foreach (var oldCharacter in oldCharactersWithoutTitles) {
-			SetUpDeathDateForCharacterWithoutTitles(oldCharacter, irSaveDate, randomForCharactersWithoutTitles);
+		if (oldTitleHolders.Count == 0) {
+			return;
 		}
 
-		var heldTitlesByHolderIdLists = new Dictionary<string, List<Title>>(StringComparer.Ordinal);
+		var titlesByHolderId = new Dictionary<string, List<Title>>(StringComparer.Ordinal);
 		foreach (var title in titles) {
 			var holderId = title.GetHolderId(ck3BookmarkDate);
 			if (holderId == "0") {
 				continue;
 			}
 
-			if (!heldTitlesByHolderIdLists.TryGetValue(holderId, out var heldTitles)) {
+			if (!titlesByHolderId.TryGetValue(holderId, out var heldTitles)) {
 				heldTitles = [];
-				heldTitlesByHolderIdLists[holderId] = heldTitles;
+				titlesByHolderId[holderId] = heldTitles;
 			}
 			heldTitles.Add(title);
 		}
-		var titlesByHolderId = new Dictionary<string, Title[]>(heldTitlesByHolderIdLists.Count, StringComparer.Ordinal);
-		foreach (var (holderId, heldTitles) in heldTitlesByHolderIdLists) {
-			titlesByHolderId[holderId] = [.. heldTitles];
-		}
 
 		var cultureIdToMaleNames = new Dictionary<string, string[]>(cultures.Count, StringComparer.Ordinal);
 		foreach (var culture in cultures) {
@@ -829,13 +824,18 @@ internal void GenerateSuccessorsForOldCharacters(Title.LandedTitles titles, Cult
 		Parallel.ForEach(oldTitleHolders, oldCharacter => GenerateSuccessorsForCharacter(oldCharacter, titlesByHolderId, cultureIdToMaleNames, irSaveDate, ck3BookmarkDate, randomSeed));
 	}
 
-	private void SetUpDeathDateForCharacterWithoutTitles(Character oldCharacter, Date irSaveDate, Random random) {
+	private static void SetUpDeathDateForCharacterWithoutTitles(Character oldCharacter, Date irSaveDate, Random random) {
 		// Roll a dice to determine how much longer the character will live.
 		var monthsToLive = random.Next(1, 30 * 12); // Can live up to 30 years more.
 
 		// If the character is female and pregnant, make sure she doesn't die before the pregnancy ends.
 		if (oldCharacter is {Female: true, ImperatorCharacter: not null}) {
-			var lastPregnancy = oldCharacter.Pregnancies.OrderBy(p => p.BirthDate).LastOrDefault();
+			Pregnancy? lastPregnancy = null;
+			foreach (var pregnancy in oldCharacter.Pregnancies) {
+				if (lastPregnancy is null || pregnancy.BirthDate > lastPregnancy.BirthDate) {
+					lastPregnancy = pregnancy;
+				}
+			}
 			if (lastPregnancy is not null) {
 				oldCharacter.DeathDate = lastPregnancy.BirthDate.ChangeByMonths(monthsToLive);
 				return;
@@ -845,8 +845,8 @@ private void SetUpDeathDateForCharacterWithoutTitles(Character oldCharacter, Dat
 		oldCharacter.DeathDate = irSaveDate.ChangeByMonths(monthsToLive);
 	}
 
-	private void GenerateSuccessorsForCharacter(Character oldCharacter, IReadOnlyDictionary<string, Title[]> titlesByHolderId,
-		IReadOnlyDictionary<string, string[]> cultureIdToMaleNames, Date irSaveDate, Date ck3BookmarkDate, ulong randomSeed)
+	private void GenerateSuccessorsForCharacter(Character oldCharacter, Dictionary<string, List<Title>> titlesByHolderId,
+		Dictionary<string, string[]> cultureIdToMaleNames, Date irSaveDate, Date ck3BookmarkDate, ulong randomSeed)
 	{
 		// Get all titles held by the character.
 		var heldTitles = titlesByHolderId[oldCharacter.Id];