Improve compilation performance

Author: scorteanucosmin

src/CSharpPluginLoader.cs

@@ -8,6 +8,7 @@
 using System.Linq;
 using System.Text.RegularExpressions;
 using Oxide.CSharp.Common;
+using Oxide.Pooling;
 
 namespace Oxide.Plugins
 {
@@ -241,14 +242,27 @@ public void CompilationRequested(CompilablePlugin plugin)
                 Compilation.Current.Add(plugin);
                 return;
             }
+
             if (_compilationQueue.Count < 1)
             {
                 Interface.Oxide.NextTick(() =>
                 {
-                    CompileAssembly(_compilationQueue.ToArray());
-                    _compilationQueue.Clear();
+                    List<CompilablePlugin> compilablePlugins = PoolFactory<List<CompilablePlugin>>.Shared.Take();
+                    try
+                    {
+                        compilablePlugins.AddRange(_compilationQueue);
+                        _compilationQueue.Clear();
+
+                        CompileAssembly(compilablePlugins);
+                    }
+                    finally
+                    {
+                        compilablePlugins.Clear();
+                        PoolFactory<List<CompilablePlugin>>.Shared.Return(compilablePlugins);
+                    }
                 });
             }
+
             _compilationQueue.Add(plugin);
         }
 
@@ -278,7 +292,7 @@ private void PluginLoadingCompleted(CompilablePlugin plugin)
             }
         }
 
-        private void CompileAssembly(CompilablePlugin[] plugins)
+        private void CompileAssembly(List<CompilablePlugin> plugins)
         {
             _compiler.Compile(plugins, compilation =>
             {
@@ -291,31 +305,41 @@ private void CompileAssembly(CompilablePlugin[] plugins)
                         GetPluginErrors(plugin.Name).Add($"Failed to compile:{Environment.NewLine}{errors}");
                         Interface.Oxide.LogError($"Error while compiling {plugin.ScriptName}:{Environment.NewLine}{errors}");
                     }
+
+                    return;
                 }
-                else
+
+                if (compilation.plugins.Count == 0)
                 {
-                    if (compilation.plugins.Count > 0)
-                    {
-                        string[] compiledNames = compilation.plugins.Where(pl => pl.CompilerErrors.Count == 0).Select(pl => pl.Name).ToArray();
-                        string verb = compiledNames.Length > 1 ? "were" : "was";
-                        Interface.Oxide.LogInfo($"{compiledNames.ToSentence()} {verb} compiled successfully in {Math.Round(compilation.duration * 1000f)}ms");
-                    }
+                    return;
+                }
 
+                List<string> compiledPlugins = PoolFactory<List<string>>.Shared.Take();
+                try
+                {
                     foreach (CompilablePlugin plugin in compilation.plugins)
                     {
-                        if (plugin.CompilerErrors.Count == 0)
-                        {
-                            Interface.Oxide.UnloadPlugin(plugin.Name);
-                            plugin.OnCompilationSucceeded(compilation.compiledAssembly);
-                        }
-                        else
+                        if (plugin.CompilerErrors.Count > 0)
                         {
                             plugin.OnCompilationFailed();
                             string errors = plugin.CompilerErrors.JoinValues(Environment.NewLine);
                             GetPluginErrors(plugin.Name).Add($"Failed to compile:{Environment.NewLine}{errors}");
                             Interface.Oxide.LogError($"Error while compiling {plugin.ScriptName}:{Environment.NewLine}{errors}");
+                            continue;
                         }
+
+                        Interface.Oxide.UnloadPlugin(plugin.Name);
+                        plugin.OnCompilationSucceeded(compilation.compiledAssembly);
+                        compiledPlugins.Add(plugin.Name);
                     }
+
+                    string verb = compiledPlugins.Count > 1 ? "were" : "was";
+                    Interface.Oxide.LogInfo($"{compiledPlugins.JoinValues(", ")} {verb} compiled successfully in {Math.Round(compilation.duration * 1000f)}ms");
+                }
+                finally
+                {
+                    compiledPlugins.Clear();
+                    PoolFactory<List<string>>.Shared.Return(compiledPlugins);
                 }
             });
         }

src/Compilation.cs

@@ -32,7 +32,7 @@ internal class Compilation
         private string includePath;
         private string[] extensionNames;
 
-        internal Compilation(int id, Action<Compilation> callback, CompilablePlugin[] plugins)
+        internal Compilation(int id, Action<Compilation> callback, List<CompilablePlugin> plugins)
         {
             this.id = id;
             this.callback = callback;

src/CompilerService.cs

@@ -339,7 +339,7 @@ private void OnMessageReceived(CompilerMessage message)
                         }
                     }
 
-                    CompilationResult compilationResult = Constants.Serializer.Deserialize<CompilationResult>(message.Data);
+                    CompilationResult? compilationResult = Constants.Serializer.Deserialize<CompilationResult>(message.Data);
                     if (compilationResult.Data == null || compilationResult.Data.Length == 0)
                     {
                         compilation.Completed();
@@ -522,11 +522,11 @@ private void ResetIdleTimer()
                 () => Stop(false, "idle shutdown"));
         }
 
-        internal void Compile(CompilablePlugin[] plugins, Action<Compilation> callback)
+        internal void Compile(List<CompilablePlugin> plugins, Action<Compilation> callback)
         {
             ResetIdleTimer();
             int id = _lastId++;
-            Compilation compilation = new Compilation(id, callback, plugins);
+            Compilation compilation = new(id, callback, plugins);
             _compilations[id] = compilation;
             compilation.Prepare(() => EnqueueCompilation(compilation));
         }