Moved relevant tests fro compliance-backend

Author: dLobatog

lib/openscap_parser.rb

@@ -40,10 +40,5 @@ def rule_results
 	rule_result_oscap
       end
     end
-    private
-
-    def test_result_node
-      @test_result_node ||= @report_xml.at_css('TestResult')
-    end
   end
 end

lib/openscap_parser/xml_report.rb

@@ -8,11 +8,11 @@ module XMLReport
     def self.included(base)
       base.class_eval do
         def host
-          @metadata&.dig('fqdn') || report_xml.search('target').text
+          @report_xml.search('target').text
         end
 
         def description
-          report_xml.search('description').first.text
+          @report_xml.search('description').first.text
         end
 
         def report_xml(report_contents = '')

openscap_parser.gemspec

@@ -40,4 +40,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "shoulda-context"
 end

test/concerns/xccdf_report/profiles_test.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class ProfilesTest < Minitest::Test
+  def test_result
+    OpenStruct.new(id: ['xccdf_org.ssgproject.content_profile_standard'])
+  end
+
+  def report_description
+    'description'
+  end
+
+  include OpenscapParser::Profiles
+  include OpenscapParser::XMLReport
+
+  def setup
+    report_xml(file_fixture('xccdf_report.xml').read)
+  end
+
+  test 'profiles' do
+    expected = {
+      'xccdf_org.ssgproject.content_profile_standard' => \
+      'Standard System Security Profile for Fedora'
+    }
+    assert_equal expected, profiles
+  end
+end

test/concerns/xccdf_report/xml_report_test.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class XMLReportTest < Minitest::Test
+  include OpenscapParser::XMLReport
+
+  def setup
+    report_xml(file_fixture('xccdf_report.xml').read)
+  end
+
+  test 'report_xml parses the XML report' do
+    assert_equal @report_xml.class, Nokogiri::XML::Document
+  end
+
+  test 'report_description' do
+    assert_match(/^This guide presents/, description)
+  end
+
+  test 'report_host' do
+    assert_match host, 'lenovolobato.lobatolan.home'
+  end
+end

test/fixtures/files/rhel-xccdf-report.xml

@@ -1,11 +1,57 @@
-require "test_helper"
+# frozen_string_literal: true
+
+require 'test_helper'
 
 class OpenscapParserTest < Minitest::Test
-  def test_that_it_has_a_version_number
-    refute_nil ::OpenscapParser::VERSION
+  def setup
+    fake_report = file_fixture('xccdf_report.xml').read
+    @profile = {
+      'xccdf_org.ssgproject.content_profile_standard' =>
+      'Standard System Security Profile for Fedora'
+    }
+    @report_parser = ::OpenscapParser::Base.new(fake_report)
   end
 
-  def test_it_does_something_useful
-    assert false
+  context 'profile' do
+    should 'be able to parse it' do
+      assert_equal(@profile, @report_parser.profiles)
+    end
+
+    should 'not save more than one profile when there are no test results' do
+      fake_report = file_fixture('rhel-xccdf-report.xml').read
+      @profile = {
+        'xccdf_org.ssgproject.content_profile_rht-ccp' =>
+        'Red Hat Corporate Profile for Certified Cloud Providers (RH CCP)'
+      }
+      @report_parser = ::OpenscapParser::Base.new(fake_report)
+      assert_equal 1, @report_parser.profiles.count
+    end
+  end
+
+  context 'host' do
+    should 'be able to parse host name' do
+      assert_equal 'lenovolobato.lobatolan.home', @report_parser.host
+    end
+  end
+
+  test 'score can be parsed' do
+    assert_equal(16.220238, @report_parser.score)
+  end
+
+  context 'rules' do
+    setup do
+      @arbitrary_rules = [
+        # rubocop:disable Metrics/LineLength
+        'xccdf_org.ssgproject.content_rule_dir_perms_world_writable_system_owned',
+        'xccdf_org.ssgproject.content_rule_bios_enable_execution_restrictions',
+        'xccdf_org.ssgproject.content_rule_gconf_gnome_screensaver_lock_enabled',
+        'xccdf_org.ssgproject.content_rule_selinux_all_devicefiles_labeled'
+        # rubocop:enable Metrics/LineLength
+      ]
+    end
+
+    should 'list all rules' do
+      assert_empty(@arbitrary_rules - @report_parser.rule_ids)
+    end
   end
 end

test/fixtures/files/xccdf_report.xml

@@ -2,3 +2,29 @@
 require "openscap_parser"
 
 require "minitest/autorun"
+require 'shoulda-context'
+
+def test(name, &block)
+  test_name = "test_#{name.gsub(/\s+/, '_')}".to_sym
+  defined = method_defined? test_name
+  raise "#{test_name} is already defined in #{self}" if defined
+  if block_given?
+    define_method(test_name, &block)
+  else
+    define_method(test_name) do
+      flunk "No implementation provided for #{name}"
+    end
+  end
+end
+
+def file_fixture(fixture_name)
+  file_fixture_path = './test/fixtures/files'
+  path = Pathname.new(File.join(file_fixture_path, fixture_name))
+
+  if path.exist?
+    path
+  else
+    msg = "the directory '%s' does not contain a file named '%s'"
+    raise ArgumentError, msg % [file_fixture_path, fixture_name]
+  end
+end