Fix CodeClimate problem

Use '[[' instead of '[' for conditional tests. The '[[' construct
is safer and more feature-rich.

Author: jan-cerny

tests/oscap_info_profiles/test_list_rules.sh

@@ -12,13 +12,13 @@ p1="xccdf_com.example.www_profile_P1"
 
 # Test 1: --list-rules with --profile prints selected rule IDs
 $OSCAP info --profile $p1 --list-rules $ds > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 grep -q "xccdf_com.example.www_rule_R1" $stdout
 grep -q "xccdf_com.example.www_rule_R2" $stdout
 grep -q "xccdf_com.example.www_rule_R3" $stdout
 grep -q "xccdf_com.example.www_rule_R4" $stdout
 # Verify output contains only rule IDs, one per line (4 rules = 4 lines)
-[ "$(wc -l < $stdout)" -eq 4 ]
+[[ "$(wc -l < $stdout)" -eq 4 ]]
 :> $stdout
 
 # Test 2: --list-rules without --profile produces an error
@@ -31,24 +31,24 @@ grep -q "\-\-list-rules option requires \-\-profile" $stderr
 tailoring="$srcdir/test_tailoring_file.xml"
 tp="xccdf_com.example.www_profile_P1_tailored"
 $OSCAP info --profile $tp --list-rules $tailoring > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 grep -q "xccdf_com.example.www_rule_R1" $stdout
 grep -q "xccdf_com.example.www_rule_R2" $stdout
 # R3 and R4 are deselected by tailoring
 ! grep -q "xccdf_com.example.www_rule_R3" $stdout
 ! grep -q "xccdf_com.example.www_rule_R4" $stdout
-[ "$(wc -l < $stdout)" -eq 2 ]
+[[ "$(wc -l < $stdout)" -eq 2 ]]
 :> $stdout
 
 # Test 4: --list-rules with SDS containing tailoring
 ds_tailoring="$srcdir/test_reference_ds_with_tailoring.xml"
 $OSCAP info --profile $tp --list-rules $ds_tailoring > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 grep -q "xccdf_com.example.www_rule_R1" $stdout
 grep -q "xccdf_com.example.www_rule_R2" $stdout
 ! grep -q "xccdf_com.example.www_rule_R3" $stdout
 ! grep -q "xccdf_com.example.www_rule_R4" $stdout
-[ "$(wc -l < $stdout)" -eq 2 ]
+[[ "$(wc -l < $stdout)" -eq 2 ]]
 :> $stdout
 
 rm -f $stdout $stderr

tests/oscap_info_profiles/test_list_vars.sh

@@ -12,11 +12,11 @@ p1="xccdf_com.example.www_profile_P1"
 
 # Test 1: --list-vars with --profile prints value IDs and resolved values
 $OSCAP info --profile $p1 --list-vars $ds > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 grep -q "xccdf_com.example.www_value_V1	42" $stdout
 grep -q "xccdf_com.example.www_value_V2	custom_val" $stdout
 # Verify output contains exactly 2 lines
-[ "$(wc -l < $stdout)" -eq 2 ]
+[[ "$(wc -l < $stdout)" -eq 2 ]]
 :> $stdout
 
 # Test 2: --list-vars without --profile produces an error
@@ -35,20 +35,20 @@ grep -q "The \-\-list-rules and \-\-list-vars options can't be used at the same
 tailoring="$srcdir/test_tailoring_file.xml"
 tp="xccdf_com.example.www_profile_P1_tailored"
 $OSCAP info --profile $tp --list-vars $tailoring > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 # V1 is overridden to 99 by tailoring, V2 is inherited from base profile
 grep -q "xccdf_com.example.www_value_V1	99" $stdout
 grep -q "xccdf_com.example.www_value_V2	custom_val" $stdout
-[ "$(wc -l < $stdout)" -eq 2 ]
+[[ "$(wc -l < $stdout)" -eq 2 ]]
 :> $stdout
 
 # Test 5: --list-vars with SDS containing tailoring
 ds_tailoring="$srcdir/test_reference_ds_with_tailoring.xml"
 $OSCAP info --profile $tp --list-vars $ds_tailoring > $stdout 2> $stderr
-[ -f $stderr ]; [ ! -s $stderr ]; :> $stderr
+[[ -f $stderr ]]; [[ ! -s $stderr ]]; :> $stderr
 grep -q "xccdf_com.example.www_value_V1	99" $stdout
 grep -q "xccdf_com.example.www_value_V2	custom_val" $stdout
-[ "$(wc -l < $stdout)" -eq 2 ]
+[[ "$(wc -l < $stdout)" -eq 2 ]]
 :> $stdout
 
 rm -f $stdout $stderr