test: remove duplicate and theatrical tests (#2559)

- Consolidate 4 separate SPAWN_PROMPT/SPAWN_MODE env var tests in
  cmdrun-happy-path.test.ts into 2 tests. Each previously spawned a
  separate bash subprocess to check a single env var; the consolidated
  tests check both vars in one subprocess invocation, halving overhead.

- Remove redundant KNOWN_FLAGS.has() assertions from steps-flag.test.ts.
  The findUnknownFlag() call already exercises the Set membership check —
  the extra .has() assertion was pure duplication. Also removes the now-
  unused KNOWN_FLAGS import.

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 3 people

packages/cli/src/__tests__/cmdrun-happy-path.test.ts

@@ -389,22 +389,14 @@ describe("cmdRun happy-path pipeline", () => {
   // ── Env var passing via runBash ───────────────────────────────────────────
 
   describe("SPAWN_PROMPT and SPAWN_MODE env var passing", () => {
-    it("should pass prompt to bash script via SPAWN_PROMPT env var", async () => {
-      // Use a script that echoes the env var so we can verify it was set
-      const echoScript = '#!/bin/bash\nset -eo pipefail\ntest "$SPAWN_PROMPT" = "Fix all bugs"';
-      global.fetch = mockFetchForDownload({
-        primaryOk: true,
-        scriptContent: echoScript,
-      });
-      await loadManifest(true);
-
-      // If SPAWN_PROMPT is set correctly, the test command succeeds (exit 0)
-      await cmdRun("claude", "sprite", "Fix all bugs");
-      expect(processExitSpy).not.toHaveBeenCalled();
-    });
-
-    it("should set SPAWN_MODE to non-interactive when prompt is provided", async () => {
-      const checkScript = '#!/bin/bash\nset -eo pipefail\ntest "$SPAWN_MODE" = "non-interactive"';
+    it("should set both SPAWN_PROMPT and SPAWN_MODE when prompt is provided", async () => {
+      // Single script checks both vars — avoids two separate bash invocations
+      const checkScript = [
+        "#!/bin/bash",
+        "set -eo pipefail",
+        'test "$SPAWN_PROMPT" = "Fix all bugs"',
+        'test "$SPAWN_MODE" = "non-interactive"',
+      ].join("\n");
       global.fetch = mockFetchForDownload({
         primaryOk: true,
         scriptContent: checkScript,
@@ -415,21 +407,14 @@ describe("cmdRun happy-path pipeline", () => {
       expect(processExitSpy).not.toHaveBeenCalled();
     });
 
-    it("should NOT set SPAWN_PROMPT when no prompt is provided", async () => {
-      // This script fails if SPAWN_PROMPT is set (non-empty)
-      const checkScript = '#!/bin/bash\nset -eo pipefail\ntest -z "${SPAWN_PROMPT:-}"';
-      global.fetch = mockFetchForDownload({
-        primaryOk: true,
-        scriptContent: checkScript,
-      });
-      await loadManifest(true);
-
-      await cmdRun("claude", "sprite");
-      expect(processExitSpy).not.toHaveBeenCalled();
-    });
-
-    it("should NOT set SPAWN_MODE when no prompt is provided", async () => {
-      const checkScript = '#!/bin/bash\nset -eo pipefail\ntest -z "${SPAWN_MODE:-}"';
+    it("should NOT set SPAWN_PROMPT or SPAWN_MODE when no prompt is provided", async () => {
+      // Single script verifies both vars are unset
+      const checkScript = [
+        "#!/bin/bash",
+        "set -eo pipefail",
+        'test -z "${SPAWN_PROMPT:-}"',
+        'test -z "${SPAWN_MODE:-}"',
+      ].join("\n");
       global.fetch = mockFetchForDownload({
         primaryOk: true,
         scriptContent: checkScript,

packages/cli/src/__tests__/steps-flag.test.ts

@@ -1,19 +1,14 @@
 import { describe, expect, it } from "bun:test";
-import { findUnknownFlag, KNOWN_FLAGS } from "../flags";
+import { findUnknownFlag } from "../flags";
 import { getAgentOptionalSteps, validateStepNames } from "../shared/agents";
 
 describe("--steps and --config flags", () => {
-  it("should recognize --steps as a known flag", () => {
-    expect(KNOWN_FLAGS.has("--steps")).toBe(true);
+  it("should recognize --steps and --config as known flags", () => {
     expect(
       findUnknownFlag([
         "--steps",
       ]),
     ).toBeNull();
-  });
-
-  it("should recognize --config as a known flag", () => {
-    expect(KNOWN_FLAGS.has("--config")).toBe(true);
     expect(
       findUnknownFlag([
         "--config",