bugfix: Fix a stack overflow when pasting large selection to a existing area

- This also improve the speed when pasting large selection to a existing area;
- This doesn't happen when the copy-on-write option is turned off, but it will affect all arrays so I keep it on;
- Move the code to check and extend the `selection_exists` array to separate functions.

Author: IoeCmcomc

Minecraft Note Block Studio.yyp

@@ -33,23 +33,23 @@ function add_block_select(argument0, argument1, argument2, argument3, argument4,
 
 	// Add block
 	song_exists[xx, yy] = 1
-	song_ins[xx, yy] = ins
-	song_key[xx, yy] = key
-	song_vel[xx, yy] = vel
-	song_pan[xx, yy] = pan
-	song_pit[xx, yy] = pit
-	song_played[xx, yy] = 0
-	song_added[xx, yy] = 0
-	colamount[xx] += 1
-	rowamount[yy] += 1
+	song_ins[@ xx, yy] = ins
+	song_key[@ xx, yy] = key
+	song_vel[@ xx, yy] = vel
+	song_pan[@ xx, yy] = pan
+	song_pit[@ xx, yy] = pit
+	song_played[@ xx, yy] = 0
+	song_added[@ xx, yy] = 0
+	colamount[@ xx] += 1
+	rowamount[@ yy] += 1
 	ins.num_blocks++
 	if (key < 33 || key > 57) block_outside += 1
 	if (ins.user) block_custom += 1
 	if (pit != 0) block_pitched += 1
 	totalblocks += 1
 
-	if (colfirst[xx] = -1 || yy < colfirst[xx]) colfirst[xx] = yy
-	if (yy > collast[xx]) collast[xx] = yy
+	if (colfirst[xx] = -1 || yy < colfirst[xx]) colfirst[@ xx] = yy
+	if (yy > collast[xx]) collast[@ xx] = yy
 
 	if (xx >= enda) enda = xx
 	if (yy >= endb) endb = yy

scripts/add_block_select/add_block_select.gml

@@ -41,25 +41,8 @@ function pattern_import() {
 		if check_custom_instrument(temp_str) = 0 {
 		//	show_debug_message("selection_code " + string(selection_copied))
 			selection_copied = temp_str
-			if (pat_length > selection_arraylength) { // New length
-			    for (a = selection_arraylength + 1; a <= pat_length; a += 1) {
-			        selection_colfirst[a] = -1
-			        selection_collast[a] = -1
-			        for (b = 0; b <= selection_arrayheight; b += 1) {
-			            selection_exists[a, b] = 0
-			        }
-			    }
-			    selection_arraylength = pat_length
-			}
-	
-			if (pat_height > selection_arrayheight) { // New height
-			    for (a = 0; a <= selection_arraylength; a += 1) {
-			        for (b = selection_arrayheight + 1; b <= pat_height; b += 1) {
-			            selection_exists[a, b] = 0
-			        }
-			    }
-			    selection_arrayheight = pat_height
-			}
+			selection_extend_length(pat_length)
+			selection_extend_height(pat_height)
 
 			for (a = 0; a < selection_l; a += 1) {
 				temp_colfirst[a] = buffer_read_byte_signed()

scripts/pattern_import/pattern_import.gml

@@ -5,21 +5,21 @@ function remove_block_select(argument0, argument1) {
 	yy = argument1
 
 	if (xx >= arraylength || yy >= arrayheight || song_exists[xx, yy] == 0) return 0
-	song_exists[xx, yy] = 0
+	song_exists[@ xx, yy] = 0
 	song_ins[xx, yy].num_blocks--
 	if (song_key[xx, yy] < 33 || song_key[xx, yy] > 57) block_outside -= 1
 	if (song_ins[xx, yy].user) block_custom -= 1
 	if (song_pit[xx, yy] != 0) block_pitched -= 1
 
-	song_ins[xx, yy] = 0
-	song_key[xx, yy] = 0
-	song_vel[xx, yy] = 0
-	song_pan[xx, yy] = 0
-	song_pit[xx, yy] = 0
-	song_played[xx, yy] = 0
-	song_added[xx, yy] = 0
-	colamount[xx] -= 1
-	rowamount[yy] -= 1
+	song_ins[@ xx, yy] = 0
+	song_key[@ xx, yy] = 0
+	song_vel[@ xx, yy] = 0
+	song_pan[@ xx, yy] = 0
+	song_pit[@ xx, yy] = 0
+	song_played[@ xx, yy] = 0
+	song_added[@ xx, yy] = 0
+	colamount[@ xx] -= 1
+	rowamount[@ yy] -= 1
 	totalblocks -= 1
 
 

scripts/remove_block_select/remove_block_select.gml

@@ -11,24 +11,10 @@ function select_all(argument0, argument1) {
 	if (totalblocks = 0) return 0
 	if (inst > -1 && !n && inst.num_blocks = 0)
 	    return 0
-	if (enda > selection_arraylength) { // New length
-	    for (a = selection_arraylength + 1; a <= enda; a += 1) {
-	        selection_colfirst[a] = -1
-	        selection_collast[a] = -1
-	        for (b = 0; b <= selection_arrayheight; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arraylength = enda
-	}
-	if (endb > selection_arrayheight) { // New height
-	    for (a = 0; a <= selection_arraylength; a += 1) {
-	        for (b = selection_arrayheight + 1; b <= endb; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arrayheight = endb
-	}
+
+	selection_extend_length()
+	selection_extend_height()
+	
 	for (a = 0; a <= enda; a += 1) {
 	    if (colamount[a] > 0) {
 	        for (b = colfirst[a]; b <= collast[a]; b += 1) {
@@ -55,6 +41,7 @@ function select_all(argument0, argument1) {
 	        }
 	    }
 	}
+
 	selection_x = 0
 	selection_y = 0
 	selection_l = enda + 1

scripts/select_all/select_all.gml

@@ -4,24 +4,8 @@ function select_custom() {
 	var a, b, str, ins, key, vel, pan, pit;
 	str = selection_code
 	if (selected > 0) selection_place(1)
-	if (enda > selection_arraylength) { // New length
-	    for (a = selection_arraylength + 1; a <= enda; a += 1) {
-	        selection_colfirst[a] = -1
-	        selection_collast[a] = -1
-	        for (b = 0; b <= selection_arrayheight; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arraylength = enda
-	}
-	if (endb > selection_arrayheight) { // New height
-	    for (a = 0 ;a <= selection_arraylength; a += 1) {
-	        for (b = selection_arrayheight + 1; b <= endb; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arrayheight = endb
-	}
+	selection_extend_length()
+	selection_extend_height()
 	for (a = 0; a <= enda; a += 1) {
 	    if (colamount[a] > 0) {
 	        for (b = colfirst[a]; b <= collast[a]; b += 1) {

scripts/select_custom/select_custom.gml

@@ -4,24 +4,8 @@ function select_outside(argument0, argument1) {
 	var a, b, str, ins, key, vel, pan, pit;
 	str = selection_code
 	if (selected > 0) selection_place(1)
-	if (enda > selection_arraylength) { // New length
-	    for (a = selection_arraylength + 1; a <= enda; a += 1) {
-	        selection_colfirst[a] = -1
-	        selection_collast[a] = -1
-	        for (b = 0; b <= selection_arrayheight; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arraylength = enda
-	}
-	if (endb > selection_arrayheight) { // New height
-	    for (a = 0; a <= selection_arraylength; a += 1) {
-	        for (b = selection_arrayheight + 1; b <= endb; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arrayheight = endb
-	}
+	selection_extend_length()
+	selection_extend_height()
 	for (a = 0; a <= enda; a += 1) {
 	    if (colamount[a] > 0) {
 	        for (b = colfirst[a]; b <= collast[a]; b += 1) {

scripts/select_outside/select_outside.gml

@@ -60,45 +60,13 @@ function selection_add() {
 	    selection_y = y1
 	    selection_l = al
 	    selection_h = ah
-	    if (al > selection_arraylength) { // New length
-	        for (a = selection_arraylength + 1; a <= al; a += 1) {
-	            selection_colfirst[a] = -1
-	            selection_collast[a] = -1
-	            for (b = 0; b <= selection_arrayheight; b += 1) {
-	                selection_exists[a, b] = 0
-	            }
-	        }
-	        selection_arraylength = al
-	    }
-	    if (ah > selection_arrayheight) { // New height
-	        for (a = 0; a <= selection_arraylength; a += 1) {
-	            for (b = selection_arrayheight + 1; b <= ah; b += 1) {
-	                selection_exists[a, b] = 0
-	            }
-	        }
-	        selection_arrayheight = ah
-	    }
+		selection_extend_length(al)
+		selection_extend_height(ah)
 	} else { // Add to existing
 	    al = selection_l + max(0, selection_x - x1) + max(0, x2 - (selection_x + selection_l))
 	    ah = selection_h + max(0, selection_y - y1) + max(0, y2 - (selection_y + selection_h))
-	    if (al > selection_arraylength) { // New length
-	        for (a = selection_arraylength + 1; a <= al; a += 1) {
-	            selection_colfirst[a] = -1
-	            selection_collast[a] = -1
-	            for (b = 0; b <= selection_arrayheight; b += 1) {
-	                selection_exists[a, b] = 0
-	            }
-	        }
-	        selection_arraylength = al
-	    }
-	    if (ah > selection_arrayheight) { // New height
-	        for (a = 0; a <= selection_arraylength; a += 1) {
-	            for (b = selection_arrayheight + 1; b <= ah; b += 1) {
-	                selection_exists[a, b] = 0
-	            }
-	        }
-	        selection_arrayheight = ah
-	    }
+	    selection_extend_length(al)
+		selection_extend_height(ah)
 	    if (x1 < selection_x || y1 < selection_y) { // Move blocks
 	        var temp_colfirst, temp_collast, temp_exists, temp_ins, temp_key, temp_vel, temp_pan, temp_pit, temp_played;
 	        for (a = 0; a < selection_l; a += 1) {

scripts/selection_add/selection_add.gml

@@ -4,16 +4,7 @@ function selection_expand() {
 	str = selection_code
 	if (selected = 0) return 0
 	nw = selection_l * 2
-	if (nw > selection_arraylength) { // New length
-	    for (a = selection_arraylength + 1; a <= nw; a += 1) {
-	        selection_colfirst[a] = -1
-	        selection_collast[a] = -1
-	        for (b = 0; b <= selection_arrayheight; b += 1) {
-	            selection_exists[a, b] = 0
-	        }
-	    }
-	    selection_arraylength = nw
-	}
+	selection_extend_length(nw)
 	for (a = 0; a < selection_l; a += 1) {
 	    if (selection_colfirst[a] > -1) {
 	        for (b = selection_colfirst[a]; b <= selection_collast[a]; b += 1) {

scripts/selection_expand/selection_expand.gml

@@ -0,0 +1,13 @@
+function selection_extend_height(new_height = undefined){
+	if (is_undefined(new_height)) {
+		new_height = endb
+	}
+	if (new_height > selection_arrayheight) { // New height
+	    for (var a = selection_arraylength; a >= 0; --a) {
+	        for (var b = new_height; b >= selection_arrayheight + 1; --b) {
+	            selection_exists[@ a, b] = 0
+	        }
+	    }
+	    selection_arrayheight = new_height
+	}
+}