Read int from fgetc for EOF comparison - fixes #365

piedar · piedar · commit a05075a1bda3 · 2014-02-08T20:48:45.000-05:00
Signed-off-by: Benn Snyder &lt;benn.snyder@gmail.com&gt;
diff --git a/fakenect/fakenect.c b/fakenect/fakenect.c
@@ -98,10 +98,8 @@ static char *one_line(FILE *fp)
 {
 	int pos = 0;
 	char *out = NULL;
-	char c;
-	while ((c = fgetc(fp))) {
-		if (c == '\n' || c == EOF)
-			break;
+	for (int c = fgetc(fp); !(c == '\n' || c == EOF); c = fgetc(fp))
+	{
 		out = realloc(out, pos + 1);
 		out[pos++] = c;
 	}

Original file line number	Diff line number	Diff line change
`@@ -98,10 +98,8 @@ static char one_line(FILE fp)`
`98`	`98`	`{`
`99`	`99`	`int pos = 0;`
`100`	`100`	`char *out = NULL;`
`101`		`- char c;`
`102`		`- while ((c = fgetc(fp))) {`
`103`		`- if (c == '\n' \|\| c == EOF)`
`104`		`- break;`
	`101`	`+ for (int c = fgetc(fp); !(c == '\n' \|\| c == EOF); c = fgetc(fp))`
	`102`	`+ {`
`105`	`103`	`out = realloc(out, pos + 1);`
`106`	`104`	`out[pos++] = c;`
`107`	`105`	`}`