Skip to content

Commit a664e0a

Browse files
committed
style: refine RepositoryCard UI and clean up imports
- Increase repository owner avatar size from 32.dp to 40.dp. - Add clipping and padding to the owner name section for better touch target and visual feedback. - Reduce vertical spacing between card elements (spacers adjusted from 16.dp/12.dp/24.dp to 8.dp/8.dp/12.dp). - Simplify repository name text display logic. - Replace wildcard resource imports with explicit imports and remove unused `Image` import.
1 parent d25dbdf commit a664e0a

1 file changed

Lines changed: 18 additions & 10 deletions

File tree

  • core/presentation/src/commonMain/kotlin/zed/rainxch/core/presentation/components

core/presentation/src/commonMain/kotlin/zed/rainxch/core/presentation/components/RepositoryCard.kt

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package zed.rainxch.core.presentation.components
22

3-
import androidx.compose.foundation.Image
43
import androidx.compose.foundation.clickable
54
import androidx.compose.foundation.layout.Arrangement
65
import androidx.compose.foundation.layout.Box
@@ -50,7 +49,13 @@ import zed.rainxch.core.presentation.theme.GithubStoreTheme
5049
import zed.rainxch.core.presentation.utils.formatReleasedAt
5150
import zed.rainxch.core.presentation.utils.hasWeekNotPassed
5251
import zed.rainxch.core.presentation.utils.toIcons
53-
import zed.rainxch.githubstore.core.presentation.res.*
52+
import zed.rainxch.githubstore.core.presentation.res.Res
53+
import zed.rainxch.githubstore.core.presentation.res.forked_repository
54+
import zed.rainxch.githubstore.core.presentation.res.home_view_details
55+
import zed.rainxch.githubstore.core.presentation.res.installed
56+
import zed.rainxch.githubstore.core.presentation.res.open_in_browser
57+
import zed.rainxch.githubstore.core.presentation.res.share_repository
58+
import zed.rainxch.githubstore.core.presentation.res.update_available
5459

5560
@OptIn(ExperimentalMaterial3ExpressiveApi::class, ExperimentalLayoutApi::class)
5661
@Composable
@@ -106,17 +111,20 @@ fun RepositoryCard(
106111
) {
107112
Row(
108113
modifier =
109-
Modifier.clickable(onClick = {
110-
onDeveloperClick(discoveryRepositoryUi.repository.owner.login)
111-
}),
114+
Modifier
115+
.clip(CircleShape)
116+
.clickable(onClick = {
117+
onDeveloperClick(discoveryRepositoryUi.repository.owner.login)
118+
})
119+
.padding(horizontal = 4.dp, vertical = 2.dp),
112120
verticalAlignment = Alignment.CenterVertically,
113121
horizontalArrangement = Arrangement.spacedBy(12.dp),
114122
) {
115123
GitHubStoreImage(
116124
imageModel = { discoveryRepositoryUi.repository.owner.avatarUrl },
117125
modifier =
118126
Modifier
119-
.size(32.dp)
127+
.size(40.dp)
120128
.clip(CircleShape),
121129
)
122130

@@ -131,7 +139,7 @@ fun RepositoryCard(
131139
}
132140

133141
Text(
134-
text = "/ ${discoveryRepositoryUi.repository.name}",
142+
text = "/",
135143
style = MaterialTheme.typography.titleMedium,
136144
color = MaterialTheme.colorScheme.outline,
137145
softWrap = false,
@@ -176,7 +184,7 @@ fun RepositoryCard(
176184
)
177185
}
178186

179-
Spacer(Modifier.height(16.dp))
187+
Spacer(Modifier.height(8.dp))
180188

181189
Row(
182190
modifier = Modifier.fillMaxWidth(),
@@ -234,7 +242,7 @@ fun RepositoryCard(
234242
}
235243
}
236244

237-
Spacer(Modifier.height(12.dp))
245+
Spacer(Modifier.height(8.dp))
238246

239247
val releasedAtText =
240248
buildAnnotatedString {
@@ -254,7 +262,7 @@ fun RepositoryCard(
254262
overflow = TextOverflow.Ellipsis,
255263
)
256264

257-
Spacer(Modifier.height(24.dp))
265+
Spacer(Modifier.height(12.dp))
258266

259267
Row(
260268
modifier = Modifier.fillMaxWidth(),

0 commit comments

Comments
 (0)