Skip to content

Commit a30b78a

Browse files
rainxchzedrainxchzed
committed
refactor(i18n): Clean up and improve developer profile strings
This commit introduces several improvements and cleanups to the string resources and related code for the developer profile feature. - Removes the unused `remove_from_favorites` and `add_to_favorites` string resources from all localization files. - Adds spacing to the relative time format strings (`time_..._ago`) across all languages for better readability (e.g., "1d ago" becomes "1 d ago"). - Improves error handling in `formatRelativeDate` to prevent crashes from invalid date strings by wrapping the `Instant.parse` call in a try-catch block. - Simplifies the error message display in `DeveloperProfileRoot` by removing a redundant `Text` composable. - Updates content descriptions for the favorite icon in `DeveloperRepoItem` to use more appropriate existing strings.
1 parent 576715c commit a30b78a

12 files changed

Lines changed: 56 additions & 101 deletions

File tree

‎composeApp/src/commonMain/composeResources/values-bn/strings-bn.xml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -311,10 +311,6 @@
311311
<string name="updated_x_ago">%1$s আপডেট করা হয়েছে</string>
312312
<string name="has_release">রিলিজ আছে</string>
313313

314-
<!-- Developer Profile - Actions -->
315-
<string name="remove_from_favorites">পছন্দের তালিকা থেকে সরান</string>
316-
<string name="add_to_favorites">পছন্দের তালিকায় যোগ করুন</string>
317-
318314
<!-- Developer Profile - Relative Time -->
319315
<string name="time_years_ago">%1$d বছর আগে</string>
320316
<string name="time_months_ago">%1$d মাস আগে</string>

‎composeApp/src/commonMain/composeResources/values-es/strings-es.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,16 +258,12 @@
258258
<string name="updated_x_ago">Actualizado hace %1$s</string>
259259
<string name="has_release">Tiene lanzamiento</string>
260260

261-
<!-- Developer Profile - Actions -->
262-
<string name="remove_from_favorites">Quitar de favoritos</string>
263-
<string name="add_to_favorites">Añadir a favoritos</string>
264-
265261
<!-- Developer Profile - Relative Time -->
266-
<string name="time_years_ago">hace %1$da</string>
267-
<string name="time_months_ago">hace %1$dm</string>
268-
<string name="time_days_ago">hace %1$dd</string>
269-
<string name="time_hours_ago">hace %1$dh</string>
270-
<string name="time_minutes_ago">hace %1$dmin</string>
262+
<string name="time_years_ago">hace %1$d a</string>
263+
<string name="time_months_ago">hace %1$d m</string>
264+
<string name="time_days_ago">hace %1$d d</string>
265+
<string name="time_hours_ago">hace %1$d h</string>
266+
<string name="time_minutes_ago">hace %1$d min</string>
271267

272268
<!-- Developer Profile - Count Formatting -->
273269
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-fr/strings-fr.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,16 +258,12 @@
258258
<string name="updated_x_ago">Mis à jour il y a %1$s</string>
259259
<string name="has_release">A une version</string>
260260

261-
<!-- Developer Profile - Actions -->
262-
<string name="remove_from_favorites">Retirer des favoris</string>
263-
<string name="add_to_favorites">Ajouter aux favoris</string>
264-
265261
<!-- Developer Profile - Relative Time -->
266-
<string name="time_years_ago">il y a %1$da</string>
267-
<string name="time_months_ago">il y a %1$dmois</string>
268-
<string name="time_days_ago">il y a %1$dj</string>
269-
<string name="time_hours_ago">il y a %1$dh</string>
270-
<string name="time_minutes_ago">il y a %1$dmin</string>
262+
<string name="time_years_ago">il y a %1$d a</string>
263+
<string name="time_months_ago">il y a %1$d mois</string>
264+
<string name="time_days_ago">il y a %1$d j</string>
265+
<string name="time_hours_ago">il y a %1$d h</string>
266+
<string name="time_minutes_ago">il y a %1$d min</string>
271267

272268
<!-- Developer Profile - Count Formatting -->
273269
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-it/strings-it.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -307,16 +307,12 @@
307307
<string name="updated_x_ago">Aggiornato %1$s fa</string>
308308
<string name="has_release">Ha una release</string>
309309

310-
<!-- Developer Profile - Actions -->
311-
<string name="remove_from_favorites">Rimuovi dai preferiti</string>
312-
<string name="add_to_favorites">Aggiungi ai preferiti</string>
313-
314310
<!-- Developer Profile - Relative Time -->
315-
<string name="time_years_ago">%1$da fa</string>
316-
<string name="time_months_ago">%1$dmesi fa</string>
317-
<string name="time_days_ago">%1$dg fa</string>
318-
<string name="time_hours_ago">%1$dh fa</string>
319-
<string name="time_minutes_ago">%1$dmin fa</string>
311+
<string name="time_years_ago">%1$d a fa</string>
312+
<string name="time_months_ago">%1$d mesi fa</string>
313+
<string name="time_days_ago">%1$d g fa</string>
314+
<string name="time_hours_ago">%1$d h fa</string>
315+
<string name="time_minutes_ago">%1$d min fa</string>
320316

321317
<!-- Developer Profile - Count Formatting -->
322318
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-ja/strings-ja.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,16 +258,12 @@
258258
<string name="updated_x_ago">%1$s前に更新</string>
259259
<string name="has_release">リリースあり</string>
260260

261-
<!-- Developer Profile - Actions -->
262-
<string name="remove_from_favorites">お気に入りから削除</string>
263-
<string name="add_to_favorites">お気に入りに追加</string>
264-
265261
<!-- Developer Profile - Relative Time -->
266-
<string name="time_years_ago">%1$d年前</string>
267-
<string name="time_months_ago">%1$dヶ月前</string>
268-
<string name="time_days_ago">%1$d日前</string>
269-
<string name="time_hours_ago">%1$d時間前</string>
270-
<string name="time_minutes_ago">%1$d分前</string>
262+
<string name="time_years_ago">%1$d 年前</string>
263+
<string name="time_months_ago">%1$d ヶ月前</string>
264+
<string name="time_days_ago">%1$d 日前</string>
265+
<string name="time_hours_ago">%1$d 時間前</string>
266+
<string name="time_minutes_ago">%1$d 分前</string>
271267

272268
<!-- Developer Profile - Count Formatting -->
273269
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-kr/strings-kr.xml‎

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -309,17 +309,12 @@
309309
<string name="updated_x_ago">%1$s 전 업데이트됨</string>
310310
<string name="has_release">릴리스 있음</string>
311311

312-
<!-- Developer Profile - Actions -->
313-
<string name="remove_from_favorites">즐겨찾기에서 제거</string>
314-
<string name="add_to_favorites">즐겨찾기에 추가</string>
315-
316-
317312
<!-- Developer Profile - Relative Time -->
318-
<string name="time_years_ago">%1$d년 전</string>
319-
<string name="time_months_ago">%1$d개월 전</string>
320-
<string name="time_days_ago">%1$d일 전</string>
321-
<string name="time_hours_ago">%1$d시간 전</string>
322-
<string name="time_minutes_ago">%1$d분 전</string>
313+
<string name="time_years_ago">%1$d 년 전</string>
314+
<string name="time_months_ago">%1$d 개월 전</string>
315+
<string name="time_days_ago">%1$d 일 전</string>
316+
<string name="time_hours_ago">%1$d 시간 전</string>
317+
<string name="time_minutes_ago">%1$d 분 전</string>
323318

324319
<!-- Developer Profile - Count Formatting -->
325320
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-pl/strings-pl.xml‎

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -275,17 +275,12 @@
275275
<string name="updated_x_ago">Zaktualizowano %1$s temu</string>
276276
<string name="has_release">Ma wydanie</string>
277277

278-
<!-- Developer Profile - Actions -->
279-
<string name="remove_from_favorites">Usuń z ulubionych</string>
280-
<string name="add_to_favorites">Dodaj do ulubionych</string>
281-
282-
283278
<!-- Developer Profile - Relative Time -->
284-
<string name="time_years_ago">%1$dl temu</string>
285-
<string name="time_months_ago">%1$dmies temu</string>
286-
<string name="time_days_ago">%1$ddn temu</string>
287-
<string name="time_hours_ago">%1$dh temu</string>
288-
<string name="time_minutes_ago">%1$dmin temu</string>
279+
<string name="time_years_ago">%1$d l temu</string>
280+
<string name="time_months_ago">%1$d mies temu</string>
281+
<string name="time_days_ago">%1$d dn temu</string>
282+
<string name="time_hours_ago">%1$d h temu</string>
283+
<string name="time_minutes_ago">%1$d min temu</string>
289284

290285
<!-- Developer Profile - Count Formatting -->
291286
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-ru/strings-ru.xml‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -273,19 +273,15 @@
273273
<string name="no_favorite_repos">Нет избранных репозиториев</string>
274274

275275
<!-- Developer Profile - Repository Item -->
276-
<string name="updated_x_ago">Обновлено %1$s назад</string>
276+
<string name="updated_x_ago">Обновлено %1$s</string>
277277
<string name="has_release">Есть релиз</string>
278278

279-
<!-- Developer Profile - Actions -->
280-
<string name="remove_from_favorites">Удалить из избранного</string>
281-
<string name="add_to_favorites">Добавить в избранное</string>
282-
283279
<!-- Developer Profile - Relative Time -->
284-
<string name="time_years_ago">%1$dг назад</string>
285-
<string name="time_months_ago">%1$dмес назад</string>
286-
<string name="time_days_ago">%1$dд назад</string>
287-
<string name="time_hours_ago">%1$dч назад</string>
288-
<string name="time_minutes_ago">%1$dмин назад</string>
280+
<string name="time_years_ago">%1$d г</string>
281+
<string name="time_months_ago">%1$d мес</string>
282+
<string name="time_days_ago">%1$d д</string>
283+
<string name="time_hours_ago">%1$d ч</string>
284+
<string name="time_minutes_ago">%1$d мин</string>
289285

290286
<!-- Developer Profile - Count Formatting -->
291287
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values-zh-rCN/strings-zh-rCN.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -259,16 +259,12 @@
259259
<string name="updated_x_ago">%1$s前更新</string>
260260
<string name="has_release">有发布版</string>
261261

262-
<!-- Developer Profile - Actions -->
263-
<string name="remove_from_favorites">从收藏中移除</string>
264-
<string name="add_to_favorites">添加到收藏</string>
265-
266262
<!-- Developer Profile - Relative Time -->
267-
<string name="time_years_ago">%1$d年前</string>
268-
<string name="time_months_ago">%1$d个月前</string>
269-
<string name="time_days_ago">%1$d天前</string>
270-
<string name="time_hours_ago">%1$d小时前</string>
271-
<string name="time_minutes_ago">%1$d分钟前</string>
263+
<string name="time_years_ago">%1$d 年前</string>
264+
<string name="time_months_ago">%1$d 个月前</string>
265+
<string name="time_days_ago">%1$d 天前</string>
266+
<string name="time_hours_ago">%1$d 小时前</string>
267+
<string name="time_minutes_ago">%1$d 分钟前</string>
272268

273269
<!-- Developer Profile - Count Formatting -->
274270
<string name="count_millions">%1$dM</string>

‎composeApp/src/commonMain/composeResources/values/strings.xml‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -313,15 +313,11 @@
313313
<string name="updated_x_ago">Updated %1$s</string>
314314
<string name="has_release">Has Release</string>
315315

316-
<!-- Developer Profile - Actions -->
317-
<string name="remove_from_favorites">Remove from favorites</string>
318-
<string name="add_to_favorites">Add to favorites</string>
319-
320-
<string name="time_years_ago">%1$dy ago</string>
321-
<string name="time_months_ago">%1$dmo ago</string>
322-
<string name="time_days_ago">%1$dd ago</string>
323-
<string name="time_hours_ago">%1$dh ago</string>
324-
<string name="time_minutes_ago">%1$dm ago</string>
316+
<string name="time_years_ago">%1$d y ago</string>
317+
<string name="time_months_ago">%1$d mo ago</string>
318+
<string name="time_days_ago">%1$d d ago</string>
319+
<string name="time_hours_ago">%1$d h ago</string>
320+
<string name="time_minutes_ago">%1$d m ago</string>
325321

326322
<!-- Developer Profile - Count Formatting -->
327323
<string name="count_millions">%1$dM</string>

0 commit comments

Comments
 (0)