feat(details): implement repository sharing and refactor utility packages

rainxchzed · rainxchzed · commit 4bfecde86f81 · 2026-02-28T17:46:32.000+05:00
This commit introduces a sharing feature to the repository details screen, allowing users to share app links. It also cleans up the codebase by removing the experimental `trackExistingApp` logic and reorganizing desktop utility classes.

- **feat(details)**: Added `OnShareClick` action and integrated `ShareManager` to generate and share repository links.
- **feat(core)**: Introduced `ShareManager` interface in the domain layer with platform-specific implementations: `AndroidShareManager` (using `Intent.ACTION_SEND`) and `DesktopShareManager` (copying to clipboard).
- **refactor(details)**: Removed the unused and complex `trackExistingApp` method and `TrackExistingApp` action from `DetailsViewModel`.
- **refactor(core)**: Moved desktop utility classes (`DesktopAppLauncher`, `DesktopBrowserHelper`, `DesktopClipboardHelper`) from `services` to the `utils` package for consistency across platforms.
- **ui(details)**: Added a share icon button to the top app bar in `DetailsRoot`.
- **chore**: Updated DI modules for Android and JVM to include the new `ShareManager` and reflect package moves.
diff --git a/core/data/src/androidMain/kotlin/zed/rainxch/core/data/di/PlatformModule.android.kt b/core/data/src/androidMain/kotlin/zed/rainxch/core/data/di/PlatformModule.android.kt
@@ -19,11 +19,13 @@ import zed.rainxch.core.data.services.LocalizationManager
 import zed.rainxch.core.data.utils.AndroidAppLauncher
 import zed.rainxch.core.data.utils.AndroidBrowserHelper
 import zed.rainxch.core.data.utils.AndroidClipboardHelper
+import zed.rainxch.core.data.utils.AndroidShareManager
 import zed.rainxch.core.domain.network.Downloader
 import zed.rainxch.core.domain.system.PackageMonitor
 import zed.rainxch.core.domain.utils.AppLauncher
 import zed.rainxch.core.domain.utils.BrowserHelper
 import zed.rainxch.core.domain.utils.ClipboardHelper
+import zed.rainxch.core.domain.utils.ShareManager
 
 actual val corePlatformModule = module {
     // Core
@@ -82,4 +84,10 @@ actual val corePlatformModule = module {
         )
     }
 
+    single<ShareManager> {
+        AndroidShareManager(
+            context = androidContext()
+        )
+    }
+
 }
diff --git a/core/data/src/androidMain/kotlin/zed/rainxch/core/data/utils/AndroidShareManager.kt b/core/data/src/androidMain/kotlin/zed/rainxch/core/data/utils/AndroidShareManager.kt
@@ -0,0 +1,23 @@
+package zed.rainxch.core.data.utils
+
+import android.content.Context
+import android.content.Intent
+import zed.rainxch.core.domain.utils.ShareManager
+
+class AndroidShareManager (
+    private val context: Context,
+) : ShareManager {
+    override fun shareText(text: String) {
+        val intent = Intent(Intent.ACTION_SEND).apply {
+            type = "text/plain"
+            putExtra(Intent.EXTRA_TEXT, text)
+        }
+
+        val chooser = Intent.createChooser(intent, null).apply {
+            addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+        }
+
+        context.startActivity(chooser)
+    }
+
+}
diff --git a/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/di/PlatformModule.jvm.kt b/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/di/PlatformModule.jvm.kt
@@ -7,9 +7,9 @@ import zed.rainxch.core.data.local.data_store.createDataStore
 import zed.rainxch.core.data.local.db.AppDatabase
 import zed.rainxch.core.data.local.db.initDatabase
 import zed.rainxch.core.data.services.DesktopInstallerInfoExtractor
-import zed.rainxch.core.data.services.DesktopAppLauncher
-import zed.rainxch.core.data.services.DesktopBrowserHelper
-import zed.rainxch.core.data.services.DesktopClipboardHelper
+import zed.rainxch.core.data.utils.DesktopAppLauncher
+import zed.rainxch.core.data.utils.DesktopBrowserHelper
+import zed.rainxch.core.data.utils.DesktopClipboardHelper
 import zed.rainxch.core.data.services.DesktopDownloader
 import zed.rainxch.core.data.services.DesktopFileLocationsProvider
 import zed.rainxch.core.data.services.DesktopInstaller
@@ -18,11 +18,13 @@ import zed.rainxch.core.data.services.DesktopPackageMonitor
 import zed.rainxch.core.data.services.FileLocationsProvider
 import zed.rainxch.core.domain.system.Installer
 import zed.rainxch.core.data.services.LocalizationManager
+import zed.rainxch.core.data.utils.DesktopShareManager
 import zed.rainxch.core.domain.network.Downloader
 import zed.rainxch.core.domain.system.PackageMonitor
 import zed.rainxch.core.domain.utils.AppLauncher
 import zed.rainxch.core.domain.utils.BrowserHelper
 import zed.rainxch.core.domain.utils.ClipboardHelper
+import zed.rainxch.core.domain.utils.ShareManager
 
 actual val corePlatformModule = module {
     // Core
@@ -81,4 +83,8 @@ actual val corePlatformModule = module {
             platform = get()
         )
     }
+
+    single<ShareManager> {
+        DesktopShareManager()
+    }
 }
diff --git a/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopAppLauncher.kt b/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopAppLauncher.kt
@@ -1,4 +1,4 @@
-package zed.rainxch.core.data.services
+package zed.rainxch.core.data.utils
 
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
diff --git a/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopBrowserHelper.kt b/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopBrowserHelper.kt
@@ -1,4 +1,4 @@
-package zed.rainxch.core.data.services
+package zed.rainxch.core.data.utils
 
 import zed.rainxch.core.domain.utils.BrowserHelper
 import java.awt.Desktop
diff --git a/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopClipboardHelper.kt b/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopClipboardHelper.kt
@@ -1,4 +1,4 @@
-package zed.rainxch.core.data.services
+package zed.rainxch.core.data.utils
 
 import zed.rainxch.core.domain.utils.ClipboardHelper
 import java.awt.Toolkit
diff --git a/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopShareManager.kt b/core/data/src/jvmMain/kotlin/zed/rainxch/core/data/utils/DesktopShareManager.kt
@@ -0,0 +1,13 @@
+package zed.rainxch.core.data.utils
+
+import zed.rainxch.core.domain.utils.ShareManager
+import java.awt.Toolkit
+import java.awt.datatransfer.StringSelection
+
+class DesktopShareManager : ShareManager {
+    override fun shareText(text: String) {
+        val clipboard = Toolkit.getDefaultToolkit().systemClipboard
+        val selection = StringSelection(text)
+        clipboard.setContents(selection, null)
+    }
+}
diff --git a/core/domain/src/commonMain/kotlin/zed/rainxch/core/domain/utils/ShareManager.kt b/core/domain/src/commonMain/kotlin/zed/rainxch/core/domain/utils/ShareManager.kt
@@ -0,0 +1,5 @@
+package zed.rainxch.core.domain.utils
+
+interface ShareManager {
+    fun shareText(text: String)
+}
diff --git a/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsAction.kt b/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsAction.kt
@@ -24,12 +24,10 @@ sealed interface DetailsAction {
     data object OpenInAppManager : DetailsAction
     data object OnToggleInstallDropdown : DetailsAction
 
-    data object TrackExistingApp : DetailsAction
-
     data object OnNavigateBackClick : DetailsAction
 
     data object OnToggleFavorite : DetailsAction
-    data object CheckForUpdates : DetailsAction
+    data object OnShareClick : DetailsAction
     data object UpdateApp : DetailsAction
     data object OpenApp : DetailsAction
 
diff --git a/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsRoot.kt b/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsRoot.kt
@@ -19,6 +19,7 @@ import androidx.compose.material.icons.automirrored.filled.ArrowBack
 import androidx.compose.material.icons.filled.Favorite
 import androidx.compose.material.icons.filled.FavoriteBorder
 import androidx.compose.material.icons.filled.OpenInBrowser
+import androidx.compose.material.icons.filled.Share
 import androidx.compose.material.icons.filled.Star
 import androidx.compose.material.icons.filled.StarBorder
 import androidx.compose.material3.AlertDialog
@@ -334,9 +335,7 @@ private fun DetailsTopbar(
                             ),
                         )
                     }
-                }
 
-                if (state.repository != null) {
                     IconButton(
                         onClick = {
                             onAction(DetailsAction.OnToggleFavorite)
@@ -359,6 +358,21 @@ private fun DetailsTopbar(
                             ),
                         )
                     }
+
+                    IconButton(
+                        onClick = {
+                            onAction(DetailsAction.OnShareClick)
+                        },
+                        shapes = IconButtonDefaults.shapes(),
+                        colors = IconButtonDefaults.iconButtonColors(
+                            contentColor = MaterialTheme.colorScheme.onSurface
+                        )
+                    ) {
+                        Icon(
+                            imageVector = Icons.Default.Share,
+                            contentDescription = null,
+                        )
+                    }
                 }
 
                 state.repository?.htmlUrl?.let {
diff --git a/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsViewModel.kt b/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsViewModel.kt
@@ -37,6 +37,7 @@ import zed.rainxch.core.domain.system.Installer
 import zed.rainxch.core.domain.system.PackageMonitor
 import zed.rainxch.core.domain.use_cases.SyncInstalledAppsUseCase
 import zed.rainxch.core.domain.utils.BrowserHelper
+import zed.rainxch.core.domain.utils.ShareManager
 import zed.rainxch.details.domain.model.ReleaseCategory
 import zed.rainxch.details.domain.repository.DetailsRepository
 import zed.rainxch.details.presentation.model.DownloadStage
@@ -55,6 +56,7 @@ class DetailsViewModel(
     private val installer: Installer,
     private val platform: Platform,
     private val helper: BrowserHelper,
+    private val shareManager: ShareManager,
     private val installedAppsRepository: InstalledAppsRepository,
     private val favouritesRepository: FavouritesRepository,
     private val starredRepository: StarredRepository,
@@ -302,111 +304,6 @@ class DetailsViewModel(
         }
     }
 
-    @OptIn(ExperimentalTime::class)
-    private fun trackExistingApp() {
-        viewModelScope.launch {
-            try {
-                val repo = _state.value.repository ?: return@launch
-                val release = _state.value.selectedRelease
-                val primaryAsset = _state.value.primaryAsset
-
-                if (platform != Platform.ANDROID) return@launch
-
-                _state.update { it.copy(isTrackingApp = true) }
-
-                // Try to find the package name from the primary asset's APK info
-                // We need to check if any app matching this repo is installed
-                val allPackages = packageMonitor.getAllInstalledPackageNames()
-
-                // Try to extract package name from the APK asset name pattern
-                // Common patterns: com.example.app, app-release.apk, etc.
-                val possiblePackageName = "app.github.${repo.owner.login}.${repo.name}".lowercase()
-
-                // Check if already tracked
-                val existingTracked = installedAppsRepository.getAppByRepoId(repo.id)
-                if (existingTracked != null) {
-                    _events.send(DetailsEvent.OnMessage(getString(Res.string.already_tracked)))
-                    _state.update { it.copy(isTrackingApp = false) }
-                    return@launch
-                }
-
-                val systemInfo = packageMonitor.getInstalledPackageInfo(possiblePackageName)
-
-                val packageName: String
-                val versionName: String
-                val versionCode: Long
-                val appName: String
-
-                if (systemInfo != null && systemInfo.isInstalled) {
-                    packageName = possiblePackageName
-                    versionName = systemInfo.versionName
-                    versionCode = systemInfo.versionCode
-                    appName = repo.name
-                } else {
-                    // Can't detect package on system — still track with release tag info
-                    packageName = possiblePackageName
-                    versionName = release?.tagName ?: "unknown"
-                    versionCode = 0L
-                    appName = repo.name
-                }
-
-                val releaseTag = release?.tagName ?: versionName
-
-                val installedApp = InstalledApp(
-                    packageName = packageName,
-                    repoId = repo.id,
-                    repoName = repo.name,
-                    repoOwner = repo.owner.login,
-                    repoOwnerAvatarUrl = repo.owner.avatarUrl,
-                    repoDescription = repo.description,
-                    primaryLanguage = repo.language,
-                    repoUrl = repo.htmlUrl,
-                    installedVersion = releaseTag,
-                    installedAssetName = primaryAsset?.name,
-                    installedAssetUrl = primaryAsset?.downloadUrl,
-                    latestVersion = releaseTag,
-                    latestAssetName = primaryAsset?.name,
-                    latestAssetUrl = primaryAsset?.downloadUrl,
-                    latestAssetSize = primaryAsset?.size,
-                    appName = appName,
-                    installSource = InstallSource.MANUAL,
-                    installedAt = System.now().toEpochMilliseconds(),
-                    lastCheckedAt = System.now().toEpochMilliseconds(),
-                    lastUpdatedAt = System.now().toEpochMilliseconds(),
-                    isUpdateAvailable = false,
-                    updateCheckEnabled = true,
-                    releaseNotes = release?.description ?: "",
-                    systemArchitecture = installer.detectSystemArchitecture().name,
-                    fileExtension = primaryAsset?.name?.substringAfterLast('.', "apk") ?: "apk",
-                    isPendingInstall = false,
-                    installedVersionName = versionName,
-                    installedVersionCode = versionCode,
-                    latestVersionName = versionName,
-                    latestVersionCode = versionCode
-                )
-
-                installedAppsRepository.saveInstalledApp(installedApp)
-
-                // Reload the installed app state
-                val savedApp = installedAppsRepository.getAppByRepoId(repo.id)
-                _state.update { it.copy(installedApp = savedApp, isTrackingApp = false) }
-
-                _events.send(DetailsEvent.OnMessage(getString(Res.string.app_tracked_successfully)))
-
-                logger.debug("Successfully tracked existing app: ${repo.name} as $packageName")
-
-            } catch (e: Exception) {
-                logger.error("Failed to track existing app: ${e.message}")
-                _state.update { it.copy(isTrackingApp = false) }
-                _events.send(
-                    DetailsEvent.OnMessage(
-                        getString(Res.string.failed_to_track_app, e.message ?: "Unknown error")
-                    )
-                )
-            }
-        }
-    }
-
     @OptIn(ExperimentalTime::class)
     fun onAction(action: DetailsAction) {
         when (action) {
@@ -552,22 +449,14 @@ class DetailsViewModel(
                 }
             }
 
-            DetailsAction.CheckForUpdates -> {
+            DetailsAction.OnShareClick -> {
                 viewModelScope.launch {
-                    try {
-                        syncInstalledAppsUseCase()
-
-                        val installedApp = _state.value.installedApp ?: return@launch
-                        val hasUpdate =
-                            installedAppsRepository.checkForUpdates(installedApp.packageName)
+                    _state.value.repository?.let { repo ->
+                        shareManager.shareText("https://github-store.org/app?repo=${repo.fullName}")
 
-                        if (hasUpdate) {
-                            val updatedApp =
-                                installedAppsRepository.getAppByPackage(installedApp.packageName)
-                            _state.value = _state.value.copy(installedApp = updatedApp)
+                        if (platform != Platform.ANDROID) {
+                            _events.send(DetailsEvent.OnMessage("Link copied to clipboard"))
                         }
-                    } catch (t: Throwable) {
-                        logger.error("Failed to check for updates: ${t.message}")
                     }
                 }
             }
@@ -788,12 +677,6 @@ class DetailsViewModel(
                 }
             }
 
-            DetailsAction.TrackExistingApp -> {
-                val snapshot = _state.value
-                if (snapshot.isTrackingApp || !snapshot.isTrackable) return
-                trackExistingApp()
-            }
-
             DetailsAction.OnNavigateBackClick -> {
                 // Handled in composable
             }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package zed.rainxch.core.data.services`
	`1`	`+package zed.rainxch.core.data.utils`
`2`	`2`
`3`	`3`	`import kotlinx.coroutines.Dispatchers`
`4`	`4`	`import kotlinx.coroutines.withContext`