Refactor downgrade warning logic and relocate models

- Move `TranslationTarget` to its own file in the `model` package.
- Introduce `DowngradeWarning` model to replace event-based warning triggers.
- Update `DetailsState` and `DetailsViewModel` to manage downgrade warning state directly rather than via `DetailsEvent`.
- Add `OnDismissDowngradeWarning` action to `DetailsAction`.
- Refactor `DetailsRoot` to handle the downgrade warning dialog based on state changes.
- Cleanup unused imports and organize resource references in `DetailsRoot`.

Author: rainxchzed

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsAction.kt

@@ -3,10 +3,12 @@ package zed.rainxch.details.presentation
 import org.jetbrains.compose.resources.StringResource
 import zed.rainxch.core.domain.model.GithubRelease
 import zed.rainxch.details.domain.model.ReleaseCategory
+import zed.rainxch.details.presentation.model.TranslationTarget
 
 sealed interface DetailsAction {
     data object Retry : DetailsAction
     data object InstallPrimary : DetailsAction
+    data object OnDismissDowngradeWarning : DetailsAction
     data object UninstallApp : DetailsAction
     data class DownloadAsset(
         val downloadUrl: String,

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsEvent.kt

@@ -2,11 +2,5 @@ package zed.rainxch.details.presentation
 
 sealed interface DetailsEvent {
     data class OnOpenRepositoryInApp(val repositoryId: Long) : DetailsEvent
-    data class InstallTrackingFailed(val message: String) : DetailsEvent
     data class OnMessage(val message: String) : DetailsEvent
-    data class ShowDowngradeWarning(
-        val packageName: String,
-        val currentVersion: String,
-        val targetVersion: String
-    ) : DetailsEvent
 }

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsRoot.kt

@@ -40,26 +40,23 @@ import androidx.compose.material3.TopAppBarDefaults
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.CompositionLocalProvider
 import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.rememberCoroutineScope
-import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.shadow
 import androidx.compose.ui.graphics.Brush
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
-import zed.rainxch.githubstore.core.presentation.res.*
 import io.github.fletchmckee.liquid.LiquidState
 import io.github.fletchmckee.liquid.liquefiable
 import io.github.fletchmckee.liquid.liquid
 import io.github.fletchmckee.liquid.rememberLiquidState
 import kotlinx.coroutines.launch
 import org.jetbrains.compose.resources.getString
 import org.jetbrains.compose.resources.stringResource
-import androidx.compose.ui.tooling.preview.Preview
 import org.koin.compose.viewmodel.koinViewModel
 import zed.rainxch.core.presentation.theme.GithubStoreTheme
 import zed.rainxch.core.presentation.utils.ObserveAsEvents
@@ -72,7 +69,26 @@ import zed.rainxch.details.presentation.components.sections.logs
 import zed.rainxch.details.presentation.components.sections.stats
 import zed.rainxch.details.presentation.components.sections.whatsNew
 import zed.rainxch.details.presentation.components.states.ErrorState
+import zed.rainxch.details.presentation.model.TranslationTarget
 import zed.rainxch.details.presentation.utils.LocalTopbarLiquidState
+import zed.rainxch.githubstore.core.presentation.res.Res
+import zed.rainxch.githubstore.core.presentation.res.add_to_favourites
+import zed.rainxch.githubstore.core.presentation.res.cancel
+import zed.rainxch.githubstore.core.presentation.res.dismiss
+import zed.rainxch.githubstore.core.presentation.res.downgrade_requires_uninstall
+import zed.rainxch.githubstore.core.presentation.res.downgrade_warning_message
+import zed.rainxch.githubstore.core.presentation.res.install_permission_blocked_message
+import zed.rainxch.githubstore.core.presentation.res.install_permission_unavailable
+import zed.rainxch.githubstore.core.presentation.res.navigate_back
+import zed.rainxch.githubstore.core.presentation.res.open_repository
+import zed.rainxch.githubstore.core.presentation.res.open_with_external_installer
+import zed.rainxch.githubstore.core.presentation.res.remove_from_favourites
+import zed.rainxch.githubstore.core.presentation.res.repository_not_starred
+import zed.rainxch.githubstore.core.presentation.res.repository_starred
+import zed.rainxch.githubstore.core.presentation.res.share_repository
+import zed.rainxch.githubstore.core.presentation.res.star_from_github
+import zed.rainxch.githubstore.core.presentation.res.uninstall_first
+import zed.rainxch.githubstore.core.presentation.res.unstar_from_github
 
 @Composable
 fun DetailsRoot(
@@ -84,37 +100,56 @@ fun DetailsRoot(
     val state by viewModel.state.collectAsStateWithLifecycle()
     val snackbarHostState = remember { SnackbarHostState() }
     val coroutineScope = rememberCoroutineScope()
-    var downgradeWarning by remember {
-        mutableStateOf<DetailsEvent.ShowDowngradeWarning?>(null)
-    }
 
     ObserveAsEvents(viewModel.events) { event ->
         when (event) {
             is DetailsEvent.OnOpenRepositoryInApp -> {
                 onOpenRepositoryInApp(event.repositoryId)
             }
 
-            is DetailsEvent.InstallTrackingFailed -> {
-
-            }
-
             is DetailsEvent.OnMessage -> {
                 coroutineScope.launch {
                     snackbarHostState.showSnackbar(event.message)
                 }
             }
+        }
+    }
 
-            is DetailsEvent.ShowDowngradeWarning -> {
-                downgradeWarning = event
+    DetailsScreen(
+        state = state,
+        snackbarHostState = snackbarHostState,
+        onAction = { action ->
+            when (action) {
+                DetailsAction.OnNavigateBackClick -> {
+                    onNavigateBack()
+                }
+
+                is DetailsAction.OpenDeveloperProfile -> {
+                    onNavigateToDeveloperProfile(action.username)
+                }
+
+                is DetailsAction.OnMessage -> {
+                    coroutineScope.launch {
+                        snackbarHostState.showSnackbar(getString(action.messageText))
+                    }
+                }
+
+                else -> {
+                    viewModel.onAction(action)
+                }
             }
         }
-    }
+    )
 
-    downgradeWarning?.let { warning ->
+    state.downgradeWarning?.let { warning ->
         AlertDialog(
-            onDismissRequest = { downgradeWarning = null },
+            onDismissRequest = {
+                viewModel.onAction(DetailsAction.OnDismissDowngradeWarning)
+            },
             title = {
-                Text(text = stringResource(Res.string.downgrade_requires_uninstall))
+                Text(
+                    text = stringResource(Res.string.downgrade_requires_uninstall)
+                )
             },
             text = {
                 Text(
@@ -128,7 +163,7 @@ fun DetailsRoot(
             confirmButton = {
                 TextButton(
                     onClick = {
-                        downgradeWarning = null
+                        viewModel.onAction(DetailsAction.OnDismissDowngradeWarning)
                         viewModel.onAction(DetailsAction.UninstallApp)
                     }
                 ) {
@@ -139,8 +174,14 @@ fun DetailsRoot(
                 }
             },
             dismissButton = {
-                TextButton(onClick = { downgradeWarning = null }) {
-                    Text(text = stringResource(Res.string.cancel))
+                TextButton(
+                    onClick = {
+                        viewModel.onAction(DetailsAction.OnDismissDowngradeWarning)
+                    }
+                ) {
+                    Text(
+                        text = stringResource(Res.string.cancel)
+                    )
                 }
             }
         )
@@ -177,32 +218,6 @@ fun DetailsRoot(
             }
         )
     }
-
-    DetailsScreen(
-        state = state,
-        snackbarHostState = snackbarHostState,
-        onAction = { action ->
-            when (action) {
-                DetailsAction.OnNavigateBackClick -> {
-                    onNavigateBack()
-                }
-
-                is DetailsAction.OpenDeveloperProfile -> {
-                    onNavigateToDeveloperProfile(action.username)
-                }
-
-                is DetailsAction.OnMessage -> {
-                    coroutineScope.launch {
-                        snackbarHostState.showSnackbar(getString(action.messageText))
-                    }
-                }
-
-                else -> {
-                    viewModel.onAction(action)
-                }
-            }
-        }
-    )
 }
 
 @OptIn(ExperimentalMaterial3Api::class, ExperimentalMaterial3ExpressiveApi::class)
@@ -226,7 +241,9 @@ fun DetailsScreen(
                 )
             },
             snackbarHost = {
-                SnackbarHost(snackbarHostState)
+                SnackbarHost(
+                    hostState = snackbarHostState
+                )
             },
             containerColor = MaterialTheme.colorScheme.background,
             modifier = Modifier.liquefiable(liquidTopbarState)
@@ -242,7 +259,12 @@ fun DetailsScreen(
                 onLanguageSelected = { language ->
                     when (state.languagePickerTarget) {
                         TranslationTarget.About -> onAction(DetailsAction.TranslateAbout(language.code))
-                        TranslationTarget.WhatsNew -> onAction(DetailsAction.TranslateWhatsNew(language.code))
+                        TranslationTarget.WhatsNew -> onAction(
+                            DetailsAction.TranslateWhatsNew(
+                                language.code
+                            )
+                        )
+
                         null -> {}
                     }
                     onAction(DetailsAction.DismissLanguagePicker)
@@ -524,16 +546,16 @@ private fun DetailsTopbar(
             )
             .then(
                 if (isLiquidFrostAvailable()) {
-                Modifier.liquid(liquidTopbarState) {
-                    this.shape = CutCornerShape(0.dp)
-                    if (isLiquidFrostAvailable()) {
-                        this.frost = 5.dp
+                    Modifier.liquid(liquidTopbarState) {
+                        this.shape = CutCornerShape(0.dp)
+                        if (isLiquidFrostAvailable()) {
+                            this.frost = 5.dp
+                        }
+                        this.curve = .25f
+                        this.refraction = .05f
+                        this.dispersion = .1f
                     }
-                    this.curve = .25f
-                    this.refraction = .05f
-                    this.dispersion = .1f
-                }
-            } else Modifier.background(MaterialTheme.colorScheme.surfaceContainerHighest))
+                } else Modifier.background(MaterialTheme.colorScheme.surfaceContainerHighest))
     )
 }
 

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsState.kt

@@ -8,9 +8,11 @@ import zed.rainxch.core.domain.model.GithubUserProfile
 import zed.rainxch.core.domain.model.InstalledApp
 import zed.rainxch.details.domain.model.ReleaseCategory
 import zed.rainxch.details.domain.model.RepoStats
+import zed.rainxch.details.presentation.model.DowngradeWarning
 import zed.rainxch.details.presentation.model.DownloadStage
 import zed.rainxch.details.presentation.model.InstallLogItem
 import zed.rainxch.details.presentation.model.TranslationState
+import zed.rainxch.details.presentation.model.TranslationTarget
 
 data class DetailsState(
     val isLoading: Boolean = true,
@@ -67,6 +69,8 @@ data class DetailsState(
 
     val isComingFromUpdate: Boolean = false,
 
+    val downgradeWarning: DowngradeWarning? = null,
+
     val showExternalInstallerPrompt: Boolean = false,
     val pendingInstallFilePath: String? = null,
 ) {
@@ -76,9 +80,4 @@ data class DetailsState(
             ReleaseCategory.PRE_RELEASE -> allReleases.filter { it.isPrerelease }
             ReleaseCategory.ALL -> allReleases
         }
-}
-
-sealed interface TranslationTarget {
-    data object About : TranslationTarget
-    data object WhatsNew : TranslationTarget
 }

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsViewModel.kt

@@ -42,6 +42,7 @@ import zed.rainxch.core.domain.utils.ShareManager
 import zed.rainxch.details.domain.model.ReleaseCategory
 import zed.rainxch.details.domain.repository.DetailsRepository
 import zed.rainxch.details.domain.repository.TranslationRepository
+import zed.rainxch.details.presentation.model.DowngradeWarning
 import zed.rainxch.details.presentation.model.DownloadStage
 import zed.rainxch.details.presentation.model.InstallLogItem
 import zed.rainxch.details.presentation.model.LogResult
@@ -322,6 +323,12 @@ class DetailsViewModel(
                 loadInitial()
             }
 
+            DetailsAction.OnDismissDowngradeWarning -> {
+                _state.update { it.copy(
+                    downgradeWarning = null
+                ) }
+            }
+
             DetailsAction.InstallPrimary -> {
                 val primary = _state.value.primaryAsset
                 val release = _state.value.selectedRelease
@@ -340,15 +347,13 @@ class DetailsViewModel(
                         )
 
                         if (isDowngrade) {
-                            viewModelScope.launch {
-                                _events.send(
-                                    DetailsEvent.ShowDowngradeWarning(
-                                        packageName = installedApp.packageName,
-                                        currentVersion = installedApp.installedVersion,
-                                        targetVersion = release.tagName
-                                    )
+                            _state.update { it.copy(
+                                downgradeWarning = DowngradeWarning(
+                                    packageName = installedApp.packageName,
+                                    currentVersion = installedApp.installedVersion,
+                                    targetVersion = release.tagName
                                 )
-                            }
+                            ) }
                             return
                         }
                     }

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/model/ShowDowngradeWarning.kt

@@ -0,0 +1,7 @@
+package zed.rainxch.details.presentation.model
+
+data class DowngradeWarning(
+    val packageName: String,
+    val currentVersion: String,
+    val targetVersion: String
+)

feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/model/TranslationTarget.kt

@@ -0,0 +1,6 @@
+package zed.rainxch.details.presentation.model
+
+sealed interface TranslationTarget {
+    data object About : TranslationTarget
+    data object WhatsNew : TranslationTarget
+}