Skip to content

Commit 2203fec

Browse files
committed
Add update interval localization and refactor self-registration logic
- Added string resources for update check intervals (3h, 6h, 12h, 24h) and a new "Updates" section across multiple languages (ko, pl, it, ja, fr, hi, bn, es, ar, zh-rCN, ru, tr). - Refactored self-app registration in `GithubStoreApp.kt` to improve code formatting. - Removed unused `Logger` imports and simplified exception handling during self-registration.
1 parent 3e43454 commit 2203fec

13 files changed

Lines changed: 116 additions & 34 deletions

File tree

composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt

Lines changed: 32 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import android.app.Application
44
import android.app.NotificationChannel
55
import android.app.NotificationManager
66
import android.os.Build
7-
import co.touchlab.kermit.Logger
87
import kotlinx.coroutines.CoroutineScope
98
import kotlinx.coroutines.Dispatchers
109
import kotlinx.coroutines.SupervisorJob
@@ -105,41 +104,40 @@ class GithubStoreApp : Application() {
105104
val versionName = systemInfo?.versionName ?: ""
106105
val versionCode = systemInfo?.versionCode ?: 0L
107106

108-
val selfApp = InstalledApp(
109-
packageName = SELF_PACKAGE_NAME,
110-
repoId = 0L,
111-
repoName = SELF_REPO_NAME,
112-
repoOwner = SELF_REPO_OWNER,
113-
repoOwnerAvatarUrl = "https://avatars.githubusercontent.com/u/221085707",
114-
repoDescription = "A cross-platform app store for GitHub releases",
115-
primaryLanguage = "Kotlin",
116-
repoUrl = "https://github.com/$SELF_REPO_OWNER/$SELF_REPO_NAME",
117-
installedVersion = versionName,
118-
installedAssetName = null,
119-
installedAssetUrl = null,
120-
latestVersion = null,
121-
latestAssetName = null,
122-
latestAssetUrl = null,
123-
latestAssetSize = null,
124-
appName = "GitHub Store",
125-
installSource = InstallSource.THIS_APP,
126-
installedAt = now,
127-
lastCheckedAt = 0L,
128-
lastUpdatedAt = now,
129-
isUpdateAvailable = false,
130-
updateCheckEnabled = true,
131-
releaseNotes = null,
132-
systemArchitecture = "",
133-
fileExtension = "apk",
134-
isPendingInstall = false,
135-
installedVersionName = versionName,
136-
installedVersionCode = versionCode,
137-
)
107+
val selfApp =
108+
InstalledApp(
109+
packageName = SELF_PACKAGE_NAME,
110+
repoId = 0L,
111+
repoName = SELF_REPO_NAME,
112+
repoOwner = SELF_REPO_OWNER,
113+
repoOwnerAvatarUrl = "https://avatars.githubusercontent.com/u/221085707",
114+
repoDescription = "A cross-platform app store for GitHub releases",
115+
primaryLanguage = "Kotlin",
116+
repoUrl = "https://github.com/$SELF_REPO_OWNER/$SELF_REPO_NAME",
117+
installedVersion = versionName,
118+
installedAssetName = null,
119+
installedAssetUrl = null,
120+
latestVersion = null,
121+
latestAssetName = null,
122+
latestAssetUrl = null,
123+
latestAssetSize = null,
124+
appName = "GitHub Store",
125+
installSource = InstallSource.THIS_APP,
126+
installedAt = now,
127+
lastCheckedAt = 0L,
128+
lastUpdatedAt = now,
129+
isUpdateAvailable = false,
130+
updateCheckEnabled = true,
131+
releaseNotes = null,
132+
systemArchitecture = "",
133+
fileExtension = "apk",
134+
isPendingInstall = false,
135+
installedVersionName = versionName,
136+
installedVersionCode = versionCode,
137+
)
138138

139139
repo.saveInstalledApp(selfApp)
140-
Logger.i { "GithubStoreApp: Registered self as tracked installed app (v$versionName)" }
141-
} catch (e: Exception) {
142-
Logger.e { "GithubStoreApp: Failed to register self: ${e.message}" }
140+
} catch (_: Exception) {
143141
}
144142
}
145143
}

core/presentation/src/commonMain/composeResources/values-ar/strings-ar.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -521,4 +521,11 @@
521521
<string name="auto_update_title">تحديث التطبيقات تلقائيًا</string>
522522
<string name="auto_update_description">تنزيل التحديثات وتثبيتها تلقائيًا في الخلفية عبر Shizuku</string>
523523

524+
<string name="section_updates">التحديثات</string>
525+
<string name="update_check_interval_title">فترة التحقق من التحديثات</string>
526+
<string name="update_check_interval_description">عدد مرات التحقق من تحديثات التطبيق في الخلفية</string>
527+
<string name="interval_3h">٣ ساعات</string>
528+
<string name="interval_6h">٦ ساعات</string>
529+
<string name="interval_12h">١٢ ساعة</string>
530+
<string name="interval_24h">٢٤ ساعة</string>
524531
</resources>

core/presentation/src/commonMain/composeResources/values-bn/strings-bn.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,4 +520,11 @@
520520
<string name="auto_update_title">স্বয়ংক্রিয়ভাবে অ্যাপ আপডেট করুন</string>
521521
<string name="auto_update_description">Shizuku এর মাধ্যমে ব্যাকগ্রাউন্ডে স্বয়ংক্রিয়ভাবে আপডেট ডাউনলোড এবং ইনস্টল করুন</string>
522522

523+
<string name="section_updates">আপডেট</string>
524+
<string name="update_check_interval_title">আপডেট চেক করার ব্যবধান</string>
525+
<string name="update_check_interval_description">ব্যাকগ্রাউন্ডে কতক্ষণ পর পর অ্যাপ আপডেট খোঁজা হবে</string>
526+
<string name="interval_3h">৩ঘ</string>
527+
<string name="interval_6h">৬ঘ</string>
528+
<string name="interval_12h">১২ঘ</string>
529+
<string name="interval_24h">২৪ঘ</string>
523530
</resources>

core/presentation/src/commonMain/composeResources/values-es/strings-es.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,4 +481,11 @@
481481
<string name="auto_update_title">Actualizar apps automáticamente</string>
482482
<string name="auto_update_description">Descargar e instalar actualizaciones en segundo plano a través de Shizuku</string>
483483

484+
<string name="section_updates">Actualizaciones</string>
485+
<string name="update_check_interval_title">Intervalo de verificación</string>
486+
<string name="update_check_interval_description">Con qué frecuencia buscar actualizaciones en segundo plano</string>
487+
<string name="interval_3h">3h</string>
488+
<string name="interval_6h">6h</string>
489+
<string name="interval_12h">12h</string>
490+
<string name="interval_24h">24h</string>
484491
</resources>

core/presentation/src/commonMain/composeResources/values-fr/strings-fr.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,4 +482,11 @@
482482
<string name="auto_update_title">Mise à jour automatique</string>
483483
<string name="auto_update_description">Télécharger et installer automatiquement les mises à jour en arrière-plan via Shizuku</string>
484484

485+
<string name="section_updates">Mises à jour</string>
486+
<string name="update_check_interval_title">Intervalle de vérification</string>
487+
<string name="update_check_interval_description">Fréquence de vérification des mises à jour en arrière-plan</string>
488+
<string name="interval_3h">3h</string>
489+
<string name="interval_6h">6h</string>
490+
<string name="interval_12h">12h</string>
491+
<string name="interval_24h">24h</string>
485492
</resources>

core/presentation/src/commonMain/composeResources/values-hi/strings-hi.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,4 +520,11 @@
520520
<string name="auto_update_title">ऐप्स ऑटो-अपडेट करें</string>
521521
<string name="auto_update_description">Shizuku के माध्यम से पृष्ठभूमि में स्वचालित रूप से अपडेट डाउनलोड और इंस्टॉल करें</string>
522522

523+
<string name="section_updates">अपडेट</string>
524+
<string name="update_check_interval_title">अपडेट जाँच अंतराल</string>
525+
<string name="update_check_interval_description">पृष्ठभूमि में ऐप अपडेट कितनी बार जाँचें</string>
526+
<string name="interval_3h">3घ</string>
527+
<string name="interval_6h">6घ</string>
528+
<string name="interval_12h">12घ</string>
529+
<string name="interval_24h">24घ</string>
523530
</resources>

core/presentation/src/commonMain/composeResources/values-it/strings-it.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,4 +520,11 @@
520520
<string name="auto_update_title">Aggiornamento automatico</string>
521521
<string name="auto_update_description">Scarica e installa automaticamente gli aggiornamenti in background tramite Shizuku</string>
522522

523+
<string name="section_updates">Aggiornamenti</string>
524+
<string name="update_check_interval_title">Intervallo di controllo</string>
525+
<string name="update_check_interval_description">Ogni quanto verificare gli aggiornamenti in background</string>
526+
<string name="interval_3h">3h</string>
527+
<string name="interval_6h">6h</string>
528+
<string name="interval_12h">12h</string>
529+
<string name="interval_24h">24h</string>
523530
</resources>

core/presentation/src/commonMain/composeResources/values-ja/strings-ja.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,4 +482,11 @@
482482
<string name="auto_update_title">アプリを自動更新</string>
483483
<string name="auto_update_description">Shizukuを使用してバックグラウンドで自動的にアップデートをダウンロードしてインストール</string>
484484

485+
<string name="section_updates">アップデート</string>
486+
<string name="update_check_interval_title">アップデート確認間隔</string>
487+
<string name="update_check_interval_description">バックグラウンドでアプリのアップデートを確認する頻度</string>
488+
<string name="interval_3h">3時間</string>
489+
<string name="interval_6h">6時間</string>
490+
<string name="interval_12h">12時間</string>
491+
<string name="interval_24h">24時間</string>
485492
</resources>

core/presentation/src/commonMain/composeResources/values-ko/strings-ko.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,4 +517,11 @@
517517
<string name="auto_update_title">앱 자동 업데이트</string>
518518
<string name="auto_update_description">Shizuku를 통해 백그라운드에서 자동으로 업데이트 다운로드 및 설치</string>
519519

520+
<string name="section_updates">업데이트</string>
521+
<string name="update_check_interval_title">업데이트 확인 주기</string>
522+
<string name="update_check_interval_description">백그라운드에서 앱 업데이트를 확인하는 빈도</string>
523+
<string name="interval_3h">3시간</string>
524+
<string name="interval_6h">6시간</string>
525+
<string name="interval_12h">12시간</string>
526+
<string name="interval_24h">24시간</string>
520527
</resources>

core/presentation/src/commonMain/composeResources/values-pl/strings-pl.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -484,4 +484,11 @@
484484
<string name="auto_update_title">Automatyczna aktualizacja</string>
485485
<string name="auto_update_description">Automatycznie pobieraj i instaluj aktualizacje w tle przez Shizuku</string>
486486

487+
<string name="section_updates">Aktualizacje</string>
488+
<string name="update_check_interval_title">Częstotliwość sprawdzania</string>
489+
<string name="update_check_interval_description">Jak często sprawdzać aktualizacje aplikacji w tle</string>
490+
<string name="interval_3h">3g</string>
491+
<string name="interval_6h">6g</string>
492+
<string name="interval_12h">12g</string>
493+
<string name="interval_24h">24g</string>
487494
</resources>

0 commit comments

Comments
 (0)