feat: Add navigation to developer profiles from repository lists

rainxchzed · rainxchzed · commit 1a599ff6da42 · 2026-01-14T20:01:56.000+05:00
This adds the ability to navigate to a developer's profile screen by clicking on their avatar or username in the "Starred Repositories" and "Favorites" lists.

Specific changes:
- Implemented `OnDeveloperProfileClick` actions in the `StarredRepos` and `Favourites` features.
- Updated the `StarredRepositoryItem` and `FavouriteRepositoryItem` to handle clicks on the owner's avatar and name, triggering navigation.
- Wired the navigation logic in `AppNavigation` to handle opening the developer profile screen.
- Renamed `OpenAuthorInApp` to `OpenDeveloperProfile` in the details screen for consistency.
- Localized several strings in `StarredRepositoryItem` using string resources.
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/navigation/AppNavigation.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/navigation/AppNavigation.kt
@@ -162,6 +162,13 @@ fun AppNavigation(
                             onNavigateToDetails = {
                                 navBackStack.add(GithubStoreGraph.DetailsScreen(it))
                             },
+                            onNavigateToDeveloperProfile = { username ->
+                                navBackStack.add(
+                                    GithubStoreGraph.DeveloperProfileScreen(
+                                        username = username
+                                    )
+                                )
+                            },
                         )
                     }
 
@@ -176,7 +183,14 @@ fun AppNavigation(
                                         repositoryId = repoId
                                     )
                                 )
-                            }
+                            },
+                            onNavigateToDeveloperProfile = { username ->
+                                navBackStack.add(
+                                    GithubStoreGraph.DeveloperProfileScreen(
+                                        username = username
+                                    )
+                                )
+                            },
                         )
                     }
 
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsAction.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsAction.kt
@@ -15,7 +15,7 @@ sealed interface DetailsAction {
 
     data object OpenRepoInBrowser : DetailsAction
     data object OpenAuthorInBrowser : DetailsAction
-    data class OpenAuthorInApp(val authorLogin: String) : DetailsAction
+    data class OpenDeveloperProfile(val username: String) : DetailsAction
 
     data object OpenInObtainium : DetailsAction
     data object OpenInAppManager : DetailsAction
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsRoot.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsRoot.kt
@@ -106,8 +106,8 @@ fun DetailsRoot(
                     onNavigateBack()
                 }
 
-                is DetailsAction.OpenAuthorInApp -> {
-                    onNavigateToDeveloperProfile(action.authorLogin)
+                is DetailsAction.OpenDeveloperProfile -> {
+                    onNavigateToDeveloperProfile(action.username)
                 }
 
                 is DetailsAction.OnMessage -> {
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsViewModel.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/DetailsViewModel.kt
@@ -508,7 +508,7 @@ class DetailsViewModel(
                 // Handled in composable
             }
 
-            is DetailsAction.OpenAuthorInApp -> {
+            is DetailsAction.OpenDeveloperProfile -> {
                 // Handled in composable
             }
 
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/components/sections/Owner.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/details/presentation/components/sections/Owner.kt
@@ -69,7 +69,7 @@ fun LazyListScope.author(
             onClick = {
                 author?.login?.let { author ->
                     onAction(
-                        DetailsAction.OpenAuthorInApp(
+                        DetailsAction.OpenDeveloperProfile(
                             author
                         )
                     )
@@ -154,7 +154,7 @@ fun LazyListScope.author(
                 author?.login?.let { author ->
                     IconButton(
                         onClick = {
-                            onAction(DetailsAction.OpenAuthorInApp(author))
+                            onAction(DetailsAction.OpenDeveloperProfile(author))
                         },
                         colors = IconButtonDefaults.iconButtonColors(
                             containerColor = MaterialTheme.colorScheme.surfaceContainerHigh,
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesAction.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesAction.kt
@@ -6,4 +6,5 @@ sealed interface FavouritesAction {
     data object OnNavigateBackClick : FavouritesAction
     data class OnToggleFavorite(val favouriteRepository: FavouriteRepository) : FavouritesAction
     data class OnRepositoryClick(val favouriteRepository: FavouriteRepository) : FavouritesAction
+    data class OnDeveloperProfileClick(val username: String) : FavouritesAction
 }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesRoot.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesRoot.kt
@@ -41,6 +41,7 @@ import zed.rainxch.githubstore.feature.favourites.presentation.components.Favour
 fun FavouritesRoot(
     onNavigateBack: () -> Unit,
     onNavigateToDetails: (repoId: Long) -> Unit,
+    onNavigateToDeveloperProfile: (username: String) -> Unit,
     viewModel: FavouritesViewModel = koinViewModel()
 ) {
     val state by viewModel.state.collectAsStateWithLifecycle()
@@ -57,6 +58,10 @@ fun FavouritesRoot(
                     onNavigateToDetails(action.favouriteRepository.repoId)
                 }
 
+                is FavouritesAction.OnDeveloperProfileClick -> {
+                    onNavigateToDeveloperProfile(action.username)
+                }
+
                 else -> {
                     viewModel.onAction(action)
                 }
@@ -103,6 +108,9 @@ fun FavouritesScreen(
                         onItemClick = {
                             onAction(FavouritesAction.OnRepositoryClick(repo))
                         },
+                        onDevProfileClick = {
+                            onAction(FavouritesAction.OnDeveloperProfileClick(repo.repoOwner))
+                        },
                         modifier = Modifier.Companion.animateItem()
                     )
                 }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesViewModel.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/FavouritesViewModel.kt
@@ -64,6 +64,10 @@ class FavouritesViewModel(
                 // Handled in composable
             }
 
+            is FavouritesAction.OnDeveloperProfileClick -> {
+                // Handled in composable
+            }
+
             is FavouritesAction.OnToggleFavorite -> {
                 viewModelScope.launch {
                     val repo = action.favouriteRepository
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/components/FavouriteRepositoryItem.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/favourites/presentation/components/FavouriteRepositoryItem.kt
@@ -1,6 +1,7 @@
 package zed.rainxch.githubstore.feature.favourites.presentation.components
 
 import androidx.compose.foundation.background
+import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
@@ -45,6 +46,7 @@ fun FavouriteRepositoryItem(
     favouriteRepository: FavouriteRepository,
     onToggleFavouriteClick: () -> Unit,
     onItemClick: () -> Unit,
+    onDevProfileClick: () -> Unit,
     modifier: Modifier = Modifier
 ) {
     Card(
@@ -61,6 +63,10 @@ fun FavouriteRepositoryItem(
                 .padding(16.dp)
         ) {
             Row(
+                modifier = Modifier
+                    .clickable(onClick = {
+                        onDevProfileClick()
+                    }),
                 verticalAlignment = Alignment.CenterVertically,
                 horizontalArrangement = Arrangement.spacedBy(8.dp)
             ) {
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposAction.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposAction.kt
@@ -8,5 +8,6 @@ sealed interface StarredReposAction {
     data object OnRetrySync : StarredReposAction
     data object OnDismissError : StarredReposAction
     data class OnRepositoryClick(val repository: StarredRepositoryUi) : StarredReposAction
+    data class OnDeveloperProfileClick(val username: String) : StarredReposAction
     data class OnToggleFavorite(val repository: StarredRepositoryUi) : StarredReposAction
 }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposRoot.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposRoot.kt
@@ -43,7 +43,6 @@ import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextAlign
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
-import androidx.lifecycle.viewmodel.compose.viewModel
 import githubstore.composeapp.generated.resources.Res
 import githubstore.composeapp.generated.resources.days_ago
 import githubstore.composeapp.generated.resources.dismiss
@@ -55,7 +54,6 @@ import githubstore.composeapp.generated.resources.navigate_back
 import githubstore.composeapp.generated.resources.no_starred_repos
 import githubstore.composeapp.generated.resources.retry
 import githubstore.composeapp.generated.resources.sign_in_required
-import githubstore.composeapp.generated.resources.sign_in_with_github
 import githubstore.composeapp.generated.resources.sign_in_with_github_for_stars
 import githubstore.composeapp.generated.resources.star_repos_hint
 import githubstore.composeapp.generated.resources.starred_repositories
@@ -64,7 +62,6 @@ import org.jetbrains.compose.resources.stringResource
 import org.jetbrains.compose.ui.tooling.preview.Preview
 import org.koin.compose.viewmodel.koinViewModel
 import zed.rainxch.githubstore.core.presentation.theme.GithubStoreTheme
-import zed.rainxch.githubstore.feature.favourites.presentation.FavouritesAction
 import zed.rainxch.githubstore.feature.starred_repos.presentation.components.StarredRepositoryItem
 import kotlin.time.Clock
 import kotlin.time.ExperimentalTime
@@ -73,6 +70,7 @@ import kotlin.time.ExperimentalTime
 fun StarredReposRoot(
     onNavigateBack: () -> Unit,
     onNavigateToDetails: (repoId: Long) -> Unit,
+    onNavigateToDeveloperProfile: (username: String) -> Unit,
     viewModel: StarredReposViewModel = koinViewModel()
 ) {
     val state by viewModel.state.collectAsStateWithLifecycle()
@@ -83,6 +81,7 @@ fun StarredReposRoot(
             when (action) {
                 StarredReposAction.OnNavigateBackClick -> onNavigateBack()
                 is StarredReposAction.OnRepositoryClick -> onNavigateToDetails(action.repository.repoId)
+                is StarredReposAction.OnDeveloperProfileClick -> onNavigateToDeveloperProfile(action.username)
                 else -> viewModel.onAction(action)
             }
         }
@@ -169,6 +168,9 @@ fun StarredScreen(
                                     onItemClick = {
                                         onAction(StarredReposAction.OnRepositoryClick(repo))
                                     },
+                                    onDevProfileClick = {
+                                        onAction(StarredReposAction.OnDeveloperProfileClick(repo.repoOwner))
+                                    },
                                     modifier = Modifier.animateItem()
                                 )
                             }
@@ -194,12 +196,21 @@ fun StarredScreen(
                         }
                     },
                     dismissAction = {
-                        IconButton(onClick = { onAction(StarredReposAction.OnDismissError) }) {
-                            Icon(Icons.Default.Close, contentDescription = stringResource(Res.string.dismiss))
+                        IconButton(
+                            onClick = {
+                                onAction(StarredReposAction.OnDismissError)
+                            }
+                        ) {
+                            Icon(
+                                imageVector = Icons.Default.Close,
+                                contentDescription = stringResource(Res.string.dismiss)
+                            )
                         }
                     }
                 ) {
-                    Text(message)
+                    Text(
+                        text = message
+                    )
                 }
             }
         }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposViewModel.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/StarredReposViewModel.kt
@@ -133,6 +133,10 @@ class StarredReposViewModel (
                 // Handled in composable
             }
 
+            is StarredReposAction.OnDeveloperProfileClick -> {
+                // Handled in composable
+            }
+
             StarredReposAction.OnRefresh -> {
                 syncStarredRepos(forceRefresh = true)
             }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/components/StarredRepositoryItem.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/components/StarredRepositoryItem.kt
@@ -1,5 +1,6 @@
 package zed.rainxch.githubstore.feature.starred_repos.presentation.components
 
+import androidx.compose.foundation.clickable
 import androidx.compose.foundation.horizontalScroll
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
@@ -38,6 +39,15 @@ import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
 import com.skydoves.landscapist.ImageOptions
 import com.skydoves.landscapist.coil3.CoilImage
+import githubstore.composeapp.generated.resources.Res
+import githubstore.composeapp.generated.resources.add_to_favourites
+import githubstore.composeapp.generated.resources.count_thousands
+import githubstore.composeapp.generated.resources.forks
+import githubstore.composeapp.generated.resources.installed
+import githubstore.composeapp.generated.resources.issues
+import githubstore.composeapp.generated.resources.remove_from_favourites
+import githubstore.composeapp.generated.resources.stars
+import org.jetbrains.compose.resources.stringResource
 import org.jetbrains.compose.ui.tooling.preview.Preview
 import zed.rainxch.githubstore.core.presentation.theme.GithubStoreTheme
 import zed.rainxch.githubstore.feature.starred_repos.presentation.model.StarredRepositoryUi
@@ -48,6 +58,7 @@ fun StarredRepositoryItem(
     repository: StarredRepositoryUi,
     onToggleFavoriteClick: () -> Unit,
     onItemClick: () -> Unit,
+    onDevProfileClick: () -> Unit,
     modifier: Modifier = Modifier
 ) {
     Card(
@@ -67,15 +78,24 @@ fun StarredRepositoryItem(
                     imageModel = { repository.repoOwnerAvatarUrl },
                     modifier = Modifier
                         .size(40.dp)
-                        .clip(CircleShape),
+                        .clip(CircleShape)
+                        .clickable(onClick = {
+                            onDevProfileClick()
+                        }),
                     imageOptions = ImageOptions(
                         contentScale = ContentScale.Crop
                     ),
                 )
 
                 Spacer(modifier = Modifier.width(12.dp))
 
-                Column(modifier = Modifier.weight(1f)) {
+                Column(
+                    modifier = Modifier
+                        .weight(1f)
+                        .clickable(onClick = {
+                            onDevProfileClick()
+                        })
+                ) {
                     Text(
                         text = repository.repoName,
                         style = MaterialTheme.typography.titleMedium,
@@ -105,9 +125,9 @@ fun StarredRepositoryItem(
                             Icons.Outlined.FavoriteBorder
                         },
                         contentDescription = if (repository.isFavorite) {
-                            "Remove from favorites"
+                            stringResource(Res.string.remove_from_favourites)
                         } else {
-                            "Add to favorites"
+                            stringResource(Res.string.add_to_favourites)
                         },
                         modifier = Modifier.size(20.dp)
                     )
@@ -138,20 +158,20 @@ fun StarredRepositoryItem(
                 StatChip(
                     icon = Icons.Default.Star,
                     label = formatCount(repository.stargazersCount),
-                    contentDescription = "${repository.stargazersCount} stars"
+                    contentDescription = "${repository.stargazersCount} ${stringResource(Res.string.stars)}"
                 )
 
                 StatChip(
                     icon = Icons.AutoMirrored.Filled.CallSplit,
                     label = formatCount(repository.forksCount),
-                    contentDescription = "${repository.forksCount} forks"
+                    contentDescription = "${repository.forksCount} ${stringResource(Res.string.forks)}"
                 )
 
                 if (repository.openIssuesCount > 0) {
                     StatChip(
                         icon = Icons.Outlined.Warning,
                         label = formatCount(repository.openIssuesCount),
-                        contentDescription = "${repository.openIssuesCount} open issues"
+                        contentDescription = "${repository.openIssuesCount} ${stringResource(Res.string.issues)}"
                     )
                 }
 
@@ -182,7 +202,7 @@ fun StarredRepositoryItem(
                             containerColor = MaterialTheme.colorScheme.primaryContainer
                         ) {
                             Text(
-                                text = "Installed",
+                                text = stringResource(Res.string.installed),
                                 style = MaterialTheme.typography.labelSmall,
                                 color = MaterialTheme.colorScheme.onPrimaryContainer
                             )
@@ -234,9 +254,10 @@ private fun StatChip(
     }
 }
 
+@Composable
 private fun formatCount(count: Int): String {
     return when {
-        count >= 1000 -> "${count / 1000}k"
+        count >= 1000 -> stringResource(Res.string.count_thousands, count / 1000)
         else -> count.toString()
     }
 }
@@ -264,7 +285,8 @@ private fun PreviewStarredRepoItem() {
                 starredAt = null
             ),
             onToggleFavoriteClick = {},
-            onItemClick = {}
+            onItemClick = {},
+            onDevProfileClick = {}
         )
     }
 }
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/mappers/StarredRepoToUiMapper.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/feature/starred_repos/presentation/mappers/StarredRepoToUiMapper.kt

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,13 @@ fun AppNavigation(`
`162`	`162`	`onNavigateToDetails = {`
`163`	`163`	`navBackStack.add(GithubStoreGraph.DetailsScreen(it))`
`164`	`164`	`},`
	`165`	`+ onNavigateToDeveloperProfile = { username ->`
	`166`	`+ navBackStack.add(`
	`167`	`+ GithubStoreGraph.DeveloperProfileScreen(`
	`168`	`+ username = username`
	`169`	`+ )`
	`170`	`+ )`
	`171`	`+ },`
`165`	`172`	`)`
`166`	`173`	`}`
`167`	`174`
`@@ -176,7 +183,14 @@ fun AppNavigation(`
`176`	`183`	`repositoryId = repoId`
`177`	`184`	`)`
`178`	`185`	`)`
`179`		`- }`
	`186`	`+ },`
	`187`	`+ onNavigateToDeveloperProfile = { username ->`
	`188`	`+ navBackStack.add(`
	`189`	`+ GithubStoreGraph.DeveloperProfileScreen(`
	`190`	`+ username = username`
	`191`	`+ )`
	`192`	`+ )`
	`193`	`+ },`
`180`	`194`	`)`
`181`	`195`	`}`
`182`	`196`
Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,8 @@ fun DetailsRoot(`
`106`	`106`	`onNavigateBack()`
`107`	`107`	`}`
`108`	`108`
`109`		`- is DetailsAction.OpenAuthorInApp -> {`
`110`		`- onNavigateToDeveloperProfile(action.authorLogin)`
	`109`	`+ is DetailsAction.OpenDeveloperProfile -> {`
	`110`	`+ onNavigateToDeveloperProfile(action.username)`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`is DetailsAction.OnMessage -> {`
Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ class DetailsViewModel(`
`508`	`508`	`// Handled in composable`
`509`	`509`	`}`
`510`	`510`
`511`		`- is DetailsAction.OpenAuthorInApp -> {`
	`511`	`+ is DetailsAction.OpenDeveloperProfile -> {`
`512`	`512`	`// Handled in composable`
`513`	`513`	`}`
`514`	`514`
Original file line number	Diff line number	Diff line change
`@@ -6,4 +6,5 @@ sealed interface FavouritesAction {`
`6`	`6`	`data object OnNavigateBackClick : FavouritesAction`
`7`	`7`	`data class OnToggleFavorite(val favouriteRepository: FavouriteRepository) : FavouritesAction`
`8`	`8`	`data class OnRepositoryClick(val favouriteRepository: FavouriteRepository) : FavouritesAction`
	`9`	`+ data class OnDeveloperProfileClick(val username: String) : FavouritesAction`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,6 @@ sealed interface StarredReposAction {`
`8`	`8`	`data object OnRetrySync : StarredReposAction`
`9`	`9`	`data object OnDismissError : StarredReposAction`
`10`	`10`	`data class OnRepositoryClick(val repository: StarredRepositoryUi) : StarredReposAction`
	`11`	`+ data class OnDeveloperProfileClick(val username: String) : StarredReposAction`
`11`	`12`	`data class OnToggleFavorite(val repository: StarredRepositoryUi) : StarredReposAction`
`12`	`13`	`}`