Skip to content

Commit 3c034bc

Browse files
committed
update container tag naming
1 parent a0c057a commit 3c034bc

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

nodethon/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Builds and pushes a docker environment useful for testing and building Node.js applications that also use Python or Python applications that also use Node.js. This environment contains Node.js and a few other, essential JavaScript dependencies as well as series of python versions allowing multi-version tox testing locally and in CI services.
44

5-
All nodethon images include the ["sonarqube"](https://www.sonarqube.org) scanner. This scanner allows node and tox builds to upload coverage and analysis reports to a sonarqube instance.
5+
All *nodethon* images include the ["sonarqube"](https://www.sonarqube.org) scanner. This scanner allows node and tox builds to upload coverage and analysis reports to a sonarqube instance.
66

77
## Build and Push
88

@@ -19,23 +19,23 @@ nodethon latest d7ab132649d6
1919
```
2020
```
2121
# We use the range of python environments supported as the version tag.
22-
docker tag d7ab132649d6 uavcan/nodethon:py35-py38-node13-sq
22+
docker tag d7ab132649d6 uavcan/nodethon:node13-py37-py38
2323
docker login --username=yourhubusername
24-
docker push uavcan/nodethon:py35-py38-node13-sq
24+
docker push uavcan/nodethon:node13-py37-py38
2525
```
2626

2727
## Testing out the container
2828

2929
Start an interactive session:
3030

3131
```bash
32-
docker run --rm -it -v ${PWD}:/repo uavcan/nodethon:py35-py38-node13-sq
32+
docker run --rm -it -v ${PWD}:/repo uavcan/nodethon:node13-py37-py38
3333
```
3434

3535
On MacOS you'll probably want to optimize `osxfs` with something like cached or delegated:
3636

3737
```bash
38-
docker run --rm -it -v ${PWD}:/repo:delegated uavcan/nodethon:py35-py38-node13-sq
38+
docker run --rm -it -v ${PWD}:/repo:delegated uavcan/nodethon:node13-py37-py38
3939
```
4040

4141
See ["Performance tuning for volume mounts"](https://docs.docker.com/docker-for-mac/osxfs-caching/) for details.
@@ -49,10 +49,10 @@ services:
4949
- docker
5050
5151
before_install:
52-
- docker pull uavcan/nodethon:py35-py38-node13-sq
52+
- docker pull uavcan/nodethon:node13-py37-py38
5353
5454
script:
55-
- docker run --rm -v $TRAVIS_BUILD_DIR:/repo uavcan/nodethon:py35-py38-node13-sq /bin/sh -c tox
55+
- docker run --rm -v $TRAVIS_BUILD_DIR:/repo uavcan/nodethon:node13-py37-py38 /bin/sh -c tox
5656
5757
```
5858

@@ -66,7 +66,7 @@ Example pipeline.yml:
6666
plugins:
6767
- docker#v3.5.0:
6868
workdir: /repo
69-
image: "uavcan/nodethon:py35-py38-node13-sq"
69+
image: "uavcan/nodethon:node13-py37-py38"
7070
propagate-environment: true
7171
mount-ssh-agent: true
7272
```

0 commit comments

Comments
 (0)