Modernize analyzers and assertions with C# 12 features

Refactored assertion helper structs to use primary constructors,
removing redundant fields and constructors. Updated analyzer and
code fix provider classes to use collection expressions for
ImmutableArray properties. Suppressed RS1038 warning in the
project file. These changes improve code clarity and leverage
modern C# syntax.

Author: electricessence

Analyzers/Open.Text.Analyzers.csproj

@@ -6,6 +6,7 @@
     <Nullable>enable</Nullable>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <IsRoslynComponent>true</IsRoslynComponent>
+    <NoWarn>RS1038</NoWarn>
 
     <!-- NuGet Package settings -->
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>

Analyzers/SplitAnalyzer.cs

@@ -1,9 +1,9 @@
-using System.Collections.Immutable;
-using System.Linq;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
+using System.Collections.Immutable;
+using System.Linq;
 
 namespace Open.Text.Analyzers;
 
@@ -13,10 +13,11 @@ namespace Open.Text.Analyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public class SplitAnalyzer : DiagnosticAnalyzer
 {
-	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(
-			DiagnosticDescriptors.UseSplitAsSegments,
-			DiagnosticDescriptors.UseFirstSplitInsteadOfSplitFirst,
-			DiagnosticDescriptors.UseSplitToEnumerable);
+	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [
+		DiagnosticDescriptors.UseSplitAsSegments,
+		DiagnosticDescriptors.UseFirstSplitInsteadOfSplitFirst,
+		DiagnosticDescriptors.UseSplitToEnumerable,
+	];
 
 	public override void Initialize(AnalysisContext context)
 	{

Analyzers/SplitCodeFixProvider.cs

@@ -17,10 +17,11 @@ namespace Open.Text.Analyzers;
 [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(SplitCodeFixProvider)), Shared]
 public class SplitCodeFixProvider : CodeFixProvider
 {
-	public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(
-			DiagnosticDescriptors.UseSplitAsSegments.Id,
-			DiagnosticDescriptors.UseFirstSplitInsteadOfSplitFirst.Id,
-			DiagnosticDescriptors.UseSplitToEnumerable.Id);
+	public override ImmutableArray<string> FixableDiagnosticIds => [
+		DiagnosticDescriptors.UseSplitAsSegments.Id,
+		DiagnosticDescriptors.UseFirstSplitInsteadOfSplitFirst.Id,
+		DiagnosticDescriptors.UseSplitToEnumerable.Id,
+	];
 
 	public override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer;
 

Analyzers/StringConcatenationAnalyzer.cs

@@ -12,7 +12,7 @@ namespace Open.Text.Analyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public class StringConcatenationAnalyzer : DiagnosticAnalyzer
 {
-	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(DiagnosticDescriptors.UseStringBuilderInLoop);
+	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [DiagnosticDescriptors.UseStringBuilderInLoop];
 
 	public override void Initialize(AnalysisContext context)
 	{

Tests/AssertionExtensions.cs

@@ -7,42 +7,30 @@ public static class AssertionExtensions
 {
 	public static AssertionResult<T> Should<T>(this T actual) => new(actual);
 
-	public readonly struct AssertionResult<T>
+	public readonly struct AssertionResult<T>(T actual)
 	{
-		private readonly T _actual;
+		public void Be(T expected) => Assert.Equal(expected, actual);
 
-		public AssertionResult(T actual) => _actual = actual;
-
-		public void Be(T expected) => Assert.Equal(expected, _actual);
-		
-		public void BeEquivalentTo(T expected) => Assert.Equal(expected, _actual);
+		public void BeEquivalentTo(T expected) => Assert.Equal(expected, actual);
 	}
 
 	public static BoolAssertionResult Should(this bool actual) => new(actual);
 
-	public readonly struct BoolAssertionResult
+	public readonly struct BoolAssertionResult(bool actual)
 	{
-		private readonly bool _actual;
+		public void Be(bool expected) => Assert.Equal(expected, actual);
 
-		public BoolAssertionResult(bool actual) => _actual = actual;
+		public void BeTrue() => Assert.True(actual);
 
-		public void Be(bool expected) => Assert.Equal(expected, _actual);
-		
-		public void BeTrue() => Assert.True(_actual);
-		
-		public void BeFalse() => Assert.False(_actual);
+		public void BeFalse() => Assert.False(actual);
 	}
 
 	public static StringAssertionResult Should(this string? actual) => new(actual);
 
-	public readonly struct StringAssertionResult
+	public readonly struct StringAssertionResult(string? actual)
 	{
-		private readonly string? _actual;
-
-		public StringAssertionResult(string? actual) => _actual = actual;
+		public void Be(string? expected) => Assert.Equal(expected, actual);
 
-		public void Be(string? expected) => Assert.Equal(expected, _actual);
-		
-		public void BeEquivalentTo(string? expected) => Assert.Equal(expected, _actual);
+		public void BeEquivalentTo(string? expected) => Assert.Equal(expected, actual);
 	}
 }