Merge pull request #5 from Open-NET-Libraries/StringBuilderHelper

StringBuilderHelper

Author: electricessence

.editorconfig

@@ -220,6 +220,11 @@ csharp_style_prefer_top_level_statements = true:silent
 csharp_style_prefer_local_over_anonymous_function = true:suggestion
 csharp_style_prefer_tuple_swap = true:suggestion
 csharp_style_prefer_utf8_string_literals = true:suggestion
+csharp_style_prefer_primary_constructors = true:suggestion
+dotnet_diagnostic.SYSLIB1045.severity = silent
+
+# IDE0055: Fix formatting
+dotnet_diagnostic.IDE0055.severity = silent
 
 [*.{cs,vb}]
 dotnet_style_operator_placement_when_wrapping = beginning_of_line
@@ -244,4 +249,7 @@ dotnet_style_prefer_inferred_tuple_names = true:suggestion
 dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
 dotnet_style_prefer_compound_assignment = true:suggestion
 dotnet_style_prefer_simplified_interpolation = true:suggestion
-dotnet_style_namespace_match_folder = true:suggestion
+dotnet_style_namespace_match_folder = true:suggestion
+dotnet_diagnostic.CA1510.severity = silent
+dotnet_diagnostic.CA1512.severity = silent
+dotnet_diagnostic.CA1863.severity = none

Benchmarks/EnumParseTests.cs

@@ -51,8 +51,8 @@ public bool IgnoreCase
 		}
 	}
 
-	static readonly string[] ValidValues = new string[] { nameof(Greek.Alpha), nameof(Greek.Epsilon), nameof(Greek.Phi), nameof(Greek.Beta), nameof(Greek.Gamma) };
-	static readonly string[] InvalidValues = new string[] { "Apple", "Orange", "Pineapple", "Grapefruit", "Lemon" };
+	static readonly string[] ValidValues = [nameof(Greek.Alpha), nameof(Greek.Epsilon), nameof(Greek.Phi), nameof(Greek.Beta), nameof(Greek.Gamma)];
+	static readonly string[] InvalidValues = ["Apple", "Orange", "Pineapple", "Grapefruit", "Lemon"];
 
 	// To avoid branching overhead when benchmarking.
 	abstract class Tests
@@ -67,7 +67,7 @@ abstract class Tests
 
 		public abstract Greek CompiledSwitchByLength();
 
-		static readonly IDictionary<string, Greek> LookupD
+		static readonly Dictionary<string, Greek> LookupD
 			= Enum
 			.GetValues<Greek>()
 			.ToDictionary(e => Enum.GetName(e)!, e => e, StringComparer.Ordinal);
@@ -260,7 +260,7 @@ public override Greek FastEnumParse()
 			return e;
 		}
 
-		static readonly IDictionary<string, Greek> LookupD
+		static readonly Dictionary<string, Greek> LookupD
 			= Enum
 			.GetValues<Greek>()
 			.ToDictionary(e => Enum.GetName(e)!, e => e, StringComparer.OrdinalIgnoreCase);
@@ -326,7 +326,7 @@ public override Greek FastEnumParse()
 			return e;
 		}
 
-		static readonly IDictionary<string, Greek> LookupD
+		static readonly Dictionary<string, Greek> LookupD
 			= Enum
 			.GetValues<Greek>()
 			.ToDictionary(e => Enum.GetName(e)!, e => e, StringComparer.OrdinalIgnoreCase);

Benchmarks/Greek.cs

@@ -1,16 +1,10 @@
 namespace Open.Text.Benchmarks;
 
 [AttributeUsage(AttributeTargets.Field)]
-public class LetterAttribute : Attribute
+public class LetterAttribute(char upper, char lower) : Attribute
 {
-	public LetterAttribute(char upper, char lower)
-	{
-		Upper = upper;
-		Lower = lower;
-	}
-
-	public char Upper { get; }
-	public char Lower { get; }
+	public char Upper { get; } = upper;
+	public char Lower { get; } = lower;
 
 	public bool EqualsLetter(char letter)
 		=> letter == Upper || letter == Lower;

Benchmarks/Open.Text.Benchmarks.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Benchmarks/Program.cs

@@ -1,8 +1,9 @@
 using BenchmarkDotNet.Running;
 using Open.Text.Benchmarks;
 
-BenchmarkRunner.Run<EnumParseTests>();
+//BenchmarkRunner.Run<EnumParseTests>();
 //enchmarkRunner.Run<EnumToStringTests>();
 //BenchmarkRunner.Run<CharAssumptionTests>();
 //BenchmarkRunner.Run<EnumAttributeTests>();
 //BenchmarkRunner.Run<IsDefinedTests>();
+BenchmarkRunner.Run<StringConcatTests>();

Benchmarks/StringConcatTests.cs

@@ -0,0 +1,81 @@
+using BenchmarkDotNet.Attributes;
+using Microsoft.Extensions.Primitives;
+using System.Text;
+using System.Diagnostics.CodeAnalysis;
+
+namespace Open.Text.Benchmarks;
+
+[MemoryDiagnoser]
+[SuppressMessage("Performance", "CA1822:Mark members as static")]
+public class StringConcatTests
+{
+	public static readonly string Phrase
+		= "Hello I'm from andromeda. Take me to your leader. There is nothing to fear.";
+
+	private static readonly ReadOnlyMemory<string> Words = Phrase.Split(' ');
+
+	private static readonly ReadOnlyMemory<StringSegment> Segments = Phrase.SplitAsSegments(' ').ToArray();
+
+	[Benchmark(Baseline = true)]
+	public string StringOperator()
+	{
+		var s = "";
+		{
+			var len = Words.Length;
+			var span = Words.Span;
+			for (var i = 0; i < len; i++)
+				s += span[i];
+		}
+
+		{
+			var len = Segments.Length;
+			var span = Segments.Span;
+			for (var i = 0; i < len; i++)
+				s += span[i].ToString();
+		}
+
+		return s;
+	}
+
+	[Benchmark]
+	public string StringBuilder()
+	{
+		var sb = new StringBuilder();
+		{
+			var len = Words.Length;
+			var span = Words.Span;
+			for (var i = 0; i < len; i++)
+				sb.Append(span[i]);
+		}
+
+		{
+			var len = Segments.Length;
+			var span = Segments.Span;
+			for (var i = 0; i < len; i++)
+				sb.AppendSegment(span[i]);
+		}
+
+		return sb.ToString();
+	}
+
+	[Benchmark]
+	public string StringBuilderHelper()
+	{
+		StringBuilderHelper s = "";
+		{
+			var len = Words.Length;
+			var span = Words.Span;
+			for (var i = 0; i < len; i++)
+				s += span[i];
+		}
+
+		{
+			var len = Segments.Length;
+			var span = Segments.Span;
+			for (var i = 0; i < len; i++)
+				s += span[i];
+		}
+
+		return s;
+	}
+}