Skip to content

Commit 0082af4

Browse files
Refactor test assertions and minor test data cleanup
Updated RegexTests and SplitTests to simplify test data and assertions: replaced unnecessary ToArray() calls in SplitTests, switched to default! for null argument tests, and standardized InlineData string literals. These changes improve code clarity and reduce allocations in test code.
1 parent 02cba54 commit 0082af4

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

Tests/RegexTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public static void GroupNameTest()
4848
[Theory]
4949
[InlineData(@"\w+", "Hello, world! How are you?")]
5050
[InlineData(@"\d+", "abc123def456ghi789")]
51-
[InlineData(@"[aeiou]", "Hello World")]
51+
[InlineData("[aeiou]", "Hello World")]
5252
public static void AsSegments(string patternStr, string input)
5353
{
5454
var pattern = new Regex(patternStr);
@@ -64,6 +64,6 @@ public static void AsSegmentsNoAlloc_ThrowsOnNull()
6464
{
6565
var pattern = new Regex(@"\w+");
6666
Assert.Throws<ArgumentNullException>(() => default(Regex)!.AsSegmentsNoAlloc("test"));
67-
Assert.Throws<ArgumentNullException>(() => pattern.AsSegmentsNoAlloc(default(string)!));
67+
Assert.Throws<ArgumentNullException>(() => pattern.AsSegmentsNoAlloc(default!));
6868
}
6969
}

Tests/SplitTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,9 @@ public static void Split(string sequence, StringSplitOptions options = StringSpl
163163
public static void SplitIgnoreCase(string sequence, string split, string expected, StringSplitOptions options = StringSplitOptions.None)
164164
{
165165
var segments = expected.Split(',');
166-
Assert.Equal(segments, sequence.SplitToEnumerable(split, options, StringComparison.OrdinalIgnoreCase).ToArray());
167-
Assert.Equal(segments, sequence.SplitAsMemory(split, options, StringComparison.OrdinalIgnoreCase).Select(m => m.Span.ToString()).ToArray());
168-
Assert.Equal(segments, sequence.SplitAsSegments(split, options, StringComparison.OrdinalIgnoreCase).Select(m => m.ToString()).ToArray());
166+
Assert.Equal(segments, sequence.SplitToEnumerable(split, options, StringComparison.OrdinalIgnoreCase));
167+
Assert.Equal(segments, sequence.SplitAsMemory(split, options, StringComparison.OrdinalIgnoreCase).Select(m => m.Span.ToString()));
168+
Assert.Equal(segments, sequence.SplitAsSegments(split, options, StringComparison.OrdinalIgnoreCase).Select(m => m.ToString()));
169169
// NoAlloc variants
170170
Assert.Equal(segments, sequence.SplitToEnumerableNoAlloc(split, options, StringComparison.OrdinalIgnoreCase).ToArray());
171171
Assert.Equal(segments, sequence.SplitAsMemoryNoAlloc(split, options, StringComparison.OrdinalIgnoreCase).Select(m => m.Span.ToString()).ToArray());

0 commit comments

Comments
 (0)